[ovs-git] [openvswitch/ovs] 0f8469: ofp-msgs: Remove unnecessary #include.

GitHub noreply at github.com
Tue Feb 21 19:37:47 UTC 2017


  Branch: refs/heads/master
  Home:   https://github.com/openvswitch/ovs
  Commit: 0f8469b4c0dd0e4b2d529a6c5b1bc585e768959d
      https://github.com/openvswitch/ovs/commit/0f8469b4c0dd0e4b2d529a6c5b1bc585e768959d
  Author: Yi-Hung Wei <yihung.wei at gmail.com>
  Date:   2017-02-21 (Tue, 21 Feb 2017)

  Changed paths:
    M include/openvswitch/ofp-msgs.h

  Log Message:
  -----------
  ofp-msgs: Remove unnecessary #include.

Include of lib/*.h from include/openvswitch/*.h is disallowed.

Signed-off-by: Yi-Hung Wei <yihung.wei at gmail.com>
Signed-off-by: Joe Stringer <joe at ovn.org>


  Commit: aafee638217b24eb165e052866a9be4e3f695ce9
      https://github.com/openvswitch/ovs/commit/aafee638217b24eb165e052866a9be4e3f695ce9
  Author: Yi-Hung Wei <yihung.wei at gmail.com>
  Date:   2017-02-21 (Tue, 21 Feb 2017)

  Changed paths:
    M build-aux/extract-ofp-fields
    M include/openvswitch/meta-flow.h
    M include/openvswitch/ofp-actions.h
    M include/openvswitch/ofp-util.h
    M lib/automake.mk
    M lib/meta-flow.c
    M lib/nx-match.c
    M lib/nx-match.h
    M lib/ofp-actions.c
    A lib/vl-mff-map.h
    M ofproto/ofproto-provider.h

  Log Message:
  -----------
  meta-flow: Remove cmap dependency.

Previous patch 04f48a68 ("ofp-actions: Fix variable length meta-flow OXMs.")
introduced dependency of an internal library (cmap.h) to ovs public
interface (meta-flow.h) that may cause potential building problem. In this
patch, we remove cmap from struct mf_field, and provide a wrapper struct
vl_mff_map that resolve the dependency problem.

Fixes: 04f48a68c428 ("ofp-actions: Fix variable length meta-flow OXMs.")
Suggested-by: Joe Stringer <joe at ovn.org>
Suggested-by: Daniele Di Proietto <diproiettod at vmware.com>
Signed-off-by: Yi-Hung Wei <yihung.wei at gmail.com>
Signed-off-by: Joe Stringer <joe at ovn.org>


  Commit: c458e4a372d1dc5e85885480bf482c3522a57922
      https://github.com/openvswitch/ovs/commit/c458e4a372d1dc5e85885480bf482c3522a57922
  Author: Yi-Hung Wei <yihung.wei at gmail.com>
  Date:   2017-02-21 (Tue, 21 Feb 2017)

  Changed paths:
    M Makefile.am

  Log Message:
  -----------
  Makefile.am: Avoid include/ depending on lib/.

Add a build check that public openvswitch header file should not include
internal library.

Suggested-by: Joe Stringer <joe at ovn.org>
Suggested-by: Daniele Di Proietto <diproiettod at vmware.com>
Signed-off-by: Yi-Hung Wei <yihung.wei at gmail.com>
Signed-off-by: Joe Stringer <joe at ovn.org>


Compare: https://github.com/openvswitch/ovs/compare/f626af7a2d96...c458e4a372d1


More information about the git mailing list