[ovs-git] [openvswitch/ovs] a28b5a: ofp-msgs: Remove unnecessary #include.

GitHub noreply at github.com
Tue Feb 21 20:33:17 UTC 2017


  Branch: refs/heads/branch-2.7
  Home:   https://github.com/openvswitch/ovs
  Commit: a28b5ad1bef021b841fd3b3ce1403be3af8f0f74
      https://github.com/openvswitch/ovs/commit/a28b5ad1bef021b841fd3b3ce1403be3af8f0f74
  Author: Yi-Hung Wei <yihung.wei at gmail.com>
  Date:   2017-02-21 (Tue, 21 Feb 2017)

  Changed paths:
    M include/openvswitch/ofp-msgs.h

  Log Message:
  -----------
  ofp-msgs: Remove unnecessary #include.

Include of lib/*.h from include/openvswitch/*.h is disallowed.

Signed-off-by: Yi-Hung Wei <yihung.wei at gmail.com>
Signed-off-by: Joe Stringer <joe at ovn.org>


  Commit: 4c1d0eb358ec63010d3a94fc21b4d684bca1e69b
      https://github.com/openvswitch/ovs/commit/4c1d0eb358ec63010d3a94fc21b4d684bca1e69b
  Author: Yi-Hung Wei <yihung.wei at gmail.com>
  Date:   2017-02-21 (Tue, 21 Feb 2017)

  Changed paths:
    M build-aux/extract-ofp-fields
    M include/openvswitch/meta-flow.h
    M include/openvswitch/ofp-actions.h
    M include/openvswitch/ofp-util.h
    M lib/automake.mk
    M lib/meta-flow.c
    M lib/nx-match.c
    M lib/nx-match.h
    M lib/ofp-actions.c
    A lib/vl-mff-map.h
    M ofproto/ofproto-provider.h

  Log Message:
  -----------
  meta-flow: Remove cmap dependency.

Previous patch 04f48a68 ("ofp-actions: Fix variable length meta-flow OXMs.")
introduced dependency of an internal library (cmap.h) to ovs public
interface (meta-flow.h) that may cause potential building problem. In this
patch, we remove cmap from struct mf_field, and provide a wrapper struct
vl_mff_map that resolve the dependency problem.

Fixes: 04f48a68c428 ("ofp-actions: Fix variable length meta-flow OXMs.")
Suggested-by: Joe Stringer <joe at ovn.org>
Suggested-by: Daniele Di Proietto <diproiettod at vmware.com>
Signed-off-by: Yi-Hung Wei <yihung.wei at gmail.com>
Signed-off-by: Joe Stringer <joe at ovn.org>


  Commit: c66ddfe404c0675fa3b7c81ef9c3407d0c5b4c6d
      https://github.com/openvswitch/ovs/commit/c66ddfe404c0675fa3b7c81ef9c3407d0c5b4c6d
  Author: Yi-Hung Wei <yihung.wei at gmail.com>
  Date:   2017-02-21 (Tue, 21 Feb 2017)

  Changed paths:
    M Makefile.am

  Log Message:
  -----------
  Makefile.am: Avoid include/ depending on lib/.

Add a build check that public openvswitch header file should not include
internal library.

Suggested-by: Joe Stringer <joe at ovn.org>
Suggested-by: Daniele Di Proietto <diproiettod at vmware.com>
Signed-off-by: Yi-Hung Wei <yihung.wei at gmail.com>
Signed-off-by: Joe Stringer <joe at ovn.org>


Compare: https://github.com/openvswitch/ovs/compare/d5987ab72274...c66ddfe404c0


More information about the git mailing list