[ovs-git] [openvswitch/ovs] bd4e17: netdev-dpdk: Assign socket id according to device'...

GitHub noreply at github.com
Thu Jan 12 02:44:33 UTC 2017


  Branch: refs/heads/master
  Home:   https://github.com/openvswitch/ovs
  Commit: bd4e172b287c76bf9fea0a5afa751dc3fe37e2d4
      https://github.com/openvswitch/ovs/commit/bd4e172b287c76bf9fea0a5afa751dc3fe37e2d4
  Author: xu.binbin1 at zte.com.cn <xu.binbin1 at zte.com.cn>
  Date:   2017-01-11 (Wed, 11 Jan 2017)

  Changed paths:
    M lib/netdev-dpdk.c

  Log Message:
  -----------
  netdev-dpdk: Assign socket id according to device's numa id

We can hotplug attach DPDK ports specified via the 'dpdk-devargs'
option now.

But the socket id of DPDK ports can't be assigned correctly,
it is always 0. The socket id of DPDK ports should be assigned
according to the numa id of the device.

Fixes: 55e075e65ef9e ("netdev-dpdk: Arbitrary 'dpdk' port naming")
Signed-off-by: Binbin Xu <xu.binbin1 at zte.com.cn>
Acked-by: Ciara Loftus <ciara.loftus at intel.com>
Acked-by: Kevin Traynor <ktraynor at redhat.com>
Signed-off-by: Daniele Di Proietto <diproiettod at vmware.com>


  Commit: 9fff138ec3a6dbe75073d16cba7fbe86ac273c36
      https://github.com/openvswitch/ovs/commit/9fff138ec3a6dbe75073d16cba7fbe86ac273c36
  Author: Daniele Di Proietto <diproiettod at vmware.com>
  Date:   2017-01-11 (Wed, 11 Jan 2017)

  Changed paths:
    M lib/netdev-dpdk.c
    M lib/netdev-dummy.c
    M lib/netdev-provider.h
    M lib/netdev-vport.c
    M lib/netdev.c

  Log Message:
  -----------
  netdev: Add 'errp' to set_config().

Since 55e075e65ef9("netdev-dpdk: Arbitrary 'dpdk' port naming"),
set_config() is used to identify a DPDK device, so it's better to report
its detailed error message to the user.  Tunnel devices and patch ports
rely a lot on set_config() as well.

This commit adds a param to set_config() that can be used to return
an error message and makes use of that in netdev-dpdk and netdev-vport.

Before this patch:

$ ovs-vsctl add-port br0 dpdk0 -- set Interface dpdk0 type=dpdk
ovs-vsctl: Error detected while setting up 'dpdk0': dpdk0: could not set
    configuration (Invalid argument).  See ovs-vswitchd log for details.
ovs-vsctl: The default log directory is "/var/log/openvswitch/".

$ ovs-vsctl add-port br0 p+ -- set Interface p+ type=patch
ovs-vsctl: Error detected while setting up 'p+': p+: could not set
    configuration (Invalid argument).  See ovs-vswitchd log for details.
ovs-vsctl: The default log directory is "/var/log/openvswitch/".

$ ovs-vsctl add-port br0 gnv0 -- set Interface gnv0 type=geneve
ovs-vsctl: Error detected while setting up 'gnv0': gnv0: could not set
    configuration (Invalid argument).  See ovs-vswitchd log for details.
ovs-vsctl: The default log directory is "/var/log/openvswitch/".

After this patch:

$ ovs-vsctl add-port br0 dpdk0 -- set Interface dpdk0 type=dpdk
ovs-vsctl: Error detected while setting up 'dpdk0': 'dpdk0' is missing
    'options:dpdk-devargs'. The old 'dpdk<port_id>' names are not
    supported.  See ovs-vswitchd log for details.
ovs-vsctl: The default log directory is "/var/log/openvswitch/".

$ ovs-vsctl add-port br0 p+ -- set Interface p+ type=patch
ovs-vsctl: Error detected while setting up 'p+': p+: patch type requires
    valid 'peer' argument.  See ovs-vswitchd log for details.
ovs-vsctl: The default log directory is "/var/log/openvswitch/".

$ ovs-vsctl add-port br0 gnv0 -- set Interface gnv0 type=geneve
ovs-vsctl: Error detected while setting up 'gnv0': gnv0: geneve type
    requires valid 'remote_ip' argument.  See ovs-vswitchd log for
    details.
ovs-vsctl: The default log directory is "/var/log/openvswitch/".

CC: Ciara Loftus <ciara.loftus at intel.com>
CC: Kevin Traynor <ktraynor at redhat.com>
Signed-off-by: Daniele Di Proietto <diproiettod at vmware.com>
Acked-by: Kevin Traynor <ktraynor at redhat.com>
Tested-by: Ciara Loftus <ciara.loftus at intel.com>


Compare: https://github.com/openvswitch/ovs/compare/353fe1e149c6...9fff138ec3a6


More information about the git mailing list