[ovs-git] [openvswitch/ovs] 3f5b5f: db-ctl-base: Always support all tables in schema.

GitHub noreply at github.com
Fri Jan 13 21:17:41 UTC 2017

  Branch: refs/heads/master
  Home:   https://github.com/openvswitch/ovs
  Commit: 3f5b5f7b411553e0421e37b49dc5deeaede56308
  Author: Ben Pfaff <blp at ovn.org>
  Date:   2017-01-13 (Fri, 13 Jan 2017)

  Changed paths:
    M lib/db-ctl-base.c
    M lib/db-ctl-base.h
    M ovn/utilities/ovn-nbctl.c
    M ovn/utilities/ovn-sbctl.c
    M utilities/ovs-vsctl.c
    M vtep/vtep-ctl.c

  Log Message:
  db-ctl-base: Always support all tables in schema.

When one adds a new table to a database schema, it's easy to forget to
add the table to the list of tables in the *ctl.c program.  When this
happens, the database commands for that program don't work on that table
at all, even for commands like "list" and "create" that don't need any
special help.  This patch fixes that problem, by making sure that
db-ctl-base always has the complete list of tables.

Previously, each ctl_table_class pointed directly to the corresponding
ovsdb_idl_table_class.  With this patch, there are instead two parallel
arrays, one of ovsdb_idl_table_classes and the other of ctl_table_classes.
This change accounts for the bulk of the change to the db-ctl-base code.

Signed-off-by: Ben Pfaff <blp at ovn.org>
Acked-by: Lance Richardson <lrichard at redhat.com>

More information about the git mailing list