[ovs-git] [openvswitch/ovs] 80b674: actions: Make "free" functions per-struct, not per...

GitHub noreply at github.com
Sat Jan 21 20:31:14 UTC 2017


  Branch: refs/heads/master
  Home:   https://github.com/openvswitch/ovs
  Commit: 80b6743d0ab3a39884fe873dd616cb49b6f55fab
      https://github.com/openvswitch/ovs/commit/80b6743d0ab3a39884fe873dd616cb49b6f55fab
  Author: Ben Pfaff <blp at ovn.org>
  Date:   2017-01-21 (Sat, 21 Jan 2017)

  Changed paths:
    M ovn/lib/actions.c

  Log Message:
  -----------
  actions: Make "free" functions per-struct, not per-action.

In some cases multiple kinds of OVN action share the same structure.  In
all of these cases, a given kind of structure is freed one particular way
(it would be confusing if this were not the case), so there's no benefit
in having per-action free functions.  Therefore, this commit switches to
a free function per structure type.

Signed-off-by: Ben Pfaff <blp at ovn.org>
Acked-by: Mickey Spiegel <mickeys.dev at gmail.com>


  Commit: b3bd2c33e83e2039d75e830368a64d596f820aaa
      https://github.com/openvswitch/ovs/commit/b3bd2c33e83e2039d75e830368a64d596f820aaa
  Author: Ben Pfaff <blp at ovn.org>
  Date:   2017-01-21 (Sat, 21 Jan 2017)

  Changed paths:
    M include/ovn/actions.h
    M ovn/lib/actions.c
    M ovn/ovn-sb.xml
    M ovn/utilities/ovn-trace.c
    M tests/ovn.at

  Log Message:
  -----------
  actions: Add new OVN action "clone".

Signed-off-by: Ben Pfaff <blp at ovn.org>
Acked-by: Mickey Spiegel <mickeys.dev at gmail.com>


  Commit: ebb467ff1c255813d6ba27d91ef6180e9a20fe0a
      https://github.com/openvswitch/ovs/commit/ebb467ff1c255813d6ba27d91ef6180e9a20fe0a
  Author: Ben Pfaff <blp at ovn.org>
  Date:   2017-01-21 (Sat, 21 Jan 2017)

  Changed paths:
    M include/ovn/actions.h
    M ovn/lib/actions.c

  Log Message:
  -----------
  actions: Separate action structures for "next" and "ct_next".

These actions aren't very similar but until now they both had the same
action structure.  These structures are going to diverge in an upcoming
commit, so separate them now.

Signed-off-by: Ben Pfaff <blp at ovn.org>
Acked-by: Mickey Spiegel <mickeys.dev at gmail.com>


  Commit: 8f5de08322673f4e60f44d599fa7ee4de65bc078
      https://github.com/openvswitch/ovs/commit/8f5de08322673f4e60f44d599fa7ee4de65bc078
  Author: Ben Pfaff <blp at ovn.org>
  Date:   2017-01-21 (Sat, 21 Jan 2017)

  Changed paths:
    M include/ovn/actions.h
    M ovn/lib/actions.c
    M tests/ovn.at

  Log Message:
  -----------
  actions: Omit table number when possible for formatting "next" action.

Until now, formatting the "next" action has always required including
the table number, because the action struct didn't include enough context
so that the formatter could decide whether the table number was the next
table or some other table.  This is more or less OK, but an upcoming commit
will add a "pipeline" field to the "next" action, which means that the same
policy there would require that the pipeline always be printed.  That's a
little obnoxious because 99+% of the time, the pipeline to be printed is
the same pipeline that the flow is in and printing it would be distracting.
So it's better to store some context to help with formatting.  This commit
begins adopting that policy for the existing table number field.

Signed-off-by: Ben Pfaff <blp at ovn.org>
Acked-by: Mickey Spiegel <mickeys.dev at gmail.com>


  Commit: c571f48c36223de360ba0fa4d89104a7da14dbca
      https://github.com/openvswitch/ovs/commit/c571f48c36223de360ba0fa4d89104a7da14dbca
  Author: Ben Pfaff <blp at ovn.org>
  Date:   2017-01-21 (Sat, 21 Jan 2017)

  Changed paths:
    M include/ovn/actions.h
    M ovn/utilities/ovn-trace.c

  Log Message:
  -----------
  actions: Introduce enum ovnact_pipeline.

This isn't used yet by the actions code, but an upcoming commit will
introduce a user.  This commit just adjusts ovn-trace to use this common
type instead of its own local type.

Signed-off-by: Ben Pfaff <blp at ovn.org>
Acked-by: Mickey Spiegel <mickeys.dev at gmail.com>


  Commit: 4c99cb181b6937efb3819cffc9765999fd7b7796
      https://github.com/openvswitch/ovs/commit/4c99cb181b6937efb3819cffc9765999fd7b7796
  Author: Ben Pfaff <blp at ovn.org>
  Date:   2017-01-21 (Sat, 21 Jan 2017)

  Changed paths:
    M include/ovn/actions.h
    M ovn/controller/lflow.c
    M ovn/lib/actions.c
    M ovn/ovn-sb.xml
    M ovn/utilities/ovn-trace.c
    M tests/ovn.at
    M tests/test-ovn.c

  Log Message:
  -----------
  actions: Make "next" action able to jump from egress to ingress pipeline.

This feature is useful for centralized gateways.

Signed-off-by: Ben Pfaff <blp at ovn.org>
Acked-by: Mickey Spiegel <mickeys.dev at gmail.com>


  Commit: db0e819be065c1474ceef232dcc1260c9a2e7c0e
      https://github.com/openvswitch/ovs/commit/db0e819be065c1474ceef232dcc1260c9a2e7c0e
  Author: Ben Pfaff <blp at ovn.org>
  Date:   2017-01-21 (Sat, 21 Jan 2017)

  Changed paths:
    M include/ovn/actions.h
    M ovn/lib/actions.c
    M ovn/ovn-sb.xml
    M ovn/utilities/ovn-trace.c
    M tests/ovn.at

  Log Message:
  -----------
  actions: Add new "ct_clear" action.

Signed-off-by: Ben Pfaff <blp at ovn.org>
Acked-by: Mickey Spiegel <mickeys.dev at gmail.com>


Compare: https://github.com/openvswitch/ovs/compare/66f56ca5733d...db0e819be065


More information about the git mailing list