[ovs-git] [openvswitch/ovs] 0770d1: windows: WSAPoll broken on windows

GitHub noreply at github.com
Fri Jan 27 20:37:14 UTC 2017


  Branch: refs/heads/branch-2.7
  Home:   https://github.com/openvswitch/ovs
  Commit: 0770d1f8d5ebf761f6e324d01f28de2e8207e5e8
      https://github.com/openvswitch/ovs/commit/0770d1f8d5ebf761f6e324d01f28de2e8207e5e8
  Author: Alin Serdean <aserdean at cloudbasesolutions.com>
  Date:   2017-01-27 (Fri, 27 Jan 2017)

  Changed paths:
    M lib/socket-util.c

  Log Message:
  -----------
  windows: WSAPoll broken on windows

Unfortunately, WSAPoll misbehaves on Windows please view detailed behavior
on: https://github.com/openvswitch/ovs-issues/issues/117

We replace the WSAPoll with select looking only for errors and write events.

Reported-at: https://github.com/openvswitch/ovs-issues/issues/117
Reported-by: Yin Lin <linyi at vmware.com>
Signed-off-by: Alin Gabriel Serdean <aserdean at cloudbasesolutions.com>
Acked-by: Sairam Venugopal <vsairam at vmware.com>
Signed-off-by: Gurucharan Shetty <guru at ovn.org>


  Commit: b23938da2fc32b01a2352dd4141e057a203a89e7
      https://github.com/openvswitch/ovs/commit/b23938da2fc32b01a2352dd4141e057a203a89e7
  Author: Sairam Venugopal <vsairam at vmware.com>
  Date:   2017-01-27 (Fri, 27 Jan 2017)

  Changed paths:
    M lib/wmi.c

  Log Message:
  -----------
  Windows: Fix wmi.c to use count of wchar_t instead of sizeof

wcscat_s and wcscpy_s requires number of elements as argument. wchar_t
uses 2 bytes for storage and using sizeof(internal_port_query) causes
access violation error on Windows 2012 R2 (64 bit). This patch introduces
a #define WMI_QUERY_COUNT set to 2048 and uses that instead.

Reported-by: Sairam Venugopal <vsairam at vmware.com>
Reported-at: openvswitch/ovs-issues#121
Signed-off-by: Sairam Venugopal <vsairam at vmware.com>
Acked-by: Alin Gabriel Serdean <aserdean at cloudbasesolutions.com>
Signed-off-by: Gurucharan Shetty <guru at ovn.org>


Compare: https://github.com/openvswitch/ovs/compare/87b762122e93...b23938da2fc3


More information about the git mailing list