[ovs-git] [openvswitch/ovs] 308bf9: Makefiles: Fail build for flake8 only when configu...

[GitHub]

  Branch: refs/heads/master
  Home:   https://github.com/openvswitch/ovs
  Commit: 308bf9880826bb717a271e5128326ef2fbb903c0
      https://github.com/openvswitch/ovs/commit/308bf9880826bb717a271e5128326ef2fbb903c0
  Author: Ben Pfaff <blp at ovn.org>
  Date:   2017-07-07 (Fri, 07 Jul 2017)

  Changed paths:
    M Makefile.am
    M acinclude.m4

  Log Message:
  -----------
  Makefiles: Fail build for flake8 only when configured with --enable-Werror.

flake8 checking is useful.  Until now, it always failed the build for any
flake8 errors.  This is too aggressive, for the same reason that always
failing the build for any compiler warnings is too aggressive: compilers
change over time and asynchronously from OVS itself.  Thus, if we release
some version of OVS today, even if it's flake8-clean today, it might not
be flake8-clean tomorrow, even with the same settings.  We don't want to
have to track flake8 warnings on every release branch.

Thus, this adopts the same policy for compiler warnings: always report
them, but only fail the build if --enable-Werror was configured.  Usually
just developers use that configure option, and they're prepared to deal
with the fallout.

Signed-off-by: Ben Pfaff <blp at ovn.org>
Acked-by: Russell Bryant <russell at ovn.org>