[ovs-git] [openvswitch/ovs] 371a74: ovn-controller: fix use-after-free in physical_run...

[GitHub]

  Branch: refs/heads/master
  Home:   https://github.com/openvswitch/ovs
  Commit: 371a74df104224d5adc3539ae285fd1374473a5d
      https://github.com/openvswitch/ovs/commit/371a74df104224d5adc3539ae285fd1374473a5d
  Author: Lance Richardson <lrichard at redhat.com>
  Date:   2017-07-11 (Tue, 11 Jul 2017)

  Changed paths:
    M ovn/controller/physical.c

  Log Message:
  -----------
  ovn-controller: fix use-after-free in physical_run()

The hmap "tunnels" is persistent across IDL loop iterations, but
stores pointers to strings in the local db replica which can be
freed as database updates are processed. Fix by storing a copy
of the string in the hmap instead of a pointer to the string in
the replica.

Found via valgrind.

Fixes: 40128e371ec3 ("physical: Refactor port binding processing.")
Signed-off-by: Lance Richardson <lrichard at redhat.com>
Signed-off-by: Ben Pfaff <blp at ovn.org>