[ovs-git] [openvswitch/ovs] 122f8a: ovn-controller: fix use-after-free in physical_run...

[GitHub]

  Branch: refs/heads/branch-2.6
  Home:   https://github.com/openvswitch/ovs
  Commit: 122f8af409cd3e47e84055b4b8ecd7ab5167d1a0
      https://github.com/openvswitch/ovs/commit/122f8af409cd3e47e84055b4b8ecd7ab5167d1a0
  Author: Lance Richardson <lrichard at redhat.com>
  Date:   2017-07-11 (Tue, 11 Jul 2017)

  Changed paths:
    M ovn/controller/physical.c

  Log Message:
  -----------
  ovn-controller: fix use-after-free in physical_run()

The hmap "tunnels" is persistent across IDL loop iterations, but
stores pointers to strings in the local db replica which can be
freed as database updates are processed. Fix by storing a copy
of the string in the hmap instead of a pointer to the string in
the replica.

Found via valgrind.

Fixes: 40128e371ec3 ("physical: Refactor port binding processing.")
Signed-off-by: Lance Richardson <lrichard at redhat.com>
Signed-off-by: Ben Pfaff <blp at ovn.org>