[ovs-git] [openvswitch/ovs] 6cb5e5: ofproto-dpif-rid: Store tunnel metadata in frozen ...

GitHub noreply at github.com
Fri Jul 28 02:21:41 UTC 2017


  Branch: refs/heads/master
  Home:   https://github.com/openvswitch/ovs
  Commit: 6cb5e507973f30e8ca14b4bb518173a9ef51acfa
      https://github.com/openvswitch/ovs/commit/6cb5e507973f30e8ca14b4bb518173a9ef51acfa
  Author: Justin Pettit <jpettit at ovn.org>
  Date:   2017-07-27 (Thu, 27 Jul 2017)

  Changed paths:
    M ofproto/ofproto-dpif-rid.c
    M ofproto/ofproto-dpif-rid.h

  Log Message:
  -----------
  ofproto-dpif-rid: Store tunnel metadata in frozen metadata directly.

"recirc_id_node" contains a 'state_metadata_tunnel' member field.  The
"frozen_metadata" structure used by "recird_id_node" had a 'tunnel'
member that always pointed to 'state_metadata_tunnel".  This commit just
stores the tunnel information directly in "frozen_metadata" instead of
accessing it through a pointer.

This makes the code a bit simpler and easier to reason about.

Signed-off-by: Justin Pettit <jpettit at ovn.org>
Acked-by: Ben Pfaff <blp at ovn.org>


  Commit: 8014f465e27206638e2deb7bcfbb5aa75906778f
      https://github.com/openvswitch/ovs/commit/8014f465e27206638e2deb7bcfbb5aa75906778f
  Author: Justin Pettit <jpettit at ovn.org>
  Date:   2017-07-27 (Thu, 27 Jul 2017)

  Changed paths:
    M ofproto/ofproto-dpif-rid.c
    M ofproto/ofproto-dpif-rid.h
    M tests/ofproto-dpif.at

  Log Message:
  -----------
  ofproto-dpif-rid: Always store tunnel metadata.

Tunnel metadata was only stored if the tunnel destination was set.  It's
possible, for example, that a flow could set the tunnel id field before
recirculation and then set the destination field afterwards.  The
previous behavior is that the tunnel id would be lost during
recirculation under such a circumstance.  This changes the behavior to
always copy the tunnel metadata, regardless of whether the tunnel
destination is set.  It also adds a unit test.

Signed-off-by: Justin Pettit <jpettit at ovn.org>
Acked-by: Ben Pfaff <blp at ovn.org>


Compare: https://github.com/openvswitch/ovs/compare/fe70f381c18e...8014f465e272


More information about the git mailing list