[ovs-git] [openvswitch/ovs] 88a74b: ofp-parse: Fix memory leak on error path in parse_...

GitHub noreply at github.com
Thu Jun 1 23:25:09 UTC 2017


  Branch: refs/heads/master
  Home:   https://github.com/openvswitch/ovs
  Commit: 88a74b2060e58c821b0f01cdc36df48ee36be6e5
      https://github.com/openvswitch/ovs/commit/88a74b2060e58c821b0f01cdc36df48ee36be6e5
  Author: Ben Pfaff <blp at ovn.org>
  Date:   2017-06-01 (Thu, 01 Jun 2017)

  Changed paths:
    M lib/ofp-parse.c

  Log Message:
  -----------
  ofp-parse: Fix memory leak on error path in parse_ofp_group_mod_file().

Found by Coverity.

Reported-by: https://scan3.coverity.com/reports.htm#v16889/p10449/fileInstanceId=14762655&defectInstanceId=4305334&mergedDefectId=180394
Signed-off-by: Ben Pfaff <blp at ovn.org>
Acked-by: Justin Pettit <jpettit at ovn.org>


  Commit: a0e3d14e3553da08dd906ac6eb0c292d1338dd62
      https://github.com/openvswitch/ovs/commit/a0e3d14e3553da08dd906ac6eb0c292d1338dd62
  Author: Ben Pfaff <blp at ovn.org>
  Date:   2017-06-01 (Thu, 01 Jun 2017)

  Changed paths:
    M ovn/lib/actions.c

  Log Message:
  -----------
  actions: Fix memory leak on error path in parse_ct_lb_action().

Found by Coverity.

Reported-at: https://scan3.coverity.com/reports.htm#v16889/p10449/fileInstanceId=14763031&defectInstanceId=4305318&mergedDefectId=180399
Signed-off-by: Ben Pfaff <blp at ovn.org>
Acked-by: Justin Pettit <jpettit at ovn.org>


  Commit: 1024553e2c161ccab6ef0015188d7ca2b615787f
      https://github.com/openvswitch/ovs/commit/1024553e2c161ccab6ef0015188d7ca2b615787f
  Author: Ben Pfaff <blp at ovn.org>
  Date:   2017-06-01 (Thu, 01 Jun 2017)

  Changed paths:
    M tests/test-packets.c

  Log Message:
  -----------
  test-packets: Check that ipv6_parse_masked() is successful.

Otherwise it returns an allocated string that we should print and free.

Found by Coverity.

Reported-at: https://scan3.coverity.com/reports.htm#v16889/p10449/fileInstanceId=14763114&defectInstanceId=4305332&mergedDefectId=180408
Signed-off-by: Ben Pfaff <blp at ovn.org>
Acked-by: Justin Pettit <jpettit at ovn.org>


  Commit: 08125baff54544d54e66155bc6274176bf96ee92
      https://github.com/openvswitch/ovs/commit/08125baff54544d54e66155bc6274176bf96ee92
  Author: Ben Pfaff <blp at ovn.org>
  Date:   2017-06-01 (Thu, 01 Jun 2017)

  Changed paths:
    M vswitchd/bridge.c

  Log Message:
  -----------
  bridge: Fix memory leak in bridge_aa_update_trunks().

Found by Coverity.

Reported-at: https://scan3.coverity.com/reports.htm#v16889/p10449/fileInstanceId=14763131&defectInstanceId=4305313&mergedDefectId=180411
Signed-off-by: Ben Pfaff <blp at ovn.org>
Acked-by: Justin Pettit <jpettit at ovn.org>


  Commit: 63ae068ebf3d0ff7e3cb8d810ef87766187b7821
      https://github.com/openvswitch/ovs/commit/63ae068ebf3d0ff7e3cb8d810ef87766187b7821
  Author: Ben Pfaff <blp at ovn.org>
  Date:   2017-06-01 (Thu, 01 Jun 2017)

  Changed paths:
    M utilities/ovs-ofctl.c

  Log Message:
  -----------
  ovs-ofctl: Close pcap file at end of ofctl_ofp_parse_pcap().

Seem wise even if not mandatory.

Found by Coverity.

Reported-at: https://scan3.coverity.com/reports.htm#v16889/p10449/fileInstanceId=14763047&defectInstanceId=4305314&mergedDefectId=180420
Signed-off-by: Ben Pfaff <blp at ovn.org>
Acked-by: Justin Pettit <jpettit at ovn.org>


  Commit: 7a36af8790c80c778601fad7fbceda5c4bbfb14a
      https://github.com/openvswitch/ovs/commit/7a36af8790c80c778601fad7fbceda5c4bbfb14a
  Author: Ben Pfaff <blp at ovn.org>
  Date:   2017-06-01 (Thu, 01 Jun 2017)

  Changed paths:
    M tests/test-conntrack.c

  Log Message:
  -----------
  test-conntrack: Close pcap file at end of test_pcap().

Seems wise, even if not strictly required.

Found by Coverity.

Reported-at: https://scan3.coverity.com/reports.htm#v16889/p10449/fileInstanceId=14763099&defectInstanceId=4305325&mergedDefectId=180413&fileStart=251&fileEnd=269
Signed-off-by: Ben Pfaff <blp at ovn.org>
Acked-by: Justin Pettit <jpettit at ovn.org>


  Commit: f582b6df9efd546c49c3577af407a989b5ffd215
      https://github.com/openvswitch/ovs/commit/f582b6df9efd546c49c3577af407a989b5ffd215
  Author: Ben Pfaff <blp at ovn.org>
  Date:   2017-06-01 (Thu, 01 Jun 2017)

  Changed paths:
    M lib/dpif-netdev.c

  Log Message:
  -----------
  dpif-netdev: Fix use-after-free error in reconfigure_datapath().

Found by Coverity.

Reported-at: https://scan3.coverity.com/reports.htm#v16889/p10449/fileInstanceId=14762915&defectInstanceId=4305352&mergedDefectId=180430
Signed-off-by: Ben Pfaff <blp at ovn.org>
Acked-by: Justin Pettit <jpettit at ovn.org>


Compare: https://github.com/openvswitch/ovs/compare/fedf8301957d...f582b6df9efd


More information about the git mailing list