[ovs-git] [openvswitch/ovs] d71350: ofp-util: Mask config value as intended in ofputil...
noreply at github.com
Thu Jun 1 23:44:02 UTC 2017
Author: Ben Pfaff <blp at ovn.org>
Date: 2017-06-01 (Thu, 01 Jun 2017)
ofp-util: Mask config value as intended in ofputil_decode_port_mod().
The code in ofputil_decode_port_mod() was originally meant to mask
the returned 'config' value against 'mask'. That is, only bits that are
marked in 'mask' as to be modified can be set to 1-bits in the returned
'config' value; it doesn't really entirely make sense otherwise. The
actual code to do this was dead, though. This fixes that problem.
In a quick skim of callers, I wasn't able to see an actual user-visible
bug that this fixes.
Found by Coverity.
Signed-off-by: Ben Pfaff <blp at ovn.org>
Acked-by: Justin Pettit <jpettit at ovn.org>
More information about the git