[ovs-git] [openvswitch/ovs] 62a78f: unaligned: Introduce helpers for 32-bit aligned 12...

GitHub noreply at github.com
Wed Jun 14 19:47:49 UTC 2017


  Branch: refs/heads/master
  Home:   https://github.com/openvswitch/ovs
  Commit: 62a78fe5d996cf01355bc090383ba7850609c864
      https://github.com/openvswitch/ovs/commit/62a78fe5d996cf01355bc090383ba7850609c864
  Author: Ben Pfaff <blp at ovn.org>
  Date:   2017-06-14 (Wed, 14 Jun 2017)

  Changed paths:
    M include/openvswitch/types.h
    M lib/unaligned.h

  Log Message:
  -----------
  unaligned: Introduce helpers for 32-bit aligned 128-bit integers.

These are analogous to the existing helpers for 32-bit aligned 64-bit
integers, and will have users in upcoming commits.

Signed-off-by: Ben Pfaff <blp at ovn.org>
Acked-by: Lance Richardson <lrichard at redhat.com>


  Commit: ab79d262e17442926f1e480984ad663b978d46d7
      https://github.com/openvswitch/ovs/commit/ab79d262e17442926f1e480984ad663b978d46d7
  Author: Ben Pfaff <blp at ovn.org>
  Date:   2017-06-14 (Wed, 14 Jun 2017)

  Changed paths:
    M lib/dpif-netlink.c
    M lib/netlink.c
    M lib/netlink.h
    M lib/odp-util.c

  Log Message:
  -----------
  netlink: Introduce helpers for 128-bit integer attributes.

Use the helpers in appropriate places.  In most cases, this fixes a
misaligned reference, since ovs_be128 and ovs_u128 require 8-byte alignment
but Netlink only guarantees 4-byte.

Found by GCC -fsanitize=undefined.

Reported-by: Lance Richardson <lrichard at redhat.com>
Signed-off-by: Ben Pfaff <blp at ovn.org>
Acked-by: Lance Richardson <lrichard at redhat.com>


  Commit: 89cf41eca75e28b85423c04f0ed7665a0f160a26
      https://github.com/openvswitch/ovs/commit/89cf41eca75e28b85423c04f0ed7665a0f160a26
  Author: Ben Pfaff <blp at ovn.org>
  Date:   2017-06-14 (Wed, 14 Jun 2017)

  Changed paths:
    M lib/odp-util.c
    M ofproto/ofproto-dpif-xlate.c

  Log Message:
  -----------
  ofproto-dpif-xlate: Fix an additional misaligned reference to ovs_u128.

nl_msg_put_unspec_uninit() can return a pointer that is only 4-byte
aligned.

Signed-off-by: Ben Pfaff <blp at ovn.org>
Acked-by: Lance Richardson <lrichard at redhat.com>


Compare: https://github.com/openvswitch/ovs/compare/8568c7a5c128...89cf41eca75e


More information about the git mailing list