[ovs-git] [openvswitch/ovs] b7c5db: datapath-windows: Fix potential memory leak while ...

GitHub noreply at github.com
Thu Jun 22 01:47:53 UTC 2017


  Branch: refs/heads/master
  Home:   https://github.com/openvswitch/ovs
  Commit: b7c5dbeecbcc2149592c59cfa0c2e26859b1ac24
      https://github.com/openvswitch/ovs/commit/b7c5dbeecbcc2149592c59cfa0c2e26859b1ac24
  Author: Sairam Venugopal <vsairam at vmware.com>
  Date:   2017-06-21 (Wed, 21 Jun 2017)

  Changed paths:
    M datapath-windows/ovsext/Conntrack.c

  Log Message:
  -----------
  datapath-windows: Fix potential memory leak while creating conntrack entry

OvsCtAddEntry returns TRUE or FALSE depending on whether
OvsNatTranslateCtEntry was successful or not. In the case of an
unsuccesful NAT translation, this will fail to insert the newly created
entry to the Conntrack Table. This entry needs to be freed and the states
should be accordingly in the flowKey instead of returning out.

Consolidated the parentEntry lookup and assignment portion across
different protocols and some minor refactoring to make the code more
readable.

Tests Done: Enabled driver verifier and tested the following:
- TCP & ICMP traffic through Conntrack Module.
- Flushed Conntrack Entries while traffic was flowing.
- Uninstalled and re-installed the driver when traffic was in progress.

Signed-off-by: Sairam Venugopal <vsairam at vmware.com>
Acked-by: Shashank Ram <rams at vmware.com>
Acked-by: Nithin Raju <nithin at vmware.com>
Signed-off-by: Gurucharan Shetty <guru at ovn.org>




More information about the git mailing list