[ovs-git] [openvswitch/ovs] fd13c6: Fix format specifier technicalities.

GitHub noreply at github.com
Fri Mar 17 20:41:59 UTC 2017


  Branch: refs/heads/master
  Home:   https://github.com/openvswitch/ovs
  Commit: fd13c6b549c5376745391390af663d8689e3ee6b
      https://github.com/openvswitch/ovs/commit/fd13c6b549c5376745391390af663d8689e3ee6b
  Author: Ben Pfaff <blp at ovn.org>
  Date:   2017-03-17 (Fri, 17 Mar 2017)

  Changed paths:
    M lib/bfd.c
    M lib/match.c
    M lib/multipath.c
    M lib/odp-util.c
    M lib/ofp-actions.c
    M lib/ofp-print.c
    M lib/ofp-util.c
    M lib/ovs-router.c
    M ofproto/ofproto-dpif-xlate.c
    M tests/test-netflow.c
    M utilities/ovs-ofctl.c
    M vswitchd/bridge.c

  Log Message:
  -----------
  Fix format specifier technicalities.

Various printf() format specifiers in the tree had minor technical issues
which the Mac OS build reported, e.g. here:
https://s3.amazonaws.com/archive.travis-ci.org/jobs/208718342/log.txt

These tend to fall into two categories of harmless warnings:

1. Wrong width for types that are all promoted to 'int'.  For example,
both uint8_t and uint16_t are both promoted to 'int' as part of a call
to printf(), but using PRIu8 for a uint16_t causes a warning.

2. Wrong format specifier for type promoted to 'int' due to arithmetic.
For example, if 'x' is a uint8_t, then x >> 1 has type 'int' due to
C's promotion rules, so the correct format specifier is %d and using
PRIu8 will cause a warning.

This commit fixes the warnings.  I didn't see anything that rose to the
level of a bug.

These warnings only showed up on Mac OS X because of differences in the
format specifiers that Mac OS uses for PRI*.

Reported-by: Shu Shen <shu.shen at gmail.com>
Acked-by: Daniele Di Proietto <diproiettod at vmware.com>
Signed-off-by: Ben Pfaff <blp at ovn.org>




More information about the git mailing list