[ovs-git] [openvswitch/ovs] 57db02: revalidator: Revalidate ukeys created from flows.

[GitHub]

  Branch: refs/heads/master
  Home:   https://github.com/openvswitch/ovs
  Commit: 57db021047fc5f88cd79a13f17c0ccd4de12bc30
      https://github.com/openvswitch/ovs/commit/57db021047fc5f88cd79a13f17c0ccd4de12bc30
  Author: Joe Stringer <joe at ovn.org>
  Date:   2017-05-02 (Tue, 02 May 2017)

  Changed paths:
    M ofproto/ofproto-dpif-upcall.c

  Log Message:
  -----------
  revalidator: Revalidate ukeys created from flows.

If there is no active ukey for a particular datapath flow, and it is
dumped from the datapath, then the revalidator threads will assemble a
ukey based on the datapath flow. This will allow tracking of the stats
for proper attribution, and future validation of the flow.

However, until now when creating the ukey in this context, the ukey's
'reval_seq' has been set to the current udpif's reval_seq. This implies
that the flow has been validated against the current flow table.
However, this is not true - The flow appeared in the datapath without
any prior knowledge in this OVS instance so we should set up the
reval_seq of the ukey to ensure that the flow will be validated during
the current dump/revalidation cycle.

Refer also revalidate_ukey().

Fixes: 23597df05226 ("upcall: Create ukeys in handler threads.")
Signed-off-by: Joe Stringer <joe at ovn.org>
Acked-by: Jarno Rajahalme <jarno at ovn.org>


  Commit: d2c09275b93f9471a36ab1dc7658cd445a152681
      https://github.com/openvswitch/ovs/commit/d2c09275b93f9471a36ab1dc7658cd445a152681
  Author: Joe Stringer <joe at ovn.org>
  Date:   2017-05-02 (Tue, 02 May 2017)

  Changed paths:
    M ofproto/ofproto-dpif-upcall.c

  Log Message:
  -----------
  revalidator: Fix logging of xlate_key() failure.

This was being logged using xlate_strerror(), but the return code is
actually an errno code. Use ovs_strerror() instead.

Fixes: dd0dc9eda0e0 ("revalidator: Reuse xlate_ukey from deletion.")
Signed-off-by: Joe Stringer <joe at ovn.org>
Acked-by: Jarno Rajahalme <jarno at ovn.org>


Compare: https://github.com/openvswitch/ovs/compare/302eda27210a...d2c09275b93f