[ovs-git] [openvswitch/ovs] 5d476f: ovn-sbctl, ovn-nbctl, ovs-vsctl: Remove useless re...

GitHub noreply at github.com
Wed May 3 15:35:55 UTC 2017


  Branch: refs/heads/master
  Home:   https://github.com/openvswitch/ovs
  Commit: 5d476f28b7c537889b671bd985a1722bf5e1850e
      https://github.com/openvswitch/ovs/commit/5d476f28b7c537889b671bd985a1722bf5e1850e
  Author: Ben Pfaff <blp at ovn.org>
  Date:   2017-05-03 (Wed, 03 May 2017)

  Changed paths:
    M ovn/utilities/ovn-nbctl.c
    M ovn/utilities/ovn-sbctl.c
    M utilities/ovs-vsctl.c

  Log Message:
  -----------
  ovn-sbctl, ovn-nbctl, ovs-vsctl: Remove useless record id methods.

These only did anything if both the first two members of the struct were
nonnull, as you can see from the first test in get_row_by_id() in
lib/db-ctl-base.c, so these never did anything useful and I can't figure
out why they're there.

Signed-off-by: Ben Pfaff <blp at ovn.org>
Acked-by: Russell Bryant <russell at ovn.org>


  Commit: a0b02897cfe33aa2c40620707f2e42cf716abf72
      https://github.com/openvswitch/ovs/commit/a0b02897cfe33aa2c40620707f2e42cf716abf72
  Author: Ben Pfaff <blp at ovn.org>
  Date:   2017-05-03 (Wed, 03 May 2017)

  Changed paths:
    M lib/db-ctl-base.c
    M lib/db-ctl-base.h
    M lib/ovsdb-idl.c
    M lib/ovsdb-idl.h
    M ovn/utilities/ovn-nbctl.c
    M ovn/utilities/ovn-sbctl.c
    M utilities/ovs-vsctl.c
    M vtep/vtep-ctl.c

  Log Message:
  -----------
  db-ctl-base: Drop redundant 'table' field from struct ctl_row_id.

The 'table' field is redundant because the required 'column' field
implies the table that the column is a part of.

This simplifies the users and makes it harder to get these things wrong.

Signed-off-by: Ben Pfaff <blp at ovn.org>
Acked-by: Andy Zhou <azhou at ovn.org>


  Commit: 15931827ee9198edf84861c0e30f6d20cd04fd83
      https://github.com/openvswitch/ovs/commit/15931827ee9198edf84861c0e30f6d20cd04fd83
  Author: Ben Pfaff <blp at ovn.org>
  Date:   2017-05-03 (Wed, 03 May 2017)

  Changed paths:
    M lib/db-ctl-base.c
    M lib/db-ctl-base.h
    M ovn/utilities/ovn-nbctl.c
    M ovn/utilities/ovn-sbctl.c
    M utilities/ovs-vsctl.c
    M vtep/vtep-ctl.c

  Log Message:
  -----------
  db-ctl-base: Add support for identifying a row based on a value in a map.

This will be used in an upcoming commit to allow Datapath_Binding records
in the OVN southbound database to be identified based on external-ids:name
and other map values.

Signed-off-by: Ben Pfaff <blp at ovn.org>
Acked-by: Andy Zhou <azhou at ovn.org>


  Commit: 2cbe396339e6b76254283bd2d32f94db79132f04
      https://github.com/openvswitch/ovs/commit/2cbe396339e6b76254283bd2d32f94db79132f04
  Author: Ben Pfaff <blp at ovn.org>
  Date:   2017-05-03 (Wed, 03 May 2017)

  Changed paths:
    M lib/db-ctl-base.c

  Log Message:
  -----------
  db-ctl-base: Allow abbreviating UUIDs embedded in strings.

This allows commands like "ovn-sbctl lflow-list abcdef" to find a
datapath that has external-ids:logical-switch=abcdef12-3456-...

Signed-off-by: Ben Pfaff <blp at ovn.org>
Acked-by: Andy Zhou <azhou at ovn.org>


  Commit: 6ad44e82bf90bce8ef6dc1fa160d79082a3dd1c2
      https://github.com/openvswitch/ovs/commit/6ad44e82bf90bce8ef6dc1fa160d79082a3dd1c2
  Author: Ben Pfaff <blp at ovn.org>
  Date:   2017-05-03 (Wed, 03 May 2017)

  Changed paths:
    M ovn/utilities/ovn-nbctl.c

  Log Message:
  -----------
  ovn-nbctl: Include logical switch port type in "show" output.

The port type is important to the user, at least when it is a nonempty
string, so this adds it to the "ovn-nbctl show" output.

Signed-off-by: Ben Pfaff <blp at ovn.org>
Acked-by: Andy Zhou <azhou at ovn.org>


  Commit: f17c3504ce5659370b941942de07164d8cf64cad
      https://github.com/openvswitch/ovs/commit/f17c3504ce5659370b941942de07164d8cf64cad
  Author: Ben Pfaff <blp at ovn.org>
  Date:   2017-05-03 (Wed, 03 May 2017)

  Changed paths:
    M ovn/utilities/ovn-nbctl.c

  Log Message:
  -----------
  ovn-nbctl: Display logical switch router ports in "show".

This allows the reader to figure out from "ovn-nbctl show" output where the
ports of type "router" connect.

Signed-off-by: Ben Pfaff <blp at ovn.org>
Acked-by: Andy Zhou <azhou at ovn.org>


  Commit: 0abaab9174b65af184568c672d97d9094b3d5b5d
      https://github.com/openvswitch/ovs/commit/0abaab9174b65af184568c672d97d9094b3d5b5d
  Author: Ben Pfaff <blp at ovn.org>
  Date:   2017-05-03 (Wed, 03 May 2017)

  Changed paths:
    M ovn/utilities/ovn-nbctl.c

  Log Message:
  -----------
  ovn-nbctl: Omit "addresses: ["router"]" from "show" output.

Signed-off-by: Ben Pfaff <blp at ovn.org>
Acked-by: Andy Zhou <azhou at ovn.org>


  Commit: 012c446223ee06cb55b42b33c8c58cf3b5a1e414
      https://github.com/openvswitch/ovs/commit/012c446223ee06cb55b42b33c8c58cf3b5a1e414
  Author: Ben Pfaff <blp at ovn.org>
  Date:   2017-05-03 (Wed, 03 May 2017)

  Changed paths:
    M ovn/ovn-nb.xml
    M ovn/utilities/ovn-nbctl.c

  Log Message:
  -----------
  ovn-nbctl: Display and accept Neutron network, router, port names.

The names of these neutron:* keys in external_ids are unfortunate, but
they are the keys that the OVN utilities need to support if we want users
to be able to work with OpenStack in a convenient fashion rather than
having to cut and paste UUIDs everywhere.

This commit documents the meaning of these keys, in the hopes that other
CMS integrations will simply use them instead of inventing new ones.
Perhaps at some point we can clean this up, since bad names are a bad idea,
but it also would take a lot of coordination and probably multiple
releases.

Port names are slightly less useful in practice than switch or router names
because Neutron doesn't by default give names to ports.  (You can add them
with "openstack port set --name", though.)

Signed-off-by: Ben Pfaff <blp at ovn.org>
Acked-by: Andy Zhou <azhou at ovn.org>


  Commit: d81af5eb38e81f423127a6e841cf09104575d51b
      https://github.com/openvswitch/ovs/commit/d81af5eb38e81f423127a6e841cf09104575d51b
  Author: Ben Pfaff <blp at ovn.org>
  Date:   2017-05-03 (Wed, 03 May 2017)

  Changed paths:
    M lib/db-ctl-base.h
    M ovn/utilities/ovn-nbctl.c

  Log Message:
  -----------
  ovn-nbctl: Allow access to DHCP options via logical switch port name.

After this, if port "myvif" has DHCPv4 or DHCPv6 options, you can use
"ovn-nbctl list dhcp myvif" to see them.

Signed-off-by: Ben Pfaff <blp at ovn.org>
Acked-by: Andy Zhou <azhou at ovn.org>


Compare: https://github.com/openvswitch/ovs/compare/7a16f569afa9...d81af5eb38e8


More information about the git mailing list