[ovs-git] [openvswitch/ovs] 16c2b4: netdev-dpdk: fix mempool_configure error state

GitHub noreply at github.com
Wed May 3 19:32:37 UTC 2017


  Branch: refs/heads/branch-2.7
  Home:   https://github.com/openvswitch/ovs
  Commit: 16c2b46b4afd1321e198b7d7bdfeed311f69c492
      https://github.com/openvswitch/ovs/commit/16c2b46b4afd1321e198b7d7bdfeed311f69c492
  Author: Mark Kavanagh <mark.b.kavanagh at intel.com>
  Date:   2017-05-03 (Wed, 03 May 2017)

  Changed paths:
    M lib/netdev-dpdk.c

  Log Message:
  -----------
  netdev-dpdk: fix mempool_configure error state

netdev_dpdk_mempool_configure obtains a handle to a
DPDK memory pool via a call to dpdk_mp_get. If dpdk_mp_get
fails, the former informs the user that insufficient memory
is available, and  returns ENOMEM. However, this is
potentially misleading, as there are a number of reasons why
creation of a mempool can fail (as per rte_mempool_create),
including:
   - insufficient memory available
   - mempool already exists
   - other memory allocation error

Update the error log to reflect this fact, and return rte_errno
in the event of error, instead of ENOMEM.

Signed-off-by: Mark Kavanagh <mark.b.kavanagh at intel.com>
Fixes: 0072e931 ("netdev-dpdk: add support for jumbo frames")
Signed-off-by: Ben Pfaff <blp at ovn.org>
Acked-by: Ian Stokes <ian.stokes at intel.com>
Acked-by: Darrell Ball <dlu998 at gmail.com>




More information about the git mailing list