[ovs-git] [openvswitch/ovs] 9c4636: ovs-atomic: Report error for contradictory configu...

GitHub noreply at github.com
Wed May 3 21:57:22 UTC 2017


  Branch: refs/heads/master
  Home:   https://github.com/openvswitch/ovs
  Commit: 9c463631e81456dd6b280a19a2e250e4ed3c1b29
      https://github.com/openvswitch/ovs/commit/9c463631e81456dd6b280a19a2e250e4ed3c1b29
  Author: Ben Pfaff <blp at ovn.org>
  Date:   2017-05-03 (Wed, 03 May 2017)

  Changed paths:
    M lib/ovs-atomic.h

  Log Message:
  -----------
  ovs-atomic: Report error for contradictory configuration.

A user reported that GCC 5.x was using the atomic fallback for GCC 4.x
because the test
     #elif __GNUC__ >= 4 && __GNUC_MINOR__ >= 7
didn't include GCC 5.  However, GCC 5+ has <stdatomic.h> and shouldn't use
any of the GCC-specific cases at all.  I think that this user was actually
pulling our atomics out into third-party code that probably didn't define
HAVE_STDATOMIC_H properly, so this commit both avoids that problem for
them in the future and clarifies the intent of the ovs-atomic header.

Signed-off-by: Ben Pfaff <blp at ovn.org>
Acked-by: Joe Stringer <joe at ovn.org>




More information about the git mailing list