[ovs-git] [openvswitch/ovs] c42b00: datapath: backport: vxlan: do not output confusing...

[GitHub]

  Branch: refs/heads/branch-2.6
  Home:   https://github.com/openvswitch/ovs
  Commit: c42b00453b976b93f4cd458e85e8157750a7c2e2
      https://github.com/openvswitch/ovs/commit/c42b00453b976b93f4cd458e85e8157750a7c2e2
  Author: Jiri Benc <jbenc at redhat.com>
  Date:   2017-05-04 (Thu, 04 May 2017)

  Changed paths:
    M datapath/linux/compat/vxlan.c

  Log Message:
  -----------
  datapath: backport: vxlan: do not output confusing error message

Upstream commit:
    commit baf4d7860771287f30fbe9b6b2dc18b04361439d
    Author: Jiri Benc <jbenc at redhat.com>
    Date:   Thu Apr 27 21:24:36 2017 +0200

    vxlan: do not output confusing error message

    The message "Cannot bind port X, err=Y" creates only confusion. In metadata
    based mode, failure of IPv6 socket creation is okay if IPv6 is disabled and
    no error message should be printed. But when IPv6 tunnel was requested, such
    failure is fatal. The vxlan_socket_create does not know when the error is
    harmless and when it's not.

    Instead of passing such information down to vxlan_socket_create, remove the
    message completely. It's not useful. We propagate the error code up to the
    user space and the port number comes from the user space. There's nothing in
    the message that the process creating vxlan interface does not know.

    Signed-off-by: Jiri Benc <jbenc at redhat.com>
    Signed-off-by: David S. Miller <davem at davemloft.net>

Signed-off-by: Pravin B Shelar <pshelar at ovn.org>
Acked-by: Joe Stringer <joe at ovn.org>