[ovs-git] [openvswitch/ovs] f5f645: Revert "tunneling: Avoid recirculation on datapath...

[GitHub]

  Branch: refs/heads/master
  Home:   https://github.com/openvswitch/ovs
  Commit: f5f64552ec22f4c7452fdb554d52e73055b51cca
      https://github.com/openvswitch/ovs/commit/f5f64552ec22f4c7452fdb554d52e73055b51cca
  Author: Joe Stringer <joe at ovn.org>
  Date:   2017-05-10 (Wed, 10 May 2017)

  Changed paths:
    M lib/dpif-netdev.c
    M ofproto/ofproto-dpif-xlate.c
    M tests/ofproto-dpif.at
    M tests/ovn.at
    M tests/tunnel-push-pop-ipv6.at
    M tests/tunnel-push-pop.at

  Log Message:
  -----------
  Revert "tunneling: Avoid recirculation on datapath."

This reverts commit f1dac5128ce6db2e493f0d1c7a8b53fb9f34476f. When this
commit was introduced, it broke the 'make check-system-userspace'
testsuite. It appears that the new translation fails to modify the flow
in a way that would represent the flow as an encapsulated flow when the
traffic is patched through to the second bridge. As such, rather than
matching on, for example, "ip,proto=47" for gre, it would use the inner
packet's flow headers. It also results in problems reporting statistics,
as the tunnel's header is not reflected in subsequent statistics and
truncation is not properly applied during translation.

While a refreshed approach to solving the above problem is formed,
revert this patch.

Reported-at: https://mail.openvswitch.org/pipermail/ovs-dev/2017-May/331972.html
Signed-off-by: Joe Stringer <joe at ovn.org>
Acked-by: Greg Rose <gvrose8192 at gmail.com>