[ovs-git] [openvswitch/ovs] 56f9a5: ovn-northd: Fix uninitialized reference in build_s...

GitHub noreply at github.com
Tue May 30 14:49:08 UTC 2017


  Branch: refs/heads/master
  Home:   https://github.com/openvswitch/ovs
  Commit: 56f9a57a103ee862a62ad2f254e3bdf48b5162e6
      https://github.com/openvswitch/ovs/commit/56f9a57a103ee862a62ad2f254e3bdf48b5162e6
  Author: Ben Pfaff <blp at ovn.org>
  Date:   2017-05-30 (Tue, 30 May 2017)

  Changed paths:
    M ovn/northd/ovn-northd.c

  Log Message:
  -----------
  ovn-northd: Fix uninitialized reference in build_static_route_flow().

It was apparently possible for lrp_addr_s to be uninitialized in a logical
router with no ports.

Found by Coverity.

Reported-at: https://scan3.coverity.com/reports.htm#v16889/p10449/fileInstanceId=14763080&defectInstanceId=4304818&mergedDefectId=180426
Signed-off-by: Ben Pfaff <blp at ovn.org>
Acked-by: Miguel Angel Ajo <majopela at redhat.com>


  Commit: 8abe89de9779c35f44d304bb28432e34ec7c3b85
      https://github.com/openvswitch/ovs/commit/8abe89de9779c35f44d304bb28432e34ec7c3b85
  Author: Ben Pfaff <blp at ovn.org>
  Date:   2017-05-30 (Tue, 30 May 2017)

  Changed paths:
    M ovn/controller/ovn-controller.c

  Log Message:
  -----------
  ovn-controller: Fix memory leak in create_br_int().

Found by Coverity.

Reported-at: https://scan3.coverity.com/reports.htm#v16889/p10449/fileInstanceId=14763066&defectInstanceId=4305324&mergedDefectId=180404&fileStart=251&fileEnd=500
Signed-off-by: Ben Pfaff <blp at ovn.org>
Acked-by: Miguel Angel Ajo <majopela at redhat.com>


  Commit: 6851589c0c129ae21f97f1e44c09b15e28efd851
      https://github.com/openvswitch/ovs/commit/6851589c0c129ae21f97f1e44c09b15e28efd851
  Author: Ben Pfaff <blp at ovn.org>
  Date:   2017-05-30 (Tue, 30 May 2017)

  Changed paths:
    M ovn/utilities/ovn-nbctl.c
    M ovn/utilities/ovn-sbctl.c
    M utilities/ovs-vsctl.c

  Log Message:
  -----------
  ovn-nbctl, ovn-sbctl, ovs-vsctl: Remove gratuitous NULL checks.

These functions all set txn and do not un-set it within their main
command execution function, so it's gratuitous to check it along this path.

Found by Coverity.

Reported-at: https://scan3.coverity.com/reports.htm#v16889/p10449/fileInstanceId=14763082&defectInstanceId=4305338&mergedDefectId=180417
Signed-off-by: Ben Pfaff <blp at ovn.org>
Acked-by: Miguel Angel Ajo <majopela at redhat.com>


Compare: https://github.com/openvswitch/ovs/compare/9bd881f77861...6851589c0c12


More information about the git mailing list