[ovs-git] [openvswitch/ovs] 962858: ovn: Fix encoding of large logical output ports fo...

[GitHub]

  Branch: refs/heads/branch-2.7
  Home:   https://github.com/openvswitch/ovs
  Commit: 9628585490bbe8a6cf5aa849924ca1a55311cc3e
      https://github.com/openvswitch/ovs/commit/9628585490bbe8a6cf5aa849924ca1a55311cc3e
  Author: Ben Pfaff <blp at ovn.org>
  Date:   2017-05-30 (Tue, 30 May 2017)

  Changed paths:
    M ovn/controller/physical.c

  Log Message:
  -----------
  ovn: Fix encoding of large logical output ports for STT.

put_encapsulation() is meant to load the logical output port into bits
24 to 40 of the tunnel ID metadata field, but 'outport << 24' did not
have that effect because outport has type uint16_t.  This fixes the
problem.

This would only affect ports numbered 256 and higher, and only with STT.
(However, multicast groups are always numbered higher than 256, so I guess
that flooding didn't work.)

Found by Coverity.

Reported-at: https://scan3.coverity.com/reports.htm#v16889/p10449/fileInstanceId=14763078&defectInstanceId=4304791&mergedDefectId=180391
Signed-off-by: Ben Pfaff <blp at ovn.org>
Acked-by: Miguel Angel Ajo <majopela at redhat.com>
Signed-off-by: Ben Pfaff <blp at ovn.org>