[ovs-git] [openvswitch/ovs] 1ca6d1: physical: Tolerate missing distributed-port key fo...

GitHub noreply at github.com
Wed May 31 18:46:21 UTC 2017


  Branch: refs/heads/master
  Home:   https://github.com/openvswitch/ovs
  Commit: 1ca6d1ddce0070938af67a892fc32bbc94e4171d
      https://github.com/openvswitch/ovs/commit/1ca6d1ddce0070938af67a892fc32bbc94e4171d
  Author: Ben Pfaff <blp at ovn.org>
  Date:   2017-05-31 (Wed, 31 May 2017)

  Changed paths:
    M ovn/controller/physical.c

  Log Message:
  -----------
  physical: Tolerate missing distributed-port key for chassisredirect ports.

Until now, the code here assumed that a "distributed-port" key existed,
and dereferenced a null pointer if it did not.  This commit avoids that
problem.

Found by Coverity.

Reported-at: https://scan3.coverity.com/reports.htm#v16889/p10449/fileInstanceId=14763078&defectInstanceId=4305288&mergedDefectId=179857
Signed-off-by: Ben Pfaff <blp at ovn.org>
Acked-by: Aaron Conole <aconole at redhat.com>


  Commit: 964e01d1d07627e82e822eae3839a587035183bc
      https://github.com/openvswitch/ovs/commit/964e01d1d07627e82e822eae3839a587035183bc
  Author: Ben Pfaff <blp at ovn.org>
  Date:   2017-05-31 (Wed, 31 May 2017)

  Changed paths:
    M lib/meta-flow.c

  Log Message:
  -----------
  meta-flow: Remove dead condition in mf_set().

mf_set() always takes a nonnull mask, but the MFF_CT_LABEL case checked
whether it was nonnull.

Found by Coverity.

Reported-at: https://scan3.coverity.com/reports.htm#v16889/p10449/fileInstanceId=14762941&defectInstanceId=4304057&mergedDefectId=179568
Signed-off-by: Ben Pfaff <blp at ovn.org>
Acked-by: Aaron Conole <aconole at redhat.com>


Compare: https://github.com/openvswitch/ovs/compare/2b03ef9540ef...964e01d1d076


More information about the git mailing list