[ovs-git] [openvswitch/ovs] 428457: ovn-controller: Fix log conditions for unexpected ...

[GitHub]

  Branch: refs/heads/master
  Home:   https://github.com/openvswitch/ovs
  Commit: 42845746a4d3ac68048ae9dd82b1b8595eb501b8
      https://github.com/openvswitch/ovs/commit/42845746a4d3ac68048ae9dd82b1b8595eb501b8
  Author: Han Zhou <zhouhan at gmail.com>
  Date:   2017-05-31 (Wed, 31 May 2017)

  Changed paths:
    M ovn/controller/ofctrl.c
    M ovn/controller/pinctrl.c

  Log Message:
  -----------
  ovn-controller: Fix log conditions for unexpected openflow messages.

Currently in pinctrl.c and ofctrl.c there are similar logic to log
ignored messages, which is somehow inaccurate and confusing. For example,
OFPTYPE_PACKET_IN is handled only in pinctrl.c but in ofctrl.c it
is listed as expected input and not logged as "ignored" messages, while
it is in fact unexpected and ignored there. This patch clearup the
unnecessary "if" conditions and logs all messages that are not
expected/handled honestly, so that there will be logs for debugging
if such abnormal case really happens.

Signed-off-by: Han Zhou <zhouhan at gmail.com>
Signed-off-by: Ben Pfaff <blp at ovn.org>