[ovs-git] [openvswitch/ovs] 7b997d: OVN: Don't let peers be set to "<error>" on port b...

[GitHub]

  Branch: refs/heads/master
  Home:   https://github.com/openvswitch/ovs
  Commit: 7b997d4f3d9996773537476d31a0643f96ed15c9
      https://github.com/openvswitch/ovs/commit/7b997d4f3d9996773537476d31a0643f96ed15c9
  Author: Mark Michelson <mmichels at redhat.com>
  Date:   2017-11-01 (Wed, 01 Nov 2017)

  Changed paths:
    M ovn/northd/ovn-northd.c

  Log Message:
  -----------
  OVN: Don't let peers be set to "<error>" on port bindings.

There are a couple of places in ovn-northd that set the "peer" option on
certain ports to "<error>" in certain cases. In every case where a peer is
looked up on a port binding, the code performs a NULL check in order to
ensure a peer exists. None check for the "<error>" string. They assume that the
presence of a peer string means a peer is defined and all is well.

In the past (OVS 2.6 series), this sometimes led to patch ports being created
in ovs that had names like "patch-ro-to-<error>". This particular problem
resolved itself in OVS 2.7 since such patch ports were no longer automatically
created. However, by naming the peer "<error>" the seeds are still sown for
similar issues to occur.

The solution this patch suggests is to no longer set the "peer" option
on a port binding to "<error>". Instead, if no peer can be set, then we
set no peer. Since other code is already equipped to deal with this,
this poses no problem.

Signed-off-by: Mark Michelson <mmichels at redhat.com>
Signed-off-by: Ben Pfaff <blp at ovn.org>