[ovs-git] [openvswitch/ovs] a1d6cc: ofproto-dpif-upcall: Transition ukey on dp_ops err...

[GitHub]

  Branch: refs/heads/master
  Home:   https://github.com/openvswitch/ovs
  Commit: a1d6cce780d82fe7d2a1e394e127bd3335e247eb
      https://github.com/openvswitch/ovs/commit/a1d6cce780d82fe7d2a1e394e127bd3335e247eb
  Author: Joe Stringer <joe at ovn.org>
  Date:   2017-11-02 (Thu, 02 Nov 2017)

  Changed paths:
    M ofproto/ofproto-dpif-upcall.c

  Log Message:
  -----------
  ofproto-dpif-upcall: Transition ukey on dp_ops error.

In most situations, we don't expect that a flow we've successfully
dumped, which we intend to delete, cannot be deleted. However, to make
this code more resilient to ensure that ukeys *will* transition in all
cases (including an error at this stage), grab the lock and transition
this ukey forward to the evicted state, effectively treating a failure
to delete as "this flow is already gone".

If we subsequently find out that it wasn't deleted, then that's ok - we
will re-dump, and validate at that stage, which should lead to creating
a new ukey or deleting the datapath flow when that happens.

Signed-off-by: Joe Stringer <joe at ovn.org>
Signed-off-by: Ben Pfaff <blp at ovn.org>
Reviewed-by: Greg Rose <gvrose8192 at gmail.com>