[ovs-git] [openvswitch/ovs] cba5d1: datapath-windows: Use only non executable memory

[GitHub]

  Branch: refs/heads/master
  Home:   https://github.com/openvswitch/ovs
  Commit: cba5d1489bf89ff81472986b18b9b13c5b5f8748
      https://github.com/openvswitch/ovs/commit/cba5d1489bf89ff81472986b18b9b13c5b5f8748
  Author: Alin Serdean <aserdean at cloudbasesolutions.com>
  Date:   2017-11-29 (Wed, 29 Nov 2017)

  Changed paths:
    M datapath-windows/ovsext/BufferMgmt.c
    M datapath-windows/ovsext/Datapath.c
    M datapath-windows/ovsext/Flow.c
    M datapath-windows/ovsext/Geneve.c
    M datapath-windows/ovsext/Gre.c
    M datapath-windows/ovsext/Offload.c
    M datapath-windows/ovsext/PacketParser.c
    M datapath-windows/ovsext/Stt.c
    M datapath-windows/ovsext/Util.h
    M datapath-windows/ovsext/Vxlan.c

  Log Message:
  -----------
  datapath-windows: Use only non executable memory

Use only non-executable memory when using MmGetSystemAddressForMdlSafe.

Introduce a new function called OvsGetMdlWithLowPriority for readability.

Found using WDK 10 static code analysis.

Signed-off-by: Alin Gabriel Serdean <aserdean at cloudbasesolutions.com>
Acked-by: Shashank Ram <shashank08 at gmail.com>


  Commit: d3beb55e7f27c93439491fbf489118a8fde77237
      https://github.com/openvswitch/ovs/commit/d3beb55e7f27c93439491fbf489118a8fde77237
  Author: Alin Serdean <aserdean at cloudbasesolutions.com>
  Date:   2017-11-29 (Wed, 29 Nov 2017)

  Changed paths:
    M datapath-windows/ovsext/IpHelper.c

  Log Message:
  -----------
  datapath-windows: prettify logging in iphelper

Found by inspection.

Signed-off-by: Alin Gabriel Serdean <aserdean at cloudbasesolutions.com>
Acked-by: Shashank Ram <shashank08 at gmail.com>


  Commit: 960b789f59690c9d59f20473962c61a0f8b38176
      https://github.com/openvswitch/ovs/commit/960b789f59690c9d59f20473962c61a0f8b38176
  Author: Alin Serdean <aserdean at cloudbasesolutions.com>
  Date:   2017-11-29 (Wed, 29 Nov 2017)

  Changed paths:
    M datapath-windows/ovsext/Vport.c

  Log Message:
  -----------
  datapath-windows: Vport check RtlStringCbLengthW return value

The result of `RtlStringCbLengthW` is not currently checked and triggers
a warning using the WDK 8.1 static analysis.

This patch treats the result of `RtlStringCbLengthW`.

Signed-off-by: Alin Gabriel Serdean <aserdean at cloudbasesolutions.com>
Acked-by: Shashank Ram <shashank08 at gmail.com>


  Commit: c249e3e4817695e7b0f85644fa67b7f72667e988
      https://github.com/openvswitch/ovs/commit/c249e3e4817695e7b0f85644fa67b7f72667e988
  Author: Alin Serdean <aserdean at cloudbasesolutions.com>
  Date:   2017-11-29 (Wed, 29 Nov 2017)

  Changed paths:
    M datapath-windows/ovsext/Actions.c

  Log Message:
  -----------
  datapath-windows: Add assert to ethHdr in OvsActionMplsPush

`ethHdr` cannot be NULL because we did a partial copy before it.

Add an assert to keep the static analysis happy.

Signed-off-by: Alin Gabriel Serdean <aserdean at cloudbasesolutions.com>
Acked-by: Shashank Ram <shashank08 at gmail.com>


  Commit: 263e428e152d56eba2d04e6429dfcb8477146f9c
      https://github.com/openvswitch/ovs/commit/263e428e152d56eba2d04e6429dfcb8477146f9c
  Author: Alin Serdean <aserdean at cloudbasesolutions.com>
  Date:   2017-11-29 (Wed, 29 Nov 2017)

  Changed paths:
    M datapath-windows/ovsext/Conntrack.h

  Log Message:
  -----------
  datapath-windows: Fix static analysis warnings in OvsGetTcpPayloadLength

This fixes the static code analysis over the function
'OvsGetTcpPayloadLength'.

Signed-off-by: Alin Gabriel Serdean <aserdean at cloudbasesolutions.com>
Acked-by: Shashank Ram <shashank08 at gmail.com>


  Commit: 7d20979a88b37c580346d278663cde0d4c78dae9
      https://github.com/openvswitch/ovs/commit/7d20979a88b37c580346d278663cde0d4c78dae9
  Author: Alin Serdean <aserdean at cloudbasesolutions.com>
  Date:   2017-11-29 (Wed, 29 Nov 2017)

  Changed paths:
    M datapath-windows/ovsext/IpHelper.c

  Log Message:
  -----------
  datapath-windows: Fix static analysis warnings around ovsInstanceListLock

Check for return value when trying to initialize ovsInstanceListLock.

Also return the status back to caller of `OvsInitIpHelper`.

Signed-off-by: Alin Gabriel Serdean <aserdean at cloudbasesolutions.com>
Acked-by: Shashank Ram <shashank08 at gmail.com>


  Commit: bf7e459bf4d216678d2e68a607141eb62f5649af
      https://github.com/openvswitch/ovs/commit/bf7e459bf4d216678d2e68a607141eb62f5649af
  Author: Alin Serdean <aserdean at cloudbasesolutions.com>
  Date:   2017-11-29 (Wed, 29 Nov 2017)

  Changed paths:
    M datapath-windows/ovsext/IpFragment.c

  Log Message:
  -----------
  datapath-windows: Fix possible NULL dereference in IpFragment

If we can't allocate the NBL just go to the cleanup sequence.

Found using WDK 10 static code analysis.

Signed-off-by: Alin Gabriel Serdean <aserdean at cloudbasesolutions.com>
Acked-by: Shashank Ram <shashank08 at gmail.com>


Compare: https://github.com/openvswitch/ovs/compare/c8025aee4fa6...bf7e459bf4d2