[ovs-git] [openvswitch/ovs] 177c31: netdev: netdev_get_etheraddr is not functioning as...

[GitHub]

  Branch: refs/heads/branch-2.8
  Home:   https://github.com/openvswitch/ovs
  Commit: 177c31a7ce611c7b99d361fde219445ac00529e9
      https://github.com/openvswitch/ovs/commit/177c31a7ce611c7b99d361fde219445ac00529e9
  Author: Yifeng Sun <pkusunyifeng at gmail.com>
  Date:   2017-11-30 (Thu, 30 Nov 2017)

  Changed paths:
    M lib/netdev.c

  Log Message:
  -----------
  netdev: netdev_get_etheraddr is not functioning as advertised.

netdev_get_etheraddr claims to clear 'mac' on error, but it fails to do so.
When looking further into both netdev_windows_get_etheraddr() and
netdev_linux_get_etheraddr(), 'mac' is also not cleared. This will lead to
usage of uninitialised ofputil_phy_port.hw_addr.

v1 -> v2: fixed a bug in v1 found by Ben, thanks Ben.

Signed-off-by: Yifeng Sun <pkusunyifeng at gmail.com>
Signed-off-by: Ben Pfaff <blp at ovn.org>