[ovs-git] [openvswitch/ovs] 966574: vswitchd: Allow user to directly specify sFlow age...

[GitHub]

  Branch: refs/heads/master
  Home:   https://github.com/openvswitch/ovs
  Commit: 966574598a3cb86a6d799ca3715005763a7c9186
      https://github.com/openvswitch/ovs/commit/966574598a3cb86a6d799ca3715005763a7c9186
  Author: Ben Pfaff <blp at ovn.org>
  Date:   2018-04-03 (Tue, 03 Apr 2018)

  Changed paths:
    M ofproto/ofproto-dpif-sflow.c
    M tests/ofproto-dpif.at
    M vswitchd/vswitch.xml

  Log Message:
  -----------
  vswitchd: Allow user to directly specify sFlow agent address.

At least for testing purposes, and perhaps in production, it is useful to
be able to fix the agent IP address directly, rather that indirecting it
through a device name or the routing table.

This commit uses this feature to fix the agent IP address used in the unit
tests.  This will be particularly useful in an upcoming commit that
disables the use of the system routing table in the unit tests, to make
the tests' results independent of the host's routes.

CC: Neil McKee <neil.mckee at inmon.com>
Tested-By: Timothy Redaelli <tredaelli at redhat.com>
Signed-off-by: Ben Pfaff <blp at ovn.org>


  Commit: 898d7b0524c00cdf1cc7af85aade858bceb997e1
      https://github.com/openvswitch/ovs/commit/898d7b0524c00cdf1cc7af85aade858bceb997e1
  Author: Ben Pfaff <blp at ovn.org>
  Date:   2018-04-03 (Tue, 03 Apr 2018)

  Changed paths:
    M lib/ovs-router.c
    M lib/ovs-router.h
    M vswitchd/ovs-vswitchd.c

  Log Message:
  -----------
  ovs-vswitchd: Do not use system routing table with --disable-system.

The --disable-system option indicates that the user wants to avoid using
the host's datapath.  This is also a good indication that the user does
not want to use other host resources such as the routing table, so this
commit implements that.

This fixes a failure in the test "ptap - recirculate after packet_type
change" when the host routing table contained an entry that affected the
generated flow.  Without this patch, the commands:

led to a failure in that test.

Reported-by: Timothy Redaelli <tredaelli at redhat.com>
Reported-at: https://mail.openvswitch.org/pipermail/ovs-discuss/2018-March/046406.html
Tested-By: Timothy Redaelli <tredaelli at redhat.com>
Signed-off-by: Ben Pfaff <blp at ovn.org>


Compare: https://github.com/openvswitch/ovs/compare/baee3741fcd3...898d7b0524c0