[ovs-git] [openvswitch/ovs] 8f0e86: ofproto-dpif: Init ukey->dump_seq to zero
noreply at github.com
Wed Apr 4 20:27:29 UTC 2018
Author: Jan Scheurich <jan.scheurich at ericsson.com>
Date: 2018-04-04 (Wed, 04 Apr 2018)
ofproto-dpif: Init ukey->dump_seq to zero
In the current implementation the dump_seq of a new datapath flow ukey
is set to seq_read(udpif->dump_seq). This implies that any revalidation
during the current dump_seq period (up to 500 ms) is skipped.
This can trigger incorrect behavior, for example when the the creation of
datapath flow triggers a PACKET_IN to the controller, which which course
the controller installs a new flow entry that should invalidate the
original datapath flow.
Initializing ukey->dump_seq to zero implies that the first dump of the
flow, be it for revalidation or dumping statistics, will always be
executed as zero is not a valid value of the ovs_seq.
Signed-off-by: Jan Scheurich <jan.scheurich at ericsson.com>
Signed-off-by: Ben Pfaff <blp at ovn.org>
More information about the git