[ovs-git] [openvswitch/ovs] 561814: ofproto-dpif: Init ukey->dump_seq to zero

GitHub noreply at github.com
Mon Apr 16 21:47:32 UTC 2018


  Branch: refs/heads/branch-2.8
  Home:   https://github.com/openvswitch/ovs
  Commit: 56181405704090ddea988e1cf0ffa682d530106d
      https://github.com/openvswitch/ovs/commit/56181405704090ddea988e1cf0ffa682d530106d
  Author: Jan Scheurich <jan.scheurich at ericsson.com>
  Date:   2018-04-16 (Mon, 16 Apr 2018)

  Changed paths:
    M ofproto/ofproto-dpif-upcall.c

  Log Message:
  -----------
  ofproto-dpif: Init ukey->dump_seq to zero

In the current implementation the dump_seq of a new datapath flow ukey
is set to seq_read(udpif->dump_seq). This implies that any revalidation
during the current dump_seq period (up to 500 ms) is skipped.

This can trigger incorrect behavior, for example when the the creation of
datapath flow triggers a PACKET_IN to the controller, which which course
the controller installs a new flow entry that should invalidate the
original datapath flow.

Initializing ukey->dump_seq to zero implies that the first dump of the
flow, be it for revalidation or dumping statistics, will always be
executed as zero is not a valid value of the ovs_seq.

Signed-off-by: Jan Scheurich <jan.scheurich at ericsson.com>
Signed-off-by: Ben Pfaff <blp at ovn.org>




More information about the git mailing list