[ovs-git] [openvswitch/ovs] e1894b: socket-util: Fix error in comment on ss_format_add...

GitHub noreply at github.com
Tue Apr 17 15:04:53 UTC 2018


  Branch: refs/heads/master
  Home:   https://github.com/openvswitch/ovs
  Commit: e1894be7818a04358620a71f20f239cc4cae3da8
      https://github.com/openvswitch/ovs/commit/e1894be7818a04358620a71f20f239cc4cae3da8
  Author: Ben Pfaff <blp at ovn.org>
  Date:   2018-04-16 (Mon, 16 Apr 2018)

  Changed paths:
    M lib/socket-util.c

  Log Message:
  -----------
  socket-util: Fix error in comment on ss_format_address().

The output for this function is a dynamic string and doesn't have a
fixed buffer size, so the comment was wrong.

Signed-off-by: Ben Pfaff <blp at ovn.org>
Acked-by: Mark Michelson <mmichels at redhat.com>


  Commit: b1b8f0cbfa105f2df2528b106658ef1d6c6a1666
      https://github.com/openvswitch/ovs/commit/b1b8f0cbfa105f2df2528b106658ef1d6c6a1666
  Author: Ben Pfaff <blp at ovn.org>
  Date:   2018-04-16 (Mon, 16 Apr 2018)

  Changed paths:
    M lib/socket-util.c

  Log Message:
  -----------
  socket-util: Make address parser check for trailing garbage.

Signed-off-by: Ben Pfaff <blp at ovn.org>
Acked-by: Mark Michelson <mmichels at redhat.com>


  Commit: 51b8505b66d4d570804305ea5874a6db44cf53ba
      https://github.com/openvswitch/ovs/commit/51b8505b66d4d570804305ea5874a6db44cf53ba
  Author: Ben Pfaff <blp at ovn.org>
  Date:   2018-04-16 (Mon, 16 Apr 2018)

  Changed paths:
    M lib/socket-util.c
    M lib/socket-util.h
    M ovn/northd/ovn-northd.c

  Log Message:
  -----------
  ovn-northd: Use common code for sockaddr_storage.

This better reuses existing code.  It does require adding a slight variant
on ss_format_address(), but it still seems like a net win.

Signed-off-by: Ben Pfaff <blp at ovn.org>
Acked-by: Mark Michelson <mmichels at redhat.com>


  Commit: 3a974b92c28cd66c0e1e9fd4b53c4c3b8fe722cb
      https://github.com/openvswitch/ovs/commit/3a974b92c28cd66c0e1e9fd4b53c4c3b8fe722cb
  Author: Ben Pfaff <blp at ovn.org>
  Date:   2018-04-16 (Mon, 16 Apr 2018)

  Changed paths:
    M lib/socket-util.c
    M lib/socket-util.h

  Log Message:
  -----------
  socket-util: New function inet_parse_address().

This will acquire its first user in an upcoming commit.

Signed-off-by: Ben Pfaff <blp at ovn.org>
Acked-by: Mark Michelson <mmichels at redhat.com>


  Commit: 1bb011218d046b5de765658e9f5fe45289462eea
      https://github.com/openvswitch/ovs/commit/1bb011218d046b5de765658e9f5fe45289462eea
  Author: Ben Pfaff <blp at ovn.org>
  Date:   2018-04-16 (Mon, 16 Apr 2018)

  Changed paths:
    M lib/socket-util.c
    M lib/socket-util.h
    M lib/stream-tcp.c
    M lib/stream.c
    M lib/stream.h
    M lib/vlog.c
    M ofproto/collectors.c
    M ofproto/collectors.h
    M ofproto/netflow.c
    M ovn/northd/ovn-northd.c
    M ovsdb/raft-private.c

  Log Message:
  -----------
  socket-util: Make inet_parse_active() and inet_parse_passive() more alike.

Until now, the default_port parameters to these functions have had
different types and different behavior.  There is a reason for this, since
it makes sense to listen on a kernel-selected port but it does not make
sense to connect to a kernel-selected port, but this overlooks the
possibility that a caller might want to parse a string in the format
understood by inet_parse_active() without actually using it to connect to
a remote host.  This commit makes the behavior consistent and updates all
the callers to work with the new semantics.

Signed-off-by: Ben Pfaff <blp at ovn.org>
Acked-by: Mark Michelson <mmichels at redhat.com>


  Commit: 0b043300dbade23ce9435b7dd308473fea41e6fe
      https://github.com/openvswitch/ovs/commit/0b043300dbade23ce9435b7dd308473fea41e6fe
  Author: Ben Pfaff <blp at ovn.org>
  Date:   2018-04-16 (Mon, 16 Apr 2018)

  Changed paths:
    M lib/packets.c
    M lib/packets.h
    M lib/socket-util.c
    M lib/socket-util.h
    M ovn/utilities/ovn-nbctl.c
    M ovsdb/raft.c
    M tests/ovn-nbctl.at

  Log Message:
  -----------
  Make <host>:<port> parsing uniform treewide.

I didn't realize until now that the tree had two different ways of parsing
strings in the form <host>:<port> and <port>:<host>.  There are the
long-standing inet_parse_active() and inet_parse_passive() functions, and
more recently the ipv46_parse() function.  This commit eliminates the
latter and changes the code to use the former.

The two implementations interpreted some input differently.  In particular,
the older functions required IPv6 addresses to be [bracketed], but the
newer ones do not.  For compatibility this patch changes the merged code to
use the more liberal interpretation.

Signed-off-by: Ben Pfaff <blp at ovn.org>
Acked-by: Mark Michelson <mmichels at redhat.com>


  Commit: 93b7faf1c7dd6aec1c1b236787cded0270e652f3
      https://github.com/openvswitch/ovs/commit/93b7faf1c7dd6aec1c1b236787cded0270e652f3
  Author: Ben Pfaff <blp at ovn.org>
  Date:   2018-04-16 (Mon, 16 Apr 2018)

  Changed paths:
    M lib/netdev.c
    M lib/socket-util.c
    M lib/socket-util.h

  Log Message:
  -----------
  socket-util: Add more functions for IPv[46] sockaddr and sockaddr_storage.

The existing functions for working with sockaddr_storage that contain an
IPv4 or IPv6 address are useful.  This commit adds more functions for
working with them, as well as a parallel set of functions for struct
sockaddr.

This also adds an initial user for some of the new sockaddr functions in
netdev.c.

Signed-off-by: Ben Pfaff <blp at ovn.org>
Acked-by: Mark Michelson <mmichels at redhat.com>


  Commit: ee4776b8bce1162a18719cf1c1847f68571b2ff3
      https://github.com/openvswitch/ovs/commit/ee4776b8bce1162a18719cf1c1847f68571b2ff3
  Author: Ben Pfaff <blp at ovn.org>
  Date:   2018-04-16 (Mon, 16 Apr 2018)

  Changed paths:
    M lib/netdev.c
    M lib/netdev.h

  Log Message:
  -----------
  netdev: New function netdev_get_ip_by_name().

This is like netdev_get_in4_by_name() but accepts any IP address instead
of just an IPv4 address.

It will acquire its first user in an upcoming commit.

Signed-off-by: Ben Pfaff <blp at ovn.org>
Acked-by: Mark Michelson <mmichels at redhat.com>


  Commit: 71c54ad2cd4f30fc938b5c886bf25b3509fd7205
      https://github.com/openvswitch/ovs/commit/71c54ad2cd4f30fc938b5c886bf25b3509fd7205
  Author: Ben Pfaff <blp at ovn.org>
  Date:   2018-04-16 (Mon, 16 Apr 2018)

  Changed paths:
    M ofproto/ofproto-dpif-sflow.c

  Log Message:
  -----------
  ofproto-dpif-slow: Add IPv6 agent address support.

Suggested-by: Neil McKee <neil.mckee at inmon.com>
Signed-off-by: Ben Pfaff <blp at ovn.org>


  Commit: 57920076b29d14abe9d74ede43355d3906dcdffc
      https://github.com/openvswitch/ovs/commit/57920076b29d14abe9d74ede43355d3906dcdffc
  Author: Ben Pfaff <blp at ovn.org>
  Date:   2018-04-16 (Mon, 16 Apr 2018)

  Changed paths:
    M ovn/utilities/ovn-nbctl.c

  Log Message:
  -----------
  ovn-nbctl: Simplify lb_info_add_smap().

Signed-off-by: Ben Pfaff <blp at ovn.org>
Acked-by: Mark Michelson <mmichels at redhat.com>


  Commit: dcb9fd8ecd34a5940c32649dc1d5e9f20c2bd112
      https://github.com/openvswitch/ovs/commit/dcb9fd8ecd34a5940c32649dc1d5e9f20c2bd112
  Author: Ben Pfaff <blp at ovn.org>
  Date:   2018-04-16 (Mon, 16 Apr 2018)

  Changed paths:
    M ovn/utilities/ovn-nbctl.c

  Log Message:
  -----------
  ovn-nbctl: Use common code for sockaddr_storage.

This better reuses existing code.

Signed-off-by: Ben Pfaff <blp at ovn.org>
Acked-by: Mark Michelson <mmichels at redhat.com>


Compare: https://github.com/openvswitch/ovs/compare/3915a9d3c411...dcb9fd8ecd34


More information about the git mailing list