[ovs-git] [openvswitch/ovs] f415da: socket-util: Improve comments on (host, port) parsi...

GitHub noreply at github.com
Tue Apr 17 15:39:15 UTC 2018


  Branch: refs/heads/master
  Home:   https://github.com/openvswitch/ovs
  Commit: f415dad9c7d75038e21449a3fbf0f8e99f2446c1
      https://github.com/openvswitch/ovs/commit/f415dad9c7d75038e21449a3fbf0f8e99f2446c1
  Author: Ben Pfaff <blp at ovn.org>
  Date:   2018-04-17 (Tue, 17 Apr 2018)

  Changed paths:
    M lib/socket-util.c

  Log Message:
  -----------
  socket-util: Improve comments on (host,port) parsing functions.

Fixes: 0b043300dbad ("Make <host>:<port> parsing uniform treewide.")
Suggested-by: Mark Michelson <mmichels at redhat.com>
Signed-off-by: Ben Pfaff <blp at ovn.org>


  Commit: d2a60e57a863d123dfd63048763d61f9f406b916
      https://github.com/openvswitch/ovs/commit/d2a60e57a863d123dfd63048763d61f9f406b916
  Author: Ben Pfaff <blp at ovn.org>
  Date:   2018-04-17 (Tue, 17 Apr 2018)

  Changed paths:
    M lib/netdev.c

  Log Message:
  -----------
  netdev: Fix typos in comment.

Fixes: ee4776b8bce1 ("netdev: New function netdev_get_ip_by_name().")
Suggested-by: Mark Michelson <mmichels at redhat.com>
Signed-off-by: Ben Pfaff <blp at ovn.org>


  Commit: 112b63362748049986e82e2c6335be179835d8f4
      https://github.com/openvswitch/ovs/commit/112b63362748049986e82e2c6335be179835d8f4
  Author: Timothy Redaelli <tredaelli at redhat.com>
  Date:   2018-04-17 (Tue, 17 Apr 2018)

  Changed paths:
    M rhel/usr_lib_systemd_system_ovs-vswitchd.service.in
    M rhel/usr_lib_systemd_system_ovsdb-server.service

  Log Message:
  -----------
  rhel: Fix literal dollar sign usage in systemd service files

Currently (at least on RHEL 7.5) openvswitch fails to start (with DPDK
enabled) as non-root, since chown fails and "/dev/hugepages" group is not
changed.

Commit tested on Fedora 28 and RHEL 7.5, both as root as non-root user.

>From man 5 systemd.service:

  To pass a literal dollar sign, use "$$". Variables whose value is not known
  at expansion time are treated as empty strings. Note that the first argument
  (i.e. the program to execute) may not be a variable.

CC: Aaron Conole <aconole at redhat.com>
Fixes: 4299145c1095 ("rhel: don't drop capabilities when running as root")
Signed-off-by: Timothy Redaelli <tredaelli at redhat.com>
Signed-off-by: Ben Pfaff <blp at ovn.org>
Acked-by: Aaron Conole <aconole at redhat.com>
Acked-by: Eelco Chaudron <echaudro at redhat.com>


Compare: https://github.com/openvswitch/ovs/compare/296251ca0c82...112b63362748


More information about the git mailing list