[ovs-git] [openvswitch/ovs] de1034: netdev-dpdk: fix MAC address in port addr example

GitHub noreply at github.com
Mon Apr 30 15:40:16 UTC 2018


  Branch: refs/heads/master
  Home:   https://github.com/openvswitch/ovs
  Commit: de1034b0a8925bd0c7d70ad437525d22eb015146
      https://github.com/openvswitch/ovs/commit/de1034b0a8925bd0c7d70ad437525d22eb015146
  Author: Marcelo Ricardo Leitner <marcelo.leitner at gmail.com>
  Date:   2018-04-21 (Sat, 21 Apr 2018)

  Changed paths:
    M Documentation/howto/dpdk.rst

  Log Message:
  -----------
  netdev-dpdk: fix MAC address in port addr example

The MAC address is always 6-bytes long, never 7. The extra :01 and :02
doesn't belong in there as it doesn't mean selecting one port or
another.

Instead, use an incrementing MAC address, which is what usually happens
on such cards.

See-also: http://www.dpdk.org/ml/archives/dev/2018-April/094976.html
Fixes: 5e7588186839 ("netdev-dpdk: fix port addition for ports sharing same PCI id")
Signed-off-by: Marcelo Ricardo Leitner <marcelo.leitner at gmail.com>
Signed-off-by: Ian Stokes <ian.stokes at intel.com>


  Commit: f9319c3f8cde8ad5703fc205d20b836c589d5665
      https://github.com/openvswitch/ovs/commit/f9319c3f8cde8ad5703fc205d20b836c589d5665
  Author: Tiago Lam <tiago.lam at intel.com>
  Date:   2018-04-21 (Sat, 21 Apr 2018)

  Changed paths:
    M Documentation/topics/dpdk/vhost-user.rst

  Log Message:
  -----------
  dpdk docs: Drop qemu-kvm for qemu-system-x86_64.

When explaining on how to add vhost-user ports to a guest, using
libvirt, point to the qemu-system-x86_64 binary by default, instead of
using qemu-kvm. The latter has been made obsolete and dropped from a
number of distributions (although it is still available on Fedora).

This has been verified on both a Fedora 27 image and a Ubuntu 16.04 LTS
image.

Signed-off-by: Tiago Lam <tiago.lam at intel.com>
Acked-by: Aaron Conole <aconole at redhat.com>
Signed-off-by: Ian Stokes <ian.stokes at intel.com>


  Commit: 293e7c56f6649045f84f25f0fa5a3012f9feb73f
      https://github.com/openvswitch/ovs/commit/293e7c56f6649045f84f25f0fa5a3012f9feb73f
  Author: Tiago Lam <tiago.lam at intel.com>
  Date:   2018-04-21 (Sat, 21 Apr 2018)

  Changed paths:
    M Documentation/topics/dpdk/vhost-user.rst

  Log Message:
  -----------
  dpdk docs: Drop file share in libvirt config.

When explaining on how to add vhost-user ports to a guest, using
libvirt, the following piece of configuration is used:
    <disk type='dir' device='disk'>
      <driver name='qemu' type='fat'/>
      <source dir='/usr/src/dpdk-stable-17.11.1'/>
      <target dev='vdb' bus='virtio'/>
      <readonly/>
    </disk>

This is used to facilitate sharing of a DPDK directory between the host
and the guest. However, for this to work selinux also needs to be
configured (or disabled).  Furthermore, if one is using Ubuntu, libvirtd
would need to be added to complain only in AppArmor. Instead, in [1] it
is advised to use wget to get the DPDK sources over the internet, which
avoids this differentiation. Thus, we drop this piece of configuration
here as well and keep the example configuration as simple as possible.

This has been verified on both a Fedora 27 image and a Ubuntu 16.04 LTS
image.

[1] http://docs.openvswitch.org/en/latest/topics/dpdk/vhost-user/#dpdk-in-the-guest

Signed-off-by: Tiago Lam <tiago.lam at intel.com>
Acked-by: Stephen Finucane <stephen at that.guru>
Signed-off-by: Ian Stokes <ian.stokes at intel.com>


  Commit: 91fccdad72a253a3892dcb3c4453a31833851bb7
      https://github.com/openvswitch/ovs/commit/91fccdad72a253a3892dcb3c4453a31833851bb7
  Author: Kevin Traynor <ktraynor at redhat.com>
  Date:   2018-04-21 (Sat, 21 Apr 2018)

  Changed paths:
    M lib/netdev-dpdk.c

  Log Message:
  -----------
  netdev-dpdk: Free mempool only when no in-use mbufs.

DPDK mempools are freed when they are no longer needed.
This can happen when a port is removed or a port's mtu
is reconfigured so that a new mempool is used.

It is possible that an mbuf is attempted to be returned
to a freed mempool from NIC Tx queues and this can lead
to a segfault.

In order to prevent this, only free mempools when they
are not needed and have no in-use mbufs. As this might
not be possible immediately, create a free list of
mempools and sweep it anytime a port tries to get a
mempool.

Fixes: 8d38823bdf8b ("netdev-dpdk: fix memory leak")
Cc: mark.b.kavanagh81 at gmail.com
Cc: Ilya Maximets <i.maximets at samsung.com>
Reported-by: Venkatesan Pradeep <venkatesan.pradeep at ericsson.com>
Signed-off-by: Kevin Traynor <ktraynor at redhat.com>
Signed-off-by: Ian Stokes <ian.stokes at intel.com>


  Commit: f015af0da23cc58aecd685ef0e1df8ce0903841a
      https://github.com/openvswitch/ovs/commit/f015af0da23cc58aecd685ef0e1df8ce0903841a
  Author: Ian Stokes <ian.stokes at intel.com>
  Date:   2018-04-21 (Sat, 21 Apr 2018)

  Changed paths:
    M Documentation/howto/sflow.rst

  Log Message:
  -----------
  docs: Fix sflow documentation url and markup.

The link url link for the blog in sflow documentation causes make
check-docs to fail with a broken link warning. Fix this by correcting
the url address. Also use correct markup for note regarding the
configuration of sflow.

CC: Stephen Finucane <stephen at that.guru>
Fixes: 198c5d3d0 ("doc: Add sFlow cookbook from website")
Signed-off-by: Ian Stokes <ian.stokes at intel.com>
Acked-by: Stephen Finucane <stephen at that.guru>


  Commit: ad7b1339f1217e862daa2197a9ffed3cf051e3e9
      https://github.com/openvswitch/ovs/commit/ad7b1339f1217e862daa2197a9ffed3cf051e3e9
  Author: Ian Stokes <ian.stokes at intel.com>
  Date:   2018-04-21 (Sat, 21 Apr 2018)

  Changed paths:
    M Documentation/internals/contributing/documentation-style.rst

  Log Message:
  -----------
  docs: Fix style guide url in DocumentationStyle.rst.

The link used for IBM Style Guide is no longer valid. As there is no
longer a valid link via redbooks remove the url to avoid make
check-docs failing.

Cc: Stephen Finucane <stephen at that.guru>
Fixes: 26ea2d409 ("docs: Add writing guide")
Signed-off-by: Ian Stokes <ian.stokes at intel.com>
Acked-by: Stephen Finucane <stephen at that.guru>


  Commit: f0100009ba62f36af425e56812140773e264feff
      https://github.com/openvswitch/ovs/commit/f0100009ba62f36af425e56812140773e264feff
  Author: Ian Stokes <ian.stokes at intel.com>
  Date:   2018-04-21 (Sat, 21 Apr 2018)

  Changed paths:
    M Documentation/internals/contributing/documentation-style.rst
    M Documentation/intro/install/documentation.rst

  Log Message:
  -----------
  docs: Fix sphinx urls.

Update dead url links for sphinx documentation to avoid
make check-docs failing.

Cc: Stephen Finucane <stephen at that.guru>
Fixes: 26ea2d409 ("docs: Add writing guide")
Fixes: 73c76b447 ("doc: Add info on building documentation")
Signed-off-by: Ian Stokes <ian.stokes at intel.com>
Acked-by: Stephen Finucane <stephen at that.guru>


  Commit: 665330dae2b9eb977f11e5840203821344a2a9ec
      https://github.com/openvswitch/ovs/commit/665330dae2b9eb977f11e5840203821344a2a9ec
  Author: Ian Stokes <ian.stokes at intel.com>
  Date:   2018-04-21 (Sat, 21 Apr 2018)

  Changed paths:
    M Documentation/ref/index.rst

  Log Message:
  -----------
  docs: Fix urls in index.rst.

This patch prepends 'www' to openvswitch urls in index.rst. Without this
make check-docs fails when verifying url liveness. Also remove url
referencing ovsdb-server(5) as these are no longer accessible.

Cc: Stephen Finucane <stephen at that.guru>
Fixes: 4f6ec357c ("doc: Populate 'ref' section")
Signed-off-by: Ian Stokes <ian.stokes at intel.com>
Acked-by: Stephen Finucane <stephen at that.guru>


  Commit: 6477dbb9d6560a3af2d63448fbe40ea6a2191788
      https://github.com/openvswitch/ovs/commit/6477dbb9d6560a3af2d63448fbe40ea6a2191788
  Author: Stephen Finucane <stephen at that.guru>
  Date:   2018-04-21 (Sat, 21 Apr 2018)

  Changed paths:
    M Documentation/automake.mk
    M Documentation/conf.py
    M Documentation/topics/dpdk/index.rst
    A Documentation/topics/dpdk/phy.rst

  Log Message:
  -----------
  doc: Add an overview of the 'dpdk' port

These ports are used to allow ingress/egress from the host and are
therefore _reasonably_ important. However, there is no clear overview of
what these ports actually are or why things are done the way they are.
Start closing this gap by providing a standalone example of using these
ports along with a little more detailed overview of the binding process.

There is additional cleanup to be done for the DPDK howto, but that will
be done separately.

We enable the TODO directive so we can actually start calling out some
TODOs.

Signed-off-by: Stephen Finucane <stephen at that.guru>
Signed-off-by: Ian Stokes <ian.stokes at intel.com>


  Commit: 31d0dae22a0ea1818c89e3a1d02ea515229bb1ad
      https://github.com/openvswitch/ovs/commit/31d0dae22a0ea1818c89e3a1d02ea515229bb1ad
  Author: Stephen Finucane <stephen at that.guru>
  Date:   2018-04-21 (Sat, 21 Apr 2018)

  Changed paths:
    M Documentation/automake.mk
    M Documentation/howto/dpdk.rst
    M Documentation/topics/dpdk/index.rst
    M Documentation/topics/dpdk/phy.rst
    A Documentation/topics/dpdk/pmd.rst
    M Documentation/topics/dpdk/vhost-user.rst

  Log Message:
  -----------
  doc: Add "PMD" topic document

This continues the breakup of the huge DPDK "howto" into smaller
components. There are a couple of related changes included, such as
using "Rx queue" instead of "rxq" and noting how Tx queues cannot be
configured.

Signed-off-by: Stephen Finucane <stephen at that.guru>
Signed-off-by: Ian Stokes <ian.stokes at intel.com>


  Commit: 048c6c97dca091ba228e15fcbd44e70a197413ab
      https://github.com/openvswitch/ovs/commit/048c6c97dca091ba228e15fcbd44e70a197413ab
  Author: Stephen Finucane <stephen at that.guru>
  Date:   2018-04-21 (Sat, 21 Apr 2018)

  Changed paths:
    M Documentation/howto/dpdk.rst
    M Documentation/topics/dpdk/index.rst
    M Documentation/topics/dpdk/phy.rst

  Log Message:
  -----------
  doc: Move additional sections to "physical ports" doc

The "hotplugging", "flow control", and "Rx checksum offload" sections
only apply to 'dpdk' ports and are too detailed to include in a
high-level howto. Move them, reworking some aspects of this in the
process.

Signed-off-by: Stephen Finucane <stephen at that.guru>
Signed-off-by: Ian Stokes <ian.stokes at intel.com>


  Commit: b20eabc3fd5238d98c8e9bf8b60f353a2c820f5d
      https://github.com/openvswitch/ovs/commit/b20eabc3fd5238d98c8e9bf8b60f353a2c820f5d
  Author: Stephen Finucane <stephen at that.guru>
  Date:   2018-04-21 (Sat, 21 Apr 2018)

  Changed paths:
    M Documentation/automake.mk
    M Documentation/howto/dpdk.rst
    M Documentation/topics/dpdk/index.rst
    A Documentation/topics/dpdk/vdev.rst

  Log Message:
  -----------
  doc: Add "vdev" topic document

These are separate things from physical, ring and vhost-user interfaces
and deserve their own documents. A couple of small typos are fixed along
the way.

Signed-off-by: Stephen Finucane <stephen at that.guru>
Signed-off-by: Ian Stokes <ian.stokes at intel.com>


  Commit: 6fe32f11bbc11858618b4d636017652e432710c9
      https://github.com/openvswitch/ovs/commit/6fe32f11bbc11858618b4d636017652e432710c9
  Author: Stephen Finucane <stephen at that.guru>
  Date:   2018-04-21 (Sat, 21 Apr 2018)

  Changed paths:
    M Documentation/automake.mk
    M Documentation/howto/dpdk.rst
    M Documentation/topics/dpdk/index.rst
    M Documentation/topics/dpdk/phy.rst
    A Documentation/topics/dpdk/qos.rst

  Log Message:
  -----------
  doc: Move "QoS" guide to its own document

Again, this stuff is too detailed for a high-level howto.

Signed-off-by: Stephen Finucane <stephen at that.guru>
Signed-off-by: Ian Stokes <ian.stokes at intel.com>


  Commit: 7b743caf6c4830c27aa35175650dc7c88ea62aae
      https://github.com/openvswitch/ovs/commit/7b743caf6c4830c27aa35175650dc7c88ea62aae
  Author: Stephen Finucane <stephen at that.guru>
  Date:   2018-04-21 (Sat, 21 Apr 2018)

  Changed paths:
    M Documentation/automake.mk
    M Documentation/howto/dpdk.rst
    A Documentation/topics/dpdk/bridge.rst
    M Documentation/topics/dpdk/index.rst
    M Documentation/topics/dpdk/phy.rst
    M Documentation/topics/dpdk/ring.rst
    M Documentation/topics/dpdk/vdev.rst
    M Documentation/topics/dpdk/vhost-user.rst

  Log Message:
  -----------
  doc: Add "bridge" topic document

This details configuration steps that apply to the entire bridge, rather
than individual ports.

Signed-off-by: Stephen Finucane <stephen at that.guru>
Signed-off-by: Ian Stokes <ian.stokes at intel.com>


  Commit: 099a3547bd8a860e54daa0eece27a57809854eba
      https://github.com/openvswitch/ovs/commit/099a3547bd8a860e54daa0eece27a57809854eba
  Author: Stephen Finucane <stephen at that.guru>
  Date:   2018-04-21 (Sat, 21 Apr 2018)

  Changed paths:
    M Documentation/automake.mk
    M Documentation/howto/dpdk.rst
    M Documentation/topics/dpdk/index.rst
    A Documentation/topics/dpdk/pdump.rst

  Log Message:
  -----------
  doc: Move "pdump" guide to its own document

Yet another section that's far too detailed for someone getting started
with DPDK in OVS. Split it out.

Signed-off-by: Stephen Finucane <stephen at that.guru>
Signed-off-by: Ian Stokes <ian.stokes at intel.com>


  Commit: a790e75fa48f5559a904a27abeb1b95a6d6e243f
      https://github.com/openvswitch/ovs/commit/a790e75fa48f5559a904a27abeb1b95a6d6e243f
  Author: Stephen Finucane <stephen at that.guru>
  Date:   2018-04-21 (Sat, 21 Apr 2018)

  Changed paths:
    M Documentation/automake.mk
    M Documentation/howto/dpdk.rst
    M Documentation/topics/dpdk/index.rst
    A Documentation/topics/dpdk/jumbo-frames.rst
    M Documentation/topics/dpdk/phy.rst
    M Documentation/topics/dpdk/vhost-user.rst

  Log Message:
  -----------
  doc: Add "jumbo frames" topic document

We include references from the physical and vhost-user interface guides.

Signed-off-by: Stephen Finucane <stephen at that.guru>
Signed-off-by: Ian Stokes <ian.stokes at intel.com>


  Commit: a1e539885dc40ab3217a6c56237fd9971a653dbf
      https://github.com/openvswitch/ovs/commit/a1e539885dc40ab3217a6c56237fd9971a653dbf
  Author: Stephen Finucane <stephen at that.guru>
  Date:   2018-04-21 (Sat, 21 Apr 2018)

  Changed paths:
    M Documentation/topics/dpdk/pmd.rst
    M NEWS

  Log Message:
  -----------
  docs: Clarify changes in Rx queue allocation

Two mistakes here:

- Automatic assignment of Rx queues to PMD threads has always existed -
  it was simply switched from round-robin allocation to
  utilization-based allocation
- The above, along with the 'pmd-rxq-rebalance' command, was added in
  OVS 2.9.0 - not OVS 2.8.0 - while the 'pmd-rxq-show' command was added
  in OVS 2.6.0 and modified in OVS 2.9.0

Correct both of these and modify the NEWS entry for this to clarify
things a little (it took a bit of git spelunking and bothering people on
IRC to figure out).

Signed-off-by: Stephen Finucane <stephen at that.guru>
Cc: Kevin Traynor <ktraynor at redhat.com>
Cc: Ian Stokes <ian.stokes at intel.com>
Acked-by: Kevin Traynor <ktraynor at redhat.com>
Signed-off-by: Ian Stokes <ian.stokes at intel.com>


  Commit: a7e4849ef0096f4396cc17afeb5325af8d1b4e3b
      https://github.com/openvswitch/ovs/commit/a7e4849ef0096f4396cc17afeb5325af8d1b4e3b
  Author: Marcin Rybka <marcinx.rybka at intel.com>
  Date:   2018-04-21 (Sat, 21 Apr 2018)

  Changed paths:
    M Documentation/topics/testing.rst
    M NEWS
    M tests/automake.mk
    A tests/system-dpdk-macros.at
    A tests/system-dpdk-testsuite.at
    A tests/system-dpdk.at

  Log Message:
  -----------
  tests: Add system-dpdk-testsuite

New OVS-DPDK testsuite, which can be launched via `make check-dpdk`,
tests OVS using a DPDK datapath. The testsuite contains already
initial tests:
 1. EAL init
 2. Add standard DPDK PHY port
 3. Add vhost-user-client port

Signed-off-by: Marcin Rybka <marcinx.rybka at intel.com>
Signed-off-by: Ian Stokes <ian.stokes at intel.com>


  Commit: 6bb97140b3a9caa4e90d3f5081ffaca9f6ae9d1b
      https://github.com/openvswitch/ovs/commit/6bb97140b3a9caa4e90d3f5081ffaca9f6ae9d1b
  Author: Ben Pfaff <blp at ovn.org>
  Date:   2018-04-30 (Mon, 30 Apr 2018)

  Changed paths:
    M Documentation/automake.mk
    M Documentation/conf.py
    M Documentation/howto/dpdk.rst
    M Documentation/howto/sflow.rst
    M Documentation/internals/contributing/documentation-style.rst
    M Documentation/intro/install/documentation.rst
    M Documentation/ref/index.rst
    A Documentation/topics/dpdk/bridge.rst
    M Documentation/topics/dpdk/index.rst
    A Documentation/topics/dpdk/jumbo-frames.rst
    A Documentation/topics/dpdk/pdump.rst
    A Documentation/topics/dpdk/phy.rst
    A Documentation/topics/dpdk/pmd.rst
    A Documentation/topics/dpdk/qos.rst
    M Documentation/topics/dpdk/ring.rst
    A Documentation/topics/dpdk/vdev.rst
    M Documentation/topics/dpdk/vhost-user.rst
    M Documentation/topics/testing.rst
    M NEWS
    M lib/netdev-dpdk.c
    M tests/automake.mk
    A tests/system-dpdk-macros.at
    A tests/system-dpdk-testsuite.at
    A tests/system-dpdk.at

  Log Message:
  -----------
  Merge branch 'dpdk_merge' of https://github.com/istokes/ovs into HEAD


Compare: https://github.com/openvswitch/ovs/compare/fad594911cad...6bb97140b3a9


More information about the git mailing list