[ovs-git] [openvswitch/ovs] 371573: netdev-dpdk: Remove 'error' from non error log.

GitHub noreply at github.com
Mon Apr 30 15:44:21 UTC 2018


  Branch: refs/heads/branch-2.6
  Home:   https://github.com/openvswitch/ovs
  Commit: 371573f570cf20141accb49b1ce9c33aa71e9fe3
      https://github.com/openvswitch/ovs/commit/371573f570cf20141accb49b1ce9c33aa71e9fe3
  Author: Kevin Traynor <ktraynor at redhat.com>
  Date:   2018-04-19 (Thu, 19 Apr 2018)

  Changed paths:
    M lib/netdev-dpdk.c

  Log Message:
  -----------
  netdev-dpdk: Remove 'error' from non error log.

Presently, if OVS tries to setup more queues than
are allowed by a specific NIC, OVS will handle
this case by retrying with a lower amount of queues.

Rather than reporting initial failed queue setups
in the logs as ERROR, they are reported as INFO but
contain the word 'error'. Unless a user has detailed
knowledge of OVS-DPDK workings, this is confusing.

Let's remove 'error' from the INFO log.

Signed-off-by: Kevin Traynor <ktraynor at redhat.com>
Signed-off-by: Ian Stokes <ian.stokes at intel.com>


  Commit: f3afac0ceb97161eaeecb61b1aea292c1c8cc56e
      https://github.com/openvswitch/ovs/commit/f3afac0ceb97161eaeecb61b1aea292c1c8cc56e
  Author: Ian Stokes <ian.stokes at intel.com>
  Date:   2018-04-19 (Thu, 19 Apr 2018)

  Changed paths:
    M INSTALL.DPDK.md

  Log Message:
  -----------
  dpdk docs: Drop qemu-kvm for qemu-system-x86_64.

When explaining on how to add vhost-user ports to a guest, using
libvirt, point to the qemu-system-x86_64 binary by default, instead of
using qemu-kvm. The latter has been made obsolete and dropped from a
number of distributions (although it is still available on Fedora).

This has been verified on both a Fedora 27 image and a Ubuntu 16.04 LTS
image.

Signed-off-by: Tiago Lam <tiago.lam at intel.com>
Acked-by: Aaron Conole <aconole at redhat.com>
Signed-off-by: Ian Stokes <ian.stokes at intel.com>


  Commit: ea9aefb319421c6db1bb42648934fb14e9d490ba
      https://github.com/openvswitch/ovs/commit/ea9aefb319421c6db1bb42648934fb14e9d490ba
  Author: Ian Stokes <ian.stokes at intel.com>
  Date:   2018-04-19 (Thu, 19 Apr 2018)

  Changed paths:
    M INSTALL.DPDK.md

  Log Message:
  -----------
  dpdk docs: Drop file share in libvirt config.

When explaining on how to add vhost-user ports to a guest, using
libvirt, the following piece of configuration is used:
    <disk type='dir' device='disk'>
      <driver name='qemu' type='fat'/>
      <source dir='/usr/src/dpdk-stable-17.11.1'/>
      <target dev='vdb' bus='virtio'/>
      <readonly/>
    </disk>

This is used to facilitate sharing of a DPDK directory between the host
and the guest. However, for this to work selinux also needs to be
configured (or disabled).  Furthermore, if one is using Ubuntu, libvirtd
would need to be added to complain only in AppArmor. Instead, in [1] it
is advised to use wget to get the DPDK sources over the internet, which
avoids this differentiation. Thus, we drop this piece of configuration
here as well and keep the example configuration as simple as possible.

This has been verified on both a Fedora 27 image and a Ubuntu 16.04 LTS
image.

[1]
http://docs.openvswitch.org/en/latest/topics/dpdk/vhost-user/#dpdk-in-the-guest

Signed-off-by: Tiago Lam <tiago.lam at intel.com>
Acked-by: Stephen Finucane <stephen at that.guru>
Signed-off-by: Ian Stokes <ian.stokes at intel.com>


  Commit: 5b611ab9a9831cd9c45023c8562f62569efc8f17
      https://github.com/openvswitch/ovs/commit/5b611ab9a9831cd9c45023c8562f62569efc8f17
  Author: Kevin Traynor <ktraynor at redhat.com>
  Date:   2018-04-21 (Sat, 21 Apr 2018)

  Changed paths:
    M lib/netdev-dpdk.c

  Log Message:
  -----------
  netdev-dpdk: Free mempool only when no in-use mbufs.

DPDK mempools are freed when they are no longer needed.
This can happen when a port is removed or a port's mtu
is reconfigured so that a new mempool is used.

It is possible that an mbuf is attempted to be returned
to a freed mempool from NIC Tx queues and this can lead
to a segfault.

In order to prevent this, only free mempools when they
are not needed and have no in-use mbufs. As this might
not be possible immediately, sweep the mempools anytime
a port tries to get a mempool.

Fixes: 8d38823bdf8b ("netdev-dpdk: fix memory leak")
Cc: mark.b.kavanagh81 at gmail.com
Reported-by: Venkatesan Pradeep <venkatesan.pradeep at ericsson.com>
Signed-off-by: Kevin Traynor <ktraynor at redhat.com>
Signed-off-by: Ian Stokes <ian.stokes at intel.com>


  Commit: f337be3c81311d6ad9be27199ad4a99bc9c34d2d
      https://github.com/openvswitch/ovs/commit/f337be3c81311d6ad9be27199ad4a99bc9c34d2d
  Author: Ben Pfaff <blp at ovn.org>
  Date:   2018-04-30 (Mon, 30 Apr 2018)

  Changed paths:
    M INSTALL.DPDK.md
    M lib/netdev-dpdk.c

  Log Message:
  -----------
  Merge branch 'dpdk_merge_2_6' of https://github.com/istokes/ovs into HEAD


Compare: https://github.com/openvswitch/ovs/compare/d77adf3e5fcc...f337be3c8131


More information about the git mailing list