[ovs-git] [openvswitch/ovs] 18e089: dpif-netdev: Fix zero length keys insertion to EMC...

GitHub noreply at github.com
Wed Aug 8 23:13:34 UTC 2018


  Branch: refs/heads/master
  Home:   https://github.com/openvswitch/ovs
  Commit: 18e08953cf3bdbc1f73a1b7349322259e6be2748
      https://github.com/openvswitch/ovs/commit/18e08953cf3bdbc1f73a1b7349322259e6be2748
  Author: Ilya Maximets <i.maximets at samsung.com>
  Date:   2018-08-08 (Wed, 08 Aug 2018)

  Changed paths:
    M lib/dpif-netdev.c

  Log Message:
  -----------
  dpif-netdev: Fix zero length keys insertion to EMC.

'key.len' should be calculated before inserting to EMC, otherwise
resulting entry will match with any packet with the same hash.

CC: Yipeng Wang <yipeng1.wang at intel.com>
Fixes: 60d8ccae135f ("dpif-netdev: Add SMC cache after EMC cache")
Signed-off-by: Ilya Maximets <i.maximets at samsung.com>
Acked-by: Yipeng Wang <yipeng1.wang at intel.com>
Signed-off-by: Ian Stokes <ian.stokes at intel.com>


  Commit: 7e1de65e8dfbd8a93582102df2d36cf58d289e4c
      https://github.com/openvswitch/ovs/commit/7e1de65e8dfbd8a93582102df2d36cf58d289e4c
  Author: Sugesh Chandran <sugesh.chandran at intel.com>
  Date:   2018-08-08 (Wed, 08 Aug 2018)

  Changed paths:
    M lib/netdev-dpdk.c

  Log Message:
  -----------
  netdev-dpdk: Fix failure to configure flow control at netdev-init.

Configuring flow control at ixgbe netdev-init is throwing error in port
start.

For eg: without this fix, user cannot configure flow control on ixgbe dpdk
port as below,

"
    ovs-vsctl add-port br0 dpdk0 -- set Interface dpdk0 type=dpdk \
  options:dpdk-devargs=0000:05:00.1 options:rx-flow-ctrl=true
"

Instead,  it must be configured as two different commands,

"
    ovs-vsctl add-port br0 dpdk0 -- set Interface dpdk0 type=dpdk \
         options:dpdk-devargs=0000:05:00.1
    ovs-vsctl set Interface dpdk0 options:rx-flow-ctrl=true
"

The DPDK ixgbe driver is now validating all the 'rte_eth_fc_conf' fields before
trying to configuring the dpdk ethdev. Hence OVS can no longer set the
'dont care' fields to just '0' as before. This commit make sure all the
'rte_eth_fc_conf' fields are populated with default values before the dev
init.

Also to avoid read error on unsupported ports, the flow control parameters
are now read only when user is trying to configure/update it.

Signed-off-by: Sugesh Chandran <sugesh.chandran at intel.com>
Signed-off-by: Ian Stokes <ian.stokes at intel.com>


  Commit: 51c6a5a3c869ca5327ccd7be73a6f585e0028875
      https://github.com/openvswitch/ovs/commit/51c6a5a3c869ca5327ccd7be73a6f585e0028875
  Author: Kevin Traynor <ktraynor at redhat.com>
  Date:   2018-08-08 (Wed, 08 Aug 2018)

  Changed paths:
    M lib/netdev-dpdk.c

  Log Message:
  -----------
  netdev-dpdk: Use hex for PCI vendor ID.

Match the prefix and formatting.

Fixes: 8a9562d21a40 ("dpif-netdev: Add DPDK netdev.")
Cc: pshelar at ovn.org

Signed-off-by: Kevin Traynor <ktraynor at redhat.com>
Signed-off-by: Ian Stokes <ian.stokes at intel.com>


  Commit: 7333c3b1ce02148c7e6c584edeeb505277fe1b7f
      https://github.com/openvswitch/ovs/commit/7333c3b1ce02148c7e6c584edeeb505277fe1b7f
  Author: Ben Pfaff <blp at ovn.org>
  Date:   2018-08-08 (Wed, 08 Aug 2018)

  Changed paths:
    M lib/ofp-port.c

  Log Message:
  -----------
  ofp-port: Fix buffer overread parsing Intel custom statistics.

CC: Michal Weglicki <michalx.weglicki at intel.com>
Fixes: 971f4b394c6e ("netdev: Custom statistics.")
Reported-at: https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=9445
Signed-off-by: Ben Pfaff <blp at ovn.org>
Signed-off-by: Ian Stokes <ian.stokes at intel.com>


  Commit: b2d9a9ef5aae1b899e8458c5324e85ff70f27c7e
      https://github.com/openvswitch/ovs/commit/b2d9a9ef5aae1b899e8458c5324e85ff70f27c7e
  Author: Ben Pfaff <blp at ovn.org>
  Date:   2018-08-08 (Wed, 08 Aug 2018)

  Changed paths:
    M lib/ofp-port.c

  Log Message:
  -----------
  ofp-port: Drop of useless indirection in ofputil_pull_ofp14_port_stats().

Signed-off-by: Ben Pfaff <blp at ovn.org>
Signed-off-by: Ian Stokes <ian.stokes at intel.com>


  Commit: 8aa88fadc41fa9cbc578d51d39f5d82528406710
      https://github.com/openvswitch/ovs/commit/8aa88fadc41fa9cbc578d51d39f5d82528406710
  Author: Ben Pfaff <blp at ovn.org>
  Date:   2018-08-08 (Wed, 08 Aug 2018)

  Changed paths:
    M lib/dpif-netdev.c
    M lib/netdev-dpdk.c
    M lib/ofp-port.c

  Log Message:
  -----------
  Merge branch 'dpdk_merge' of https://github.com/istokes/ovs into HEAD


Compare: https://github.com/openvswitch/ovs/compare/187f7d60b14c...8aa88fadc41f
      **NOTE:** This service has been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/

      Functionality will be removed from GitHub.com on January 31st, 2019.


More information about the git mailing list