[ovs-git] [openvswitch/ovs] bcbb27: dpif-netdev: Fix zero length keys insertion to EMC...

GitHub noreply at github.com
Wed Aug 8 23:16:15 UTC 2018


  Branch: refs/heads/branch-2.10
  Home:   https://github.com/openvswitch/ovs
  Commit: bcbb27517639afd93d8cc579a7a010e9a228dd2d
      https://github.com/openvswitch/ovs/commit/bcbb27517639afd93d8cc579a7a010e9a228dd2d
  Author: Ilya Maximets <i.maximets at samsung.com>
  Date:   2018-08-08 (Wed, 08 Aug 2018)

  Changed paths:
    M lib/dpif-netdev.c

  Log Message:
  -----------
  dpif-netdev: Fix zero length keys insertion to EMC.

'key.len' should be calculated before inserting to EMC, otherwise
resulting entry will match with any packet with the same hash.

CC: Yipeng Wang <yipeng1.wang at intel.com>
Fixes: 60d8ccae135f ("dpif-netdev: Add SMC cache after EMC cache")
Signed-off-by: Ilya Maximets <i.maximets at samsung.com>
Acked-by: Yipeng Wang <yipeng1.wang at intel.com>
Signed-off-by: Ian Stokes <ian.stokes at intel.com>


  Commit: eff2718fc079dccc0e3dbd3f38a7e22c5743f801
      https://github.com/openvswitch/ovs/commit/eff2718fc079dccc0e3dbd3f38a7e22c5743f801
  Author: Sugesh Chandran <sugesh.chandran at intel.com>
  Date:   2018-08-08 (Wed, 08 Aug 2018)

  Changed paths:
    M lib/netdev-dpdk.c

  Log Message:
  -----------
  netdev-dpdk: Fix failure to configure flow control at netdev-init.

Configuring flow control at ixgbe netdev-init is throwing error in port
start.

For eg: without this fix, user cannot configure flow control on ixgbe dpdk
port as below,

"
    ovs-vsctl add-port br0 dpdk0 -- set Interface dpdk0 type=dpdk \
  options:dpdk-devargs=0000:05:00.1 options:rx-flow-ctrl=true
"

Instead,  it must be configured as two different commands,

"
    ovs-vsctl add-port br0 dpdk0 -- set Interface dpdk0 type=dpdk \
         options:dpdk-devargs=0000:05:00.1
    ovs-vsctl set Interface dpdk0 options:rx-flow-ctrl=true
"

The DPDK ixgbe driver is now validating all the 'rte_eth_fc_conf' fields before
trying to configuring the dpdk ethdev. Hence OVS can no longer set the
'dont care' fields to just '0' as before. This commit make sure all the
'rte_eth_fc_conf' fields are populated with default values before the dev
init.
Also to avoid read error on unsupported ports, the flow control parameters
are now read only when user is trying to configure/update it.

Signed-off-by: Sugesh Chandran <sugesh.chandran at intel.com>
Signed-off-by: Ian Stokes <ian.stokes at intel.com>


  Commit: b98c6058afd6ccc4bf53349d84ff8522910342db
      https://github.com/openvswitch/ovs/commit/b98c6058afd6ccc4bf53349d84ff8522910342db
  Author: Kevin Traynor <ktraynor at redhat.com>
  Date:   2018-08-08 (Wed, 08 Aug 2018)

  Changed paths:
    M lib/netdev-dpdk.c

  Log Message:
  -----------
  netdev-dpdk: Use hex for PCI vendor ID.

Match the prefix and formatting.

Fixes: 8a9562d21a40 ("dpif-netdev: Add DPDK netdev.")
Cc: pshelar at ovn.org

Signed-off-by: Kevin Traynor <ktraynor at redhat.com>
Signed-off-by: Ian Stokes <ian.stokes at intel.com>


  Commit: 553d3f1549385a009f703b86aa76d9896fa8da27
      https://github.com/openvswitch/ovs/commit/553d3f1549385a009f703b86aa76d9896fa8da27
  Author: Ben Pfaff <blp at ovn.org>
  Date:   2018-08-08 (Wed, 08 Aug 2018)

  Changed paths:
    M lib/ofp-port.c

  Log Message:
  -----------
  ofp-port: Fix buffer overread parsing Intel custom statistics.

CC: Michal Weglicki <michalx.weglicki at intel.com>
Fixes: 971f4b394c6e ("netdev: Custom statistics.")
Reported-at: https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=9445
Signed-off-by: Ben Pfaff <blp at ovn.org>
Signed-off-by: Ian Stokes <ian.stokes at intel.com>


Compare: https://github.com/openvswitch/ovs/compare/faf64fb8861f...553d3f154938
      **NOTE:** This service has been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/

      Functionality will be removed from GitHub.com on January 31st, 2019.


More information about the git mailing list