[ovs-git] [openvswitch/ovs] 413c85: netdev-dpdk: Fix failure to configure flow control...

GitHub noreply at github.com
Wed Aug 8 23:17:03 UTC 2018


  Branch: refs/heads/branch-2.9
  Home:   https://github.com/openvswitch/ovs
  Commit: 413c85a243537ba06c029f5e7fecd4016af75116
      https://github.com/openvswitch/ovs/commit/413c85a243537ba06c029f5e7fecd4016af75116
  Author: Sugesh Chandran <sugesh.chandran at intel.com>
  Date:   2018-08-08 (Wed, 08 Aug 2018)

  Changed paths:
    M lib/netdev-dpdk.c

  Log Message:
  -----------
  netdev-dpdk: Fix failure to configure flow control at netdev-init.

Configuring flow control at ixgbe netdev-init is throwing error in port
start.

For eg: without this fix, user cannot configure flow control on ixgbe dpdk
port as below,

"
    ovs-vsctl add-port br0 dpdk0 -- set Interface dpdk0 type=dpdk \
  options:dpdk-devargs=0000:05:00.1 options:rx-flow-ctrl=true
"

Instead,  it must be configured as two different commands,

"
    ovs-vsctl add-port br0 dpdk0 -- set Interface dpdk0 type=dpdk \
         options:dpdk-devargs=0000:05:00.1
    ovs-vsctl set Interface dpdk0 options:rx-flow-ctrl=true
"

The DPDK ixgbe driver is now validating all the 'rte_eth_fc_conf' fields before
trying to configuring the dpdk ethdev. Hence OVS can no longer set the
'dont care' fields to just '0' as before. This commit make sure all the
'rte_eth_fc_conf' fields are populated with default values before the dev
init.

Signed-off-by: Sugesh Chandran <sugesh.chandran at intel.com>
Signed-off-by: Ian Stokes <ian.stokes at intel.com>


  Commit: 141eeeff6a08114b32ff65b17db2f912b50f321c
      https://github.com/openvswitch/ovs/commit/141eeeff6a08114b32ff65b17db2f912b50f321c
  Author: Ben Pfaff <blp at ovn.org>
  Date:   2018-08-08 (Wed, 08 Aug 2018)

  Changed paths:
    M lib/ofp-util.c

  Log Message:
  -----------
  ofp-port: Fix buffer overread parsing Intel custom statistics.

CC: Michal Weglicki <michalx.weglicki at intel.com>
Fixes: 971f4b394c6e ("netdev: Custom statistics.")
Reported-at: https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=9445
Signed-off-by: Ben Pfaff <blp at ovn.org>
Signed-off-by: Ian Stokes <ian.stokes at intel.com>


  Commit: 661b583e599e80f377c5f2fd147f330ef30514c0
      https://github.com/openvswitch/ovs/commit/661b583e599e80f377c5f2fd147f330ef30514c0
  Author: Kevin Traynor <ktraynor at redhat.com>
  Date:   2018-08-08 (Wed, 08 Aug 2018)

  Changed paths:
    M lib/netdev-dpdk.c

  Log Message:
  -----------
  netdev-dpdk: Use hex for PCI vendor ID.

Match the prefix and formatting.

Fixes: 8a9562d21a40 ("dpif-netdev: Add DPDK netdev.")
Cc: pshelar at ovn.org

Signed-off-by: Kevin Traynor <ktraynor at redhat.com>
Signed-off-by: Ian Stokes <ian.stokes at intel.com>


Compare: https://github.com/openvswitch/ovs/compare/c3a91ed557b7...661b583e599e
      **NOTE:** This service has been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/

      Functionality will be removed from GitHub.com on January 31st, 2019.


More information about the git mailing list