[ovs-git] [openvswitch/ovs] cbcf40: utilities: Fix and unify parsing of timeout option...

GitHub noreply at github.com
Wed Aug 15 18:46:46 UTC 2018


  Branch: refs/heads/master
  Home:   https://github.com/openvswitch/ovs
  Commit: cbcf40a847c0539fec36e82410f0966f13517964
      https://github.com/openvswitch/ovs/commit/cbcf40a847c0539fec36e82410f0966f13517964
  Author: Ilya Maximets <i.maximets at samsung.com>
  Date:   2018-08-15 (Wed, 15 Aug 2018)

  Changed paths:
    M ovn/utilities/ovn-nbctl.c
    M ovn/utilities/ovn-sbctl.c
    M ovsdb/ovsdb-client.c
    M tests/test-ovsdb.c
    M utilities/ovs-appctl.c
    M utilities/ovs-dpctl.c
    M utilities/ovs-ofctl.c
    M utilities/ovs-vsctl.c
    M vtep/vtep-ctl.c

  Log Message:
  -----------
  utilities: Fix and unify parsing of timeout option.

Parsing of the '--timeout' option implemented differently
for every single control utility and, which is more
important, highly inaccurate. In most cases unsigned result
of 'strtoul' stored in signed variable. Parsing failures are
not tracked. 'ovs-appctl' even uses just 'atoi' without any
checking of the argument or result.

This patch unifies the parsing by using 'str_to_uint'.

Signed-off-by: Ilya Maximets <i.maximets at samsung.com>
Signed-off-by: Ben Pfaff <blp at ovn.org>


  Commit: 9551e80befc0f8ecc5ee8a7e025147358c2753ee
      https://github.com/openvswitch/ovs/commit/9551e80befc0f8ecc5ee8a7e025147358c2753ee
  Author: Ilya Maximets <i.maximets at samsung.com>
  Date:   2018-08-15 (Wed, 15 Aug 2018)

  Changed paths:
    M NEWS
    M lib/util.c
    M lib/util.h
    M ovn/utilities/ovn-nbctl.c
    M ovn/utilities/ovn-sbctl.c
    M ovsdb/ovsdb-client.c
    M python/ovs/fatal_signal.py
    M tests/appctl.py
    M tests/atlocal.in
    M tests/test-ovsdb.c
    M tests/test-ovsdb.py
    M utilities/ovs-appctl.c
    M utilities/ovs-dpctl.c
    M utilities/ovs-ofctl.c
    M utilities/ovs-vsctl.c
    M vtep/vtep-ctl.c

  Log Message:
  -----------
  tests: Use environment variable for default timeout.

Introduce new 'OVS_CTL_TIMEOUT' environment variable
that, if set, will be used as a default timeout for
OVS control utilities. Setting it in 'atlocal.in' will
cover all the hangs inside the testsuite, even when
utils called in a subshell.

Signed-off-by: Ilya Maximets <i.maximets at samsung.com>
Signed-off-by: Ben Pfaff <blp at ovn.org>


  Commit: da229568ccc8bde5d7f6fc001c461b5e150377e3
      https://github.com/openvswitch/ovs/commit/da229568ccc8bde5d7f6fc001c461b5e150377e3
  Author: Ilya Maximets <i.maximets at samsung.com>
  Date:   2018-08-15 (Wed, 15 Aug 2018)

  Changed paths:
    M tests/ovs-macros.at

  Log Message:
  -----------
  tests: Drop setting aliases for control utils.

Not needed anymore. 'OVS_CTL_TIMEOUT' env used instead.

Signed-off-by: Ilya Maximets <i.maximets at samsung.com>
Signed-off-by: Ben Pfaff <blp at ovn.org>


Compare: https://github.com/openvswitch/ovs/compare/b302f315b38b...da229568ccc8
      **NOTE:** This service has been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/

      Functionality will be removed from GitHub.com on January 31st, 2019.


More information about the git mailing list