[ovs-git] [openvswitch/ovs] 3434d3: netdev: Retry getting interfaces on inconsistent d...

[GitHub]

  Branch: refs/heads/master
  Home:   https://github.com/openvswitch/ovs
  Commit: 3434d306866d825084d2d186d1f8dd98662ff650
      https://github.com/openvswitch/ovs/commit/3434d306866d825084d2d186d1f8dd98662ff650
  Author: Daniel Alvarez <dalvarez at redhat.com>
  Date:   2018-08-15 (Wed, 15 Aug 2018)

  Changed paths:
    M lib/netdev.c

  Log Message:
  -----------
  netdev: Retry getting interfaces on inconsistent dumps from kernel

This patch in glibc [0] is fixing a bug where we may be getting
inconsistent dumps from the kernel when listing interfaces due to
a race condition.

This could happen if we try to retrieve them while interfaces are
being added/removed from the system at the same time.
For systems running against old glibc versions, this patch is retrying
the operation up to 3 times and then proceeding by logging a
warning.

Note that 3 times should be enough to not delay the operation much
and since it's unlikely that we hit the race condition 3 times in
a row. Still, if this happened, this patch is not changing the
current behavior.

[0] https://sourceware.org/git/gitweb.cgi?p=glibc.git;h=c1f86a33ca32e26a9d6e29fc961e5ecb5e2e5eb4

Signed-off-by: Daniel Alvarez <dalvarez at redhat.com>
Signed-off-by: Jiri Benc <jbenc at redhat.com>
Co-authored-by: Jiri Benc <jbenc at redhat.com>
Signed-off-by: Ben Pfaff <blp at ovn.org>



      **NOTE:** This service has been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/

      Functionality will be removed from GitHub.com on January 31st, 2019.