[ovs-git] [openvswitch/ovs] 3d78db: ip6_gre: Fix a bug that clears address bits

GitHub noreply at github.com
Thu Aug 16 17:10:01 UTC 2018


  Branch: refs/heads/master
  Home:   https://github.com/openvswitch/ovs
  Commit: 3d78db1072f08f9dd6278cc02882b640639ac45b
      https://github.com/openvswitch/ovs/commit/3d78db1072f08f9dd6278cc02882b640639ac45b
  Author: Yifeng Sun <pkusunyifeng at gmail.com>
  Date:   2018-08-16 (Thu, 16 Aug 2018)

  Changed paths:
    M datapath/linux/compat/ip6_gre.c

  Log Message:
  -----------
  ip6_gre: Fix a bug that clears address bits

In compatible gre module, skb->cb is solely used as ovs_gso_cb.
However, IPCB(skb) also points to skb->cb. IPCB(skb)->flags overlaps
with ovs_gso_cb.tun_dst. As a result, this bug clears the 16-23 bit
in the address of ovs_gso_cb.tun_dst and causes kernel to crash.

Signed-off-by: Yifeng Sun <pkusunyifeng at gmail.com>
Signed-off-by: Ben Pfaff <blp at ovn.org>
Tested-by: Greg Rose <gvrose8192 at gmail.com>
Reviewed-by: Greg Rose <gvrose8192 at gmail.com>


  Commit: d1224d287524241bb05a0c5765e40a0cf43ea8ad
      https://github.com/openvswitch/ovs/commit/d1224d287524241bb05a0c5765e40a0cf43ea8ad
  Author: Yifeng Sun <pkusunyifeng at gmail.com>
  Date:   2018-08-16 (Thu, 16 Aug 2018)

  Changed paths:
    M tests/system-kmod-macros.at
    M tests/system-userspace-macros.at

  Log Message:
  -----------
  tests: Add two m4 functions to skip tests for certain kernel versions

Some tests depend on native Linux gre modules to setup testing environments.
However, some kernel versions require OVS to use compatible gre modules. In
this case, these tests always fail.

This patch helps to skip a test if it fails due to this reason. The new m4
functions will be used by later patches.

Signed-off-by: Yifeng Sun <pkusunyifeng at gmail.com>
Signed-off-by: Ben Pfaff <blp at ovn.org>
Tested-by: Greg Rose <gvrose8192 at gmail.com>
Reviewed-by: Greg Rose <gvrose8192 at gmail.com>


  Commit: cae92b4272a0bbaba983330371165abf8393bb2d
      https://github.com/openvswitch/ovs/commit/cae92b4272a0bbaba983330371165abf8393bb2d
  Author: Yifeng Sun <pkusunyifeng at gmail.com>
  Date:   2018-08-16 (Thu, 16 Aug 2018)

  Changed paths:
    M tests/system-traffic.at

  Log Message:
  -----------
  system-traffic: Skip 5 tunnel tests on certain kernel versions

Skip gre, erspan and ip6erspan related tests on kernel version from 3.10.x
to 4.15.x because compatible gre is used and these tests will always fail.

Signed-off-by: Yifeng Sun <pkusunyifeng at gmail.com>
Signed-off-by: Ben Pfaff <blp at ovn.org>
Tested-by: Greg Rose <gvrose8192 at gmail.com>
Reviewed-by: Greg Rose <gvrose8192 at gmail.com>


  Commit: eb27d96b41ca6425b96a0107520c4ff39ef14b8c
      https://github.com/openvswitch/ovs/commit/eb27d96b41ca6425b96a0107520c4ff39ef14b8c
  Author: Yifeng Sun <pkusunyifeng at gmail.com>
  Date:   2018-08-16 (Thu, 16 Aug 2018)

  Changed paths:
    M tests/system-traffic.at

  Log Message:
  -----------
  system-traffic: Add 5 new tunnel tests that don't need native linux modules

Introduce 5 new tests that don't require native gre or erspan tunnels but
sends simulated raw packets.

These tests are supposed to only run for kernel version from 3.10.x to 4.15.x
where compatible gre is being used by OVS kernel module.

Signed-off-by: Yifeng Sun <pkusunyifeng at gmail.com>
Signed-off-by: Ben Pfaff <blp at ovn.org>
Tested-by: Greg Rose <gvrose8192 at gmail.com>
Reviewed-by: Greg Rose <gvrose8192 at gmail.com>


Compare: https://github.com/openvswitch/ovs/compare/caa654ef4f46...eb27d96b41ca
      **NOTE:** This service has been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/

      Functionality will be removed from GitHub.com on January 31st, 2019.


More information about the git mailing list