[ovs-git] [openvswitch/ovs] ff8af9: dpif: Don't pass in '*meter_id' to meter_set comma...

GitHub noreply at github.com
Thu Aug 16 17:31:22 UTC 2018


  Branch: refs/heads/branch-2.10
  Home:   https://github.com/openvswitch/ovs
  Commit: ff8af9cbb9c312ff5046b193cd305f706f97c9c8
      https://github.com/openvswitch/ovs/commit/ff8af9cbb9c312ff5046b193cd305f706f97c9c8
  Author: Justin Pettit <jpettit at ovn.org>
  Date:   2018-08-16 (Thu, 16 Aug 2018)

  Changed paths:
    M lib/dpif-netdev.c
    M lib/dpif-netlink.c
    M lib/dpif-provider.h
    M lib/dpif.c
    M lib/dpif.h
    M ofproto/ofproto-dpif.c

  Log Message:
  -----------
  dpif: Don't pass in '*meter_id' to meter_set commands.

The original intent of the API appears to be that the underlying DPIF
implementaion would choose a local meter id.  However, neither of the
existing datapath meter implementations (userspace or Linux) implemented
that; they expected a valid meter id to be passed in, otherwise they
returned an error.  This commit follows the existing implementations and
makes the API somewhat cleaner.

Signed-off-by: Justin Pettit <jpettit at ovn.org>
Acked-by: Ben Pfaff <blp at ovn.org>


  Commit: ac07333a1c2065a3bf997029c7ac69f270578c81
      https://github.com/openvswitch/ovs/commit/ac07333a1c2065a3bf997029c7ac69f270578c81
  Author: Justin Pettit <jpettit at ovn.org>
  Date:   2018-08-16 (Thu, 16 Aug 2018)

  Changed paths:
    M lib/dpif-netlink.c

  Log Message:
  -----------
  dpif-netlink: Probe for broken Linux meter implementations.

Meter support was introduced in Linux 4.15.  In some versions of Linux
4.15, 4.16, and 4.17, there was a bug that never set the id when the
meter was created, so all meters essentially had an id of zero.  This
commit adds a probe to check for that condition and disable meters on
those kernels.

Signed-off-by: Justin Pettit <jpettit at ovn.org>
Acked-by: Ben Pfaff <blp at ovn.org>


Compare: https://github.com/openvswitch/ovs/compare/84018cce00e1...ac07333a1c20
      **NOTE:** This service has been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/

      Functionality will be removed from GitHub.com on January 31st, 2019.


More information about the git mailing list