[ovs-git] [openvswitch/ovs] fe8108: tests: Fix hash function dependencies in "tunnel -...

GitHub noreply at github.com
Tue Aug 21 23:07:09 UTC 2018


  Branch: refs/heads/master
  Home:   https://github.com/openvswitch/ovs
  Commit: fe8108c7ac196d8467322efdcc0e077f9385cf0d
      https://github.com/openvswitch/ovs/commit/fe8108c7ac196d8467322efdcc0e077f9385cf0d
  Author: Ben Pfaff <blp at ovn.org>
  Date:   2018-08-21 (Tue, 21 Aug 2018)

  Changed paths:
    M tests/tunnel.at

  Log Message:
  -----------
  tests: Fix hash function dependencies in "tunnel - ERSPAN v1/v2 metadata".

This test only worked if each OpenFlow port was assigned a particular
datapath port number: p1 to port 3, p2 to port 2, p3 and p4 to port 1.
This happened consistently on little-endian architectures because of the
use of a particular hash function, but on big-endian architectures it
failed because the hash function was different.

This commit fixes the problem by adding the non-dummy ports separately.
(Dummy ports try to take the datapath port number corresponding to their
name, when it is available.)  This does result in swapping a couple of
datapaths port numbers, so that p1 has port 1, p2 has port 2, and the
erspan ports have port 3, hence the size of the patch.

Reported-by: James Page <james.page at canonical.com>
Reported-at: https://mail.openvswitch.org/pipermail/ovs-dev/2018-August/351382.html
Signed-off-by: Ben Pfaff <blp at ovn.org>
Acked-by: William Tu <u9012063 at gmail.com>



      **NOTE:** This service has been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/

      Functionality will be removed from GitHub.com on January 31st, 2019.


More information about the git mailing list