[ovs-git] [openvswitch/ovs] aa8563: ofp-actions: Re-fix error path for parsing OpenFlo...
GitHub
noreply at github.com
Thu Aug 30 20:56:16 UTC 2018
Branch: refs/heads/branch-2.10
Home: https://github.com/openvswitch/ovs
Commit: aa8563d9a6f370c73da0e4994612208d73b8187c
https://github.com/openvswitch/ovs/commit/aa8563d9a6f370c73da0e4994612208d73b8187c
Author: Ben Pfaff <blp at ovn.org>
Date: 2018-08-30 (Thu, 30 Aug 2018)
Changed paths:
M lib/ofp-actions.c
Log Message:
-----------
ofp-actions: Re-fix error path for parsing OpenFlow actions.
A previous commit attempted to fix the error path when the actions nested
within clone provoked an error. However, this commit just introduced a new
problem in another case, since it made ofpacts_pull_openflow_actions__()
restore a previously valid pointer to data that might have been
reallocated.
This commit takes another approach. Instead of trying to restore anything
at all, it just defines ofpacts_pull_openflow_actions__() to clear the
output buffer when there's an error. It seems that this is less error
prone. Most of the callers don't care; this commit fixes up the ones that
do.
Reported-at: https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=9975
Fixes: 20cdd1dbd546 ("ofp-actions: Avoid assertion failure for clone(ct(...bad actions...)).")
Signed-off-by: Ben Pfaff <blp at ovn.org>
Tested-by: Yifeng Sun <pkusunyifeng at gmail.com>
Reviewed-by: Yifeng Sun <pkusunyifeng at gmail.com>
**NOTE:** This service has been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/
Functionality will be removed from GitHub.com on January 31st, 2019.
More information about the git
mailing list