[ovs-git] [openvswitch/ovs] f22149: tests: Don't pass TESTSUITEFLAGS while re-checking...

GitHub noreply at github.com
Tue Dec 18 23:24:05 UTC 2018


  Branch: refs/heads/master
  Home:   https://github.com/openvswitch/ovs
  Commit: f22149c5dd34b81a5d752c4a89e8ef6d7de2d44b
      https://github.com/openvswitch/ovs/commit/f22149c5dd34b81a5d752c4a89e8ef6d7de2d44b
  Author: Ilya Maximets <i.maximets at samsung.com>
  Date:   2018-12-18 (Tue, 18 Dec 2018)

  Changed paths:
    M tests/automake.mk

  Log Message:
  -----------
  tests: Don't pass TESTSUITEFLAGS while re-checking.

This fixes 'RECHECK=yes' functionality in case of configured test
range. For example, before the patch following cmdline will result in
running all of the 1000 tests re-checking in case of any failure:

  make -j8 check TESTSUITEFLAGS='1000-1999' RECHECK=yes

This happens because ranges and pattern matching options has higher
priority than the '--recheck'.
With patch, only failed tests from the range will be re-checked.

With this patch applied we're dropping support of '--verbose' and
'--trace' options while re-check, but, IMHO, these options makes
sense mostly while debugging individual tests and not much usable
while running recheck of a whole testsuite.
'--jobs' we're resetting each time anyway.

Not sure if someone overrides default '--directory'. For me it looks
not very useful. Changing the color mode also looks not much
profitable.

OTOH, re-checking the ranges or keyword matched tests is very useful,
for example, if you're trying to split up single testsuite check in
a few independent CI jobs.

Signed-off-by: Ilya Maximets <i.maximets at samsung.com>
Signed-off-by: Ben Pfaff <blp at ovn.org>


  Commit: 75d7f41d95f7af1ca1eac284339d1d893e58f370
      https://github.com/openvswitch/ovs/commit/75d7f41d95f7af1ca1eac284339d1d893e58f370
  Author: Ilya Maximets <i.maximets at samsung.com>
  Date:   2018-12-18 (Tue, 18 Dec 2018)

  Changed paths:
    M tests/automake.mk

  Log Message:
  -----------
  tests: Drop RECHECK support for valgrind tests.

valgrind tests always runs with '-d' option which breaks the
re-checking. Lets just drop the rechecking support for these
targets.

Signed-off-by: Ilya Maximets <i.maximets at samsung.com>
Signed-off-by: Ben Pfaff <blp at ovn.org>


Compare: https://github.com/openvswitch/ovs/compare/c3013fd3fddb...75d7f41d95f7
      **NOTE:** This service has been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/

      Functionality will be removed from GitHub.com on January 31st, 2019.


More information about the git mailing list