From noreply at github.com Thu Feb 1 18:12:57 2018 From: noreply at github.com (GitHub) Date: Thu, 01 Feb 2018 10:12:57 -0800 Subject: [ovs-git] [openvswitch/ovs] efefbc: ofp-actions: Make formatting and parsing functions... Message-ID: <5a7358a96988f_71a42b23f0b33c0838430@hookshot-fe-da92815.cp1-iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/openvswitch/ovs Commit: efefbcae0119b1a9d224e80ca39040c6aed58246 https://github.com/openvswitch/ovs/commit/efefbcae0119b1a9d224e80ca39040c6aed58246 Author: Ben Pfaff Date: 2018-01-31 (Wed, 31 Jan 2018) Changed paths: M include/openvswitch/ofp-actions.h M lib/ofp-actions.c M lib/ofp-parse.c M lib/ofp-print.c M ofproto/ofproto-dpif-trace.c M ofproto/ofproto-dpif-xlate.c M ofproto/ofproto.c M ovn/controller/ofctrl.c M ovn/utilities/ovn-sbctl.c M tests/test-ovn.c M utilities/ovs-ofctl.c Log Message: ----------- ofp-actions: Make formatting and parsing functions take a struct argument. An upcoming commit will add another parameter for parsing and formatting actions. It is much easier to add these parameters if they are encapsulated in a struct, so this commit first makes that change. Signed-off-by: Ben Pfaff Reviewed-by: Yifeng Sun Acked-by: Mark Michelson Commit: a203f653b1a6a2544603be00966b8d4731d91b69 https://github.com/openvswitch/ovs/commit/a203f653b1a6a2544603be00966b8d4731d91b69 Author: Ben Pfaff Date: 2018-01-31 (Wed, 31 Jan 2018) Changed paths: M include/openvswitch/ofp-util.h M lib/ofp-util.c Log Message: ----------- ofp-util: New data structure for mapping between table names and numbers. This shares the infrastructure for mapping port names and numbers. It will be used in an upcoming commit. Signed-off-by: Ben Pfaff Reviewed-by: Yifeng Sun Acked-by: Mark Michelson Commit: 4bc938ccb3124282c873084a7d11cd8bc37e27a7 https://github.com/openvswitch/ovs/commit/4bc938ccb3124282c873084a7d11cd8bc37e27a7 Author: Ben Pfaff Date: 2018-02-01 (Thu, 01 Feb 2018) Changed paths: M NEWS M include/openvswitch/ofp-actions.h M include/openvswitch/ofp-parse.h M include/openvswitch/ofp-print.h M include/openvswitch/ofp-util.h M lib/learn.c M lib/learn.h M lib/learning-switch.c M lib/ofp-actions.c M lib/ofp-parse.c M lib/ofp-print.c M lib/ofp-util.c M lib/vconn.c M ofproto/ofproto-dpif.c M ofproto/ofproto.c M ovn/controller/ofctrl.c M ovn/controller/pinctrl.c M ovn/utilities/ovn-sbctl.c M ovn/utilities/ovn-trace.c M tests/ofproto.at M utilities/ovs-ofctl.8.in M utilities/ovs-ofctl.c M utilities/ovs-testcontroller.c Log Message: ----------- Support accepting and displaying table names in OVS tools. OpenFlow has little-known support for naming tables. Open vSwitch has supported table names for ages, but it has never used or displayed them outside of commands dedicated to table manipulation. This commit adds support for table names in ovs-ofctl. When a table has a name, it displays that name in flows and actions, so that, for example, the following: table=1, arp, actions=resubmit(,2) might become: table=ingress_acl, arp, actions=resubmit(,mac_learning) given appropriately named tables. For backward compatibility, only interactive ovs-ofctl commands by default display table names; to display them in scripts, use the new --names option. This feature was inspired by a talk that Kei Nohguchi presented at Open vSwitch 2017 Fall Conference. CC: Kei Nohguchi Signed-off-by: Ben Pfaff Acked-by: Mark Michelson Reviewed-by: Yifeng Sun Compare: https://github.com/openvswitch/ovs/compare/46ab60bfe562...4bc938ccb312 From noreply at github.com Thu Feb 1 19:25:44 2018 From: noreply at github.com (GitHub) Date: Thu, 01 Feb 2018 11:25:44 -0800 Subject: [ovs-git] [openvswitch/ovs] 500db3: util: Document and rely on ovs_assert() always eva... Message-ID: <5a7369b8e2f04_10042af0c80b1c0412236d@hookshot-fe-265448d.cp1-iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/openvswitch/ovs Commit: 500db308e2704fa9fc5ff69cdcd9cb3b22116e99 https://github.com/openvswitch/ovs/commit/500db308e2704fa9fc5ff69cdcd9cb3b22116e99 Author: Ben Pfaff Date: 2018-02-01 (Thu, 01 Feb 2018) Changed paths: M include/openvswitch/util.h M lib/cmap.c M lib/conntrack.c M lib/hmapx.c M lib/odp-execute.c M lib/odp-util.c M lib/ofp-msgs.c M lib/ofp-util.c M lib/ovsdb-data.c M lib/shash.c M lib/sset.c M ofproto/ofproto-dpif-xlate.c M ovsdb/ovsdb-server.c M ovsdb/replication.c Log Message: ----------- util: Document and rely on ovs_assert() always evaluating its argument. The ovs_assert() macro always evaluates its argument, even when NDEBUG is defined so that failure is ignored. This behavior wasn't documented, and thus a lot of code didn't rely on it. This commit documents the behavior and simplifies bits of code that heretofore didn't rely on it. Signed-off-by: Ben Pfaff Reviewed-by: Yifeng Sun From noreply at github.com Thu Feb 1 19:31:16 2018 From: noreply at github.com (GitHub) Date: Thu, 01 Feb 2018 11:31:16 -0800 Subject: [ovs-git] [openvswitch/ovs] 9a3cf0: ovs-vswitchd: Fire RCU callbacks before exit to re... Message-ID: <5a736b049f193_16ad72af9e7b93c08106779@hookshot-fe-dfcc362.cp1-iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/openvswitch/ovs Commit: 9a3cf0ac3397555b38acd6ed7fed6e7eea5c0335 https://github.com/openvswitch/ovs/commit/9a3cf0ac3397555b38acd6ed7fed6e7eea5c0335 Author: Ben Pfaff Date: 2018-02-01 (Thu, 01 Feb 2018) Changed paths: M lib/ovs-rcu.c M lib/ovs-rcu.h M vswitchd/ovs-vswitchd.c Log Message: ----------- ovs-vswitchd: Fire RCU callbacks before exit to reduce memory leak warnings. ovs-vswitchd makes extensive use of RCU to defer freeing memory past the latest time that it could be in use by a thread. Until now, ovs-vswitchd has not waited for RCU callbacks to fire before exiting. This meant that in many cases, when ovs-vswitchd exits, many blocks of memory are stuck in RCU callback queues, which valgrind often reports as "possible" memory leaks. This commit adds a new function ovsrcu_exit() that waits and fires as many RCU callbacks as it reasonably can. It can only do so for the thread that calls it and the thread that calls the callbacks, but generally speaking ovs-vswitchd shuts down other threads before it exits anyway, so this is pretty good. In my testing this eliminates most valgrind warnings for tests that run ovs-vswitchd. This ought to make it easier to distinguish new leaks that are real from existing non-leaks. Signed-off-by: Ben Pfaff Acked-by: William Tu Commit: 93f558421aadcd4fc0ff758bd61612c23747c72a https://github.com/openvswitch/ovs/commit/93f558421aadcd4fc0ff758bd61612c23747c72a Author: Ben Pfaff Date: 2018-02-01 (Thu, 01 Feb 2018) Changed paths: M include/openvswitch/vlog.h M lib/vlog.c M tests/glibc.supp M vswitchd/ovs-vswitchd.c Log Message: ----------- ovs-vswitchd: Avoid or suppress memory leak warning for glibc aio. The asynchronous IO library in glibc starts threads that show up as memory leaks in valgrind. This commit attempts to avoid the warnings by flushing all the asynchronous I/O to the log file before exiting. This only does part of the job for glibc since it keeps the threads around for some undefined idle time before killing them, so in addition this commit adds a valgrind suppression to stop displaying these warnings in any case. Signed-off-by: Ben Pfaff Acked-by: William Tu Compare: https://github.com/openvswitch/ovs/compare/500db308e270...93f558421aad From noreply at github.com Thu Feb 1 19:32:53 2018 From: noreply at github.com (GitHub) Date: Thu, 01 Feb 2018 11:32:53 -0800 Subject: [ovs-git] [openvswitch/ovs] 0cca68: ovn-nbctl: update manpage for lsp-set-type. Message-ID: <5a736b6555b6_640c2adb161b7bfc8522@hookshot-fe-5a11256.cp1-iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/openvswitch/ovs Commit: 0cca6870a9d5d0a8197d52c19cd24bd3cf3852d9 https://github.com/openvswitch/ovs/commit/0cca6870a9d5d0a8197d52c19cd24bd3cf3852d9 Author: Han Zhou Date: 2018-02-01 (Thu, 01 Feb 2018) Changed paths: M ovn/utilities/ovn-nbctl.8.xml Log Message: ----------- ovn-nbctl: update manpage for lsp-set-type. Signed-off-by: Han Zhou Signed-off-by: Ben Pfaff From noreply at github.com Thu Feb 1 19:33:03 2018 From: noreply at github.com (GitHub) Date: Thu, 01 Feb 2018 11:33:03 -0800 Subject: [ovs-git] [openvswitch/ovs] 80081a: ovn-nbctl: update manpage for lsp-set-type. Message-ID: <5a736b6fc6dae_58152aae46297c04839b5@hookshot-fe-b0febf1.cp1-iad.github.net.mail> Branch: refs/heads/branch-2.9 Home: https://github.com/openvswitch/ovs Commit: 80081a8710fa1f9c56283efc79039815c0fff1db https://github.com/openvswitch/ovs/commit/80081a8710fa1f9c56283efc79039815c0fff1db Author: Han Zhou Date: 2018-02-01 (Thu, 01 Feb 2018) Changed paths: M ovn/utilities/ovn-nbctl.8.xml Log Message: ----------- ovn-nbctl: update manpage for lsp-set-type. Signed-off-by: Han Zhou Signed-off-by: Ben Pfaff From noreply at github.com Thu Feb 1 19:34:05 2018 From: noreply at github.com (GitHub) Date: Thu, 01 Feb 2018 11:34:05 -0800 Subject: [ovs-git] [openvswitch/ovs] 18b5bd: ofctrl: Remove unused declaration. Message-ID: <5a736bad1333f_5e0b2aba18875c103553e@hookshot-fe-b0febf1.cp1-iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/openvswitch/ovs Commit: 18b5bd4b31215f73c71ac30bae2274e3c9865bed https://github.com/openvswitch/ovs/commit/18b5bd4b31215f73c71ac30bae2274e3c9865bed Author: Han Zhou Date: 2018-02-01 (Thu, 01 Feb 2018) Changed paths: M ovn/controller/ofctrl.h Log Message: ----------- ofctrl: Remove unused declaration. Signed-off-by: Han Zhou Signed-off-by: Ben Pfaff From noreply at github.com Thu Feb 1 19:36:09 2018 From: noreply at github.com (GitHub) Date: Thu, 01 Feb 2018 11:36:09 -0800 Subject: [ovs-git] [openvswitch/ovs] 0506f1: xlate: fix packets loopback caused by duplicate re... Message-ID: <5a736c29a01ca_2b272ab3efe2bc1090031@hookshot-fe-6b2eebc.cp1-iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/openvswitch/ovs Commit: 0506f184c53e90ef8abf7da5ea0d82ca92bbea22 https://github.com/openvswitch/ovs/commit/0506f184c53e90ef8abf7da5ea0d82ca92bbea22 Author: Huanle Han Date: 2018-02-01 (Thu, 01 Feb 2018) Changed paths: M ofproto/ofproto-dpif-xlate.c Log Message: ----------- xlate: fix packets loopback caused by duplicate read of xcfgp. Some functions, such as xlate_normal_mcast_send_mrouters, test xbundle pointers equality to avoid sending packet back to in bundle. However, xbundle pointers port from different xcfgp for same port are inequal. This may lead to the packet loopback. This commit stores xcfgp on ctx at first and always uses the same xcfgp during one packet process period. Signed-off-by: Huanle Han Signed-off-by: Ben Pfaff From noreply at github.com Thu Feb 1 19:36:21 2018 From: noreply at github.com (GitHub) Date: Thu, 01 Feb 2018 11:36:21 -0800 Subject: [ovs-git] [openvswitch/ovs] 68f515: xlate: fix packets loopback caused by duplicate re... Message-ID: <5a736c3596aec_8b02acaf8371c14305f6@hookshot-fe-6e9b612.cp1-iad.github.net.mail> Branch: refs/heads/branch-2.9 Home: https://github.com/openvswitch/ovs Commit: 68f515ca3e955c26187b85f4907b9f1b41a0d09f https://github.com/openvswitch/ovs/commit/68f515ca3e955c26187b85f4907b9f1b41a0d09f Author: Huanle Han Date: 2018-02-01 (Thu, 01 Feb 2018) Changed paths: M ofproto/ofproto-dpif-xlate.c Log Message: ----------- xlate: fix packets loopback caused by duplicate read of xcfgp. Some functions, such as xlate_normal_mcast_send_mrouters, test xbundle pointers equality to avoid sending packet back to in bundle. However, xbundle pointers port from different xcfgp for same port are inequal. This may lead to the packet loopback. This commit stores xcfgp on ctx at first and always uses the same xcfgp during one packet process period. Signed-off-by: Huanle Han Signed-off-by: Ben Pfaff From noreply at github.com Thu Feb 1 20:53:01 2018 From: noreply at github.com (GitHub) Date: Thu, 01 Feb 2018 12:53:01 -0800 Subject: [ovs-git] [openvswitch/ovs] 10087c: netdev-dpdk: Add support for vHost dequeue zero co... Message-ID: <5a737e2dd7769_4d622ab5422b3c08350dc@hookshot-fe-7191cb1.cp1-iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/openvswitch/ovs Commit: 10087cba9deec95aaea080c49f2cbe648ebe92c8 https://github.com/openvswitch/ovs/commit/10087cba9deec95aaea080c49f2cbe648ebe92c8 Author: Ciara Loftus Date: 2018-01-31 (Wed, 31 Jan 2018) Changed paths: M Documentation/intro/install/dpdk.rst M Documentation/topics/dpdk/vhost-user.rst M NEWS M lib/netdev-dpdk.c M vswitchd/vswitch.xml Log Message: ----------- netdev-dpdk: Add support for vHost dequeue zero copy (experimental) Zero copy is disabled by default. To enable it, set the 'dq-zero-copy' option to 'true' when configuring the Interface: ovs-vsctl set Interface dpdkvhostuserclient0 options:vhost-server-path=/tmp/dpdkvhostuserclient0 options:dq-zero-copy=true When packets from a vHost device with zero copy enabled are destined for a single 'dpdk' port, the number of tx descriptors on that 'dpdk' port must be set to a smaller value. 128 is recommended. This can be achieved like so: ovs-vsctl set Interface dpdkport options:n_txq_desc=128 Note: The sum of the tx descriptors of all 'dpdk' ports the VM will send to should not exceed 128. Due to this requirement, the feature is considered 'experimental'. Testing of the patch showed a ~8% improvement when switching 512B packets between vHost devices on different VMs on the same host when zero copy was enabled on the transmitting device. Signed-off-by: Ciara Loftus Acked-by: Ilya Maximets Signed-off-by: Ian Stokes Commit: 96f2c290c1cd4aa18191d6adb93cfce3e56b18a7 https://github.com/openvswitch/ovs/commit/96f2c290c1cd4aa18191d6adb93cfce3e56b18a7 Author: Ben Pfaff Date: 2018-02-01 (Thu, 01 Feb 2018) Changed paths: M Documentation/intro/install/dpdk.rst M Documentation/topics/dpdk/vhost-user.rst M NEWS M lib/netdev-dpdk.c M vswitchd/vswitch.xml Log Message: ----------- Merge branch 'dpdk_merge' of https://github.com/istokes/ovs into HEAD Compare: https://github.com/openvswitch/ovs/compare/0506f184c53e...96f2c290c1cd From noreply at github.com Thu Feb 1 20:54:51 2018 From: noreply at github.com (GitHub) Date: Thu, 01 Feb 2018 12:54:51 -0800 Subject: [ovs-git] [openvswitch/ovs] a0b62a: netdev-dpdk: Add support for vHost dequeue zero co... Message-ID: <5a737e9bb33aa_58002b22d5961c0c48992@hookshot-fe-31feec6.cp1-iad.github.net.mail> Branch: refs/heads/branch-2.9 Home: https://github.com/openvswitch/ovs Commit: a0b62aacb5021e5a16e6a916b4add61e1b68ec01 https://github.com/openvswitch/ovs/commit/a0b62aacb5021e5a16e6a916b4add61e1b68ec01 Author: Ciara Loftus Date: 2018-01-31 (Wed, 31 Jan 2018) Changed paths: M Documentation/intro/install/dpdk.rst M Documentation/topics/dpdk/vhost-user.rst M NEWS M lib/netdev-dpdk.c M vswitchd/vswitch.xml Log Message: ----------- netdev-dpdk: Add support for vHost dequeue zero copy (experimental) Zero copy is disabled by default. To enable it, set the 'dq-zero-copy' option to 'true' when configuring the Interface: ovs-vsctl set Interface dpdkvhostuserclient0 options:vhost-server-path=/tmp/dpdkvhostuserclient0 options:dq-zero-copy=true When packets from a vHost device with zero copy enabled are destined for a single 'dpdk' port, the number of tx descriptors on that 'dpdk' port must be set to a smaller value. 128 is recommended. This can be achieved like so: ovs-vsctl set Interface dpdkport options:n_txq_desc=128 Note: The sum of the tx descriptors of all 'dpdk' ports the VM will send to should not exceed 128. Due to this requirement, the feature is considered 'experimental'. Testing of the patch showed a ~8% improvement when switching 512B packets between vHost devices on different VMs on the same host when zero copy was enabled on the transmitting device. Signed-off-by: Ciara Loftus Acked-by: Ilya Maximets Signed-off-by: Ian Stokes Commit: 5a39582caa028bd8ea50dd95548aed5a04c5ea94 https://github.com/openvswitch/ovs/commit/5a39582caa028bd8ea50dd95548aed5a04c5ea94 Author: Ben Pfaff Date: 2018-02-01 (Thu, 01 Feb 2018) Changed paths: M Documentation/intro/install/dpdk.rst M Documentation/topics/dpdk/vhost-user.rst M NEWS M lib/netdev-dpdk.c M vswitchd/vswitch.xml Log Message: ----------- Merge branch 'dpdk_merge_2_9' of https://github.com/istokes/ovs into HEAD Compare: https://github.com/openvswitch/ovs/compare/68f515ca3e95...5a39582caa02 From noreply at github.com Thu Feb 1 21:00:57 2018 From: noreply at github.com (GitHub) Date: Thu, 01 Feb 2018 13:00:57 -0800 Subject: [ovs-git] [openvswitch/ovs] fdfd3f: learn: improve test case Message-ID: <5a738009b9a22_69882afd82677c08360b@hookshot-fe-5a11256.cp1-iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/openvswitch/ovs Commit: fdfd3f7b01ef23c8b527d9e0a63d962945e7c7fd https://github.com/openvswitch/ovs/commit/fdfd3f7b01ef23c8b527d9e0a63d962945e7c7fd Author: William Tu Date: 2018-02-01 (Thu, 01 Feb 2018) Changed paths: M tests/learn.at Log Message: ----------- learn: improve test case Current learn test cases use only ovs-ofctl add/del flows. The patch add a new test case for learn with delete_learned and limit option enabled. Signed-off-by: William Tu Signed-off-by: Ben Pfaff From noreply at github.com Thu Feb 1 21:04:51 2018 From: noreply at github.com (GitHub) Date: Thu, 01 Feb 2018 13:04:51 -0800 Subject: [ovs-git] [openvswitch/ovs] da1af6: Add unixctl option for ovn-northd Message-ID: <5a7380f340db7_29e12b0ceba6bc1080061@hookshot-fe-6b2eebc.cp1-iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/openvswitch/ovs Commit: da1af6e279a438a0b5bf854731b5b3546d3a2eaf https://github.com/openvswitch/ovs/commit/da1af6e279a438a0b5bf854731b5b3546d3a2eaf Author: Venkata Anil Date: 2018-02-01 (Thu, 01 Feb 2018) Changed paths: M lib/automake.mk A lib/unixctl.xml M ovn/northd/ovn-northd.8.xml M ovn/northd/ovn-northd.c M tests/ovn-northd.at Log Message: ----------- Add unixctl option for ovn-northd Signed-off-by: Venkata Anil Signed-off-by: Ben Pfaff From noreply at github.com Thu Feb 1 21:16:19 2018 From: noreply at github.com (GitHub) Date: Thu, 01 Feb 2018 13:16:19 -0800 Subject: [ovs-git] [openvswitch/ovs] c9ccde: doc: Added OVS Conntrack tutorial Message-ID: <5a7383a35a1bd_89b2ab3861afc0c53336@hookshot-fe-6e9b612.cp1-iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/openvswitch/ovs Commit: c9ccdec7516560cc859e90ab87557600fc9bdf58 https://github.com/openvswitch/ovs/commit/c9ccdec7516560cc859e90ab87557600fc9bdf58 Author: Ashish Varma Date: 2018-02-01 (Thu, 01 Feb 2018) Changed paths: M Documentation/automake.mk M Documentation/index.rst M Documentation/tutorials/index.rst A Documentation/tutorials/ovs-conntrack.rst Log Message: ----------- doc: Added OVS Conntrack tutorial OVS supports connection tracker related match fields and actions. Added a tutorial to demonstrate the basic use cases for some of these match fields and actions. Signed-off-by: Ashish Varma Signed-off-by: Ben Pfaff From noreply at github.com Thu Feb 1 21:28:18 2018 From: noreply at github.com (GitHub) Date: Thu, 01 Feb 2018 13:28:18 -0800 Subject: [ovs-git] [openvswitch/ovs] 53d416: ovs-router: fix router entry cast Message-ID: <5a73867276ee1_71a42b23f0b33c08396c5@hookshot-fe-da92815.cp1-iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/openvswitch/ovs Commit: 53d416af570934a92d8c2f6471229599e53cbe6f https://github.com/openvswitch/ovs/commit/53d416af570934a92d8c2f6471229599e53cbe6f Author: William Tu Date: 2018-02-01 (Thu, 01 Feb 2018) Changed paths: M lib/ovs-router.c Log Message: ----------- ovs-router: fix router entry cast The offsetof(struct ovs_router_entry, cr) should always be 0, thus the else statement should never be reached. Signed-off-by: William Tu Signed-off-by: Ben Pfaff From noreply at github.com Thu Feb 1 21:37:59 2018 From: noreply at github.com (GitHub) Date: Thu, 01 Feb 2018 13:37:59 -0800 Subject: [ovs-git] [openvswitch/ovs] d1ba7d: tests: Make OVS_WAIT_UNTIL and OVS_WAIT_WHILE fail... Message-ID: <5a7388b74d44d_63312b27f2f3fc101108bb@hookshot-fe-5a11256.cp1-iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/openvswitch/ovs Commit: d1ba7d54c2b917694bbe255ad890b0140ec9c9b9 https://github.com/openvswitch/ovs/commit/d1ba7d54c2b917694bbe255ad890b0140ec9c9b9 Author: Ben Pfaff Date: 2018-02-01 (Thu, 01 Feb 2018) Changed paths: M tests/ovs-macros.at Log Message: ----------- tests: Make OVS_WAIT_UNTIL and OVS_WAIT_WHILE failures easier to debug. Until now, when OVS_WAIT_UNTIL or OVS_WAIT_WHILE ran, little information was available: usually nothing at all in the log, unless the wait failed, in which case there was a line number. This commit adds a note saying what is being waited for in any case, and a message saying that the wait failed if it does. Signed-off-by: Ben Pfaff Tested-by: Yifeng Sun Reviewed-by: Yifeng Sun From noreply at github.com Thu Feb 1 21:40:23 2018 From: noreply at github.com (GitHub) Date: Thu, 01 Feb 2018 13:40:23 -0800 Subject: [ovs-git] [openvswitch/ovs] 5ee33c: ovn-nbctl: Add QoS commands. Message-ID: <5a73894754064_8b32ae96d7adc18371f4@hookshot-fe-6e9b612.cp1-iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/openvswitch/ovs Commit: 5ee33cbdceb042d18416900061329f25e04f98a4 https://github.com/openvswitch/ovs/commit/5ee33cbdceb042d18416900061329f25e04f98a4 Author: Guoshuai Li Date: 2018-02-01 (Thu, 01 Feb 2018) Changed paths: M ovn/utilities/ovn-nbctl.8.xml M ovn/utilities/ovn-nbctl.c M tests/ovn-nbctl.at M tests/ovn.at Log Message: ----------- ovn-nbctl: Add QoS commands. This patch provides the command line to add/delete/list QoS rule on the logical switch. Signed-off-by: Guoshuai Li Signed-off-by: Ben Pfaff From noreply at github.com Thu Feb 1 21:47:23 2018 From: noreply at github.com (GitHub) Date: Thu, 01 Feb 2018 13:47:23 -0800 Subject: [ovs-git] [openvswitch/ovs] 98f2d3: debian: Do not modify pre-existing defaults file Message-ID: <5a738aeb896ff_11662af323873c14521fc@hookshot-fe-2cc8887.cp1-iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/openvswitch/ovs Commit: 98f2d36d2394bfa6f9717fc5c91db2921092464f https://github.com/openvswitch/ovs/commit/98f2d36d2394bfa6f9717fc5c91db2921092464f Author: Frode Nordahl Date: 2018-02-01 (Thu, 01 Feb 2018) Changed paths: M debian/openvswitch-switch.postinst Log Message: ----------- debian: Do not modify pre-existing defaults file Currently, on installation or upgrade the openvswitch-switch deb package will in some circumstances modify a pre-existing /etc/default/openvswitch-switch configuration file. This does not play well with modeling and configuration management tools and may lead to unnecessary restarts of the openvswitch-switch service after the initial restart done as part of the package upgrade. As restarting the openvswitch-switch affects the datapath this is something we should try to avoid. I also believe the current behaviour to be in conflict with best practices set out in the config files section of the [Debian Policy](https://www.debian.org/doc/debian-policy/#s-config-files). This commit addresses this by removing the part of the postinst script that attempts to append missing documentation parts of the template and leaves the installed defaults file alone when it exists. Fixes: 0aaa379d99f4 ("Debian packaging: Add several new settings to /etc/default/openflow-switch.") Signed-off-by: Frode Nordahl Reported-at: https://github.com/openvswitch/ovs-issues/issues/137 Signed-off-by: Ben Pfaff From noreply at github.com Thu Feb 1 21:49:02 2018 From: noreply at github.com (GitHub) Date: Thu, 01 Feb 2018 13:49:02 -0800 Subject: [ovs-git] [openvswitch/ovs] 17c8fb: AUTHORS: Add Frode Nordahl Branch: refs/heads/master Home: https://github.com/openvswitch/ovs Commit: 17c8fb0fe3388a0dd3c2f5a545ca8bd87dbdc9a8 https://github.com/openvswitch/ovs/commit/17c8fb0fe3388a0dd3c2f5a545ca8bd87dbdc9a8 Author: Ben Pfaff Date: 2018-02-01 (Thu, 01 Feb 2018) Changed paths: M AUTHORS.rst Log Message: ----------- AUTHORS: Add Frode Nordahl . Signed-off-by: Ben Pfaff From noreply at github.com Thu Feb 1 21:58:39 2018 From: noreply at github.com (GitHub) Date: Thu, 01 Feb 2018 13:58:39 -0800 Subject: [ovs-git] [openvswitch/ovs] bfa909: ofproto-dpif: Delete system tunnel interface when ... Message-ID: <5a738d8f4718d_13c22b07da669c181135ac@hookshot-fe-265448d.cp1-iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/openvswitch/ovs Commit: bfa90988d09100e88240a28421eb272e040ac162 https://github.com/openvswitch/ovs/commit/bfa90988d09100e88240a28421eb272e040ac162 Author: juyan at redhat.com Date: 2018-02-01 (Thu, 01 Feb 2018) Changed paths: M ofproto/ofproto-dpif.c Log Message: ----------- ofproto-dpif: Delete system tunnel interface when remove ovs bridge When a user adds the first tunnel of a given type (e.g. the first VXLAN tunnel) to an OVS bridge, OVS adds a vport of the same type to the kernel datapath that backs the bridge. There is the corresponding expectation that, when the last tunnel of that type is removed from the OVS bridges, OVS would remove the vport that represents it from the backing kernel datapath, but OVS was not doing that. This commit fixes the problem. There is not any major concern about the lingering tunnel interface, but it's cleaner to delete it. Fixes: 921c370a9df5 ("dpif-netlink: Probe for out-of-tree tunnels, decides used interface") Signed-off-by: JunhanYan Signed-off-by: Ben Pfaff From noreply at github.com Thu Feb 1 22:14:52 2018 From: noreply at github.com (GitHub) Date: Thu, 01 Feb 2018 14:14:52 -0800 Subject: [ovs-git] [openvswitch/ovs] 79feb3: AUTHORS: Add JunhanYan . Message-ID: <5a73915c34437_5ed02afd38ce9c0c89922@hookshot-fe-b0febf1.cp1-iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/openvswitch/ovs Commit: 79feb3b0de83932c6cbf761d70051330db4d07f7 https://github.com/openvswitch/ovs/commit/79feb3b0de83932c6cbf761d70051330db4d07f7 Author: Ben Pfaff Date: 2018-02-01 (Thu, 01 Feb 2018) Changed paths: M AUTHORS.rst Log Message: ----------- AUTHORS: Add JunhanYan . Signed-off-by: Ben Pfaff From noreply at github.com Fri Feb 2 00:32:40 2018 From: noreply at github.com (GitHub) Date: Thu, 01 Feb 2018 16:32:40 -0800 Subject: [ovs-git] [openvswitch/ovs] 1050f2: ovn-northd: Do not add lflows in lr_in_arp_resolve... Message-ID: <5a73b1a8dc463_2e912b1483d63c0c66871@hookshot-fe-6b2eebc.cp1-iad.github.net.mail> Branch: refs/heads/branch-2.8 Home: https://github.com/openvswitch/ovs Commit: 1050f2e8952fccde3d594aeb78597f536e7b9df8 https://github.com/openvswitch/ovs/commit/1050f2e8952fccde3d594aeb78597f536e7b9df8 Author: Numan Siddique Date: 2018-02-01 (Thu, 01 Feb 2018) Changed paths: M ovn/northd/ovn-northd.c M tests/ovn.at Log Message: ----------- ovn-northd: Do not add lflows in lr_in_arp_resolve stage for disabled logical ports ovn-northd is adding the below logical flow for a disabled logical port (with mac M and IP 'A') table=6 (lr_in_arp_resolve ), match=(outport == "lrp-port" && reg0 == 'A'), action=(eth.dst = 'M'; next;) In the case of openstack load balancer 'octavia' service, it creates logical ports 'P1' (M1 IP1) and 'P2' (M2 IP2). It then disables logical port P2 and adds IP2 to P1 - (M1 IP1 IP2). When another port tries to reach IP2, it doesn't get delivered to port P1 because of the above flow. Signed-off-by: Numan Siddique Signed-off-by: Ben Pfaff From noreply at github.com Fri Feb 2 20:49:59 2018 From: noreply at github.com (GitHub) Date: Fri, 02 Feb 2018 12:49:59 -0800 Subject: [ovs-git] [openvswitch/ovs] c4d9f9: datapath-windows: Refactor conntrack code. Message-ID: <5a74cef79e981_52fb2b05efd8fc143439d@hookshot-fe-7191cb1.cp1-iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/openvswitch/ovs Commit: c4d9f9319f1a7956b7b308f65ba57995c5d93c92 https://github.com/openvswitch/ovs/commit/c4d9f9319f1a7956b7b308f65ba57995c5d93c92 Author: Anand Kumar Date: 2018-02-02 (Fri, 02 Feb 2018) Changed paths: M datapath-windows/ovsext/Conntrack-nat.c M datapath-windows/ovsext/Conntrack.c M datapath-windows/ovsext/Conntrack.h Log Message: ----------- datapath-windows: Refactor conntrack code. Some of the functions and code are refactored so that new conntrack lock can be implemented Signed-off-by: Anand Kumar Acked-by: Alin Gabriel Serdean Signed-off-by: Alin Gabriel Serdean Commit: dea3880466200603cfe64ad21ab6a9d4687c505d https://github.com/openvswitch/ovs/commit/dea3880466200603cfe64ad21ab6a9d4687c505d Author: Anand Kumar Date: 2018-02-02 (Fri, 02 Feb 2018) Changed paths: M datapath-windows/ovsext/Conntrack.c Log Message: ----------- datapath-windows: Add a global level RW lock for NAT Currently NAT module relies on the existing conntrack lock. This patch provides a basic lock implementation for NAT module in conntrack. Signed-off-by: Anand Kumar Acked-by: Alin Gabriel Serdean Signed-off-by: Alin Gabriel Serdean Commit: b0b5ab8bbac73d1f430405c0a76cbc05f619f15a https://github.com/openvswitch/ovs/commit/b0b5ab8bbac73d1f430405c0a76cbc05f619f15a Author: Anand Kumar Date: 2018-02-02 (Fri, 02 Feb 2018) Changed paths: M datapath-windows/ovsext/Conntrack-nat.c M datapath-windows/ovsext/Conntrack.c M datapath-windows/ovsext/Conntrack.h Log Message: ----------- datapath-windows: Optimize conntrack lock implementation. Currently, there is one global lock for conntrack module, which protects conntrack entries and conntrack table. All the NAT operations are performed holding this lock. This becomes inefficient, as the number of conntrack entries grow. With new implementation, we will have two PNDIS_RW_LOCK_EX locks in conntrack. 1. ovsCtBucketLock - one rw lock per bucket of the conntrack table, which is shared by all the ct entries that belong to the same bucket. 2. lock - a rw lock in OVS_CT_ENTRY structure that protects the members of conntrack entry. Also, OVS_CT_ENTRY structure will have a lock reference(bucketLockRef) to the corresponding OvsCtBucketLock of conntrack table. We need this reference to retrieve ovsCtBucketLock from ct entry for delete operation. Signed-off-by: Anand Kumar Acked-by: Alin Gabriel Serdean Signed-off-by: Alin Gabriel Serdean Compare: https://github.com/openvswitch/ovs/compare/79feb3b0de83...b0b5ab8bbac7 From noreply at github.com Fri Feb 2 21:50:48 2018 From: noreply at github.com (GitHub) Date: Fri, 02 Feb 2018 13:50:48 -0800 Subject: [ovs-git] [openvswitch/ovs] 6c5c38: ovn-controller: Document southbound database use a... Message-ID: <5a74dd38959b3_779f2ad80c7ddc007962f@hookshot-fe-da92815.cp1-iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/openvswitch/ovs Commit: 6c5c38ced4d126f6f99181156aee4316eeed429a https://github.com/openvswitch/ovs/commit/6c5c38ced4d126f6f99181156aee4316eeed429a Author: Ben Pfaff Date: 2018-02-02 (Fri, 02 Feb 2018) Changed paths: M ovn/controller/ovn-controller.8.xml Log Message: ----------- ovn-controller: Document southbound database use and graceful termination. A lot of people seem to think that "kill" gracefully terminates ovn-controller, but it doesn't, so this documentation at least provides something to point to. Signed-off-by: Ben Pfaff Acked-by: Han Zhou From noreply at github.com Fri Feb 2 22:28:44 2018 From: noreply at github.com (GitHub) Date: Fri, 02 Feb 2018 14:28:44 -0800 Subject: [ovs-git] [openvswitch/ovs] e50ed5: ovn-controller: Process logical flow matches befor... Message-ID: <5a74e61c93ed4_5f552afea5f79bfc1156b6@hookshot-fe-b0febf1.cp1-iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/openvswitch/ovs Commit: e50ed58a1f4218a905cde2bcd87132c2c8e70fd3 https://github.com/openvswitch/ovs/commit/e50ed58a1f4218a905cde2bcd87132c2c8e70fd3 Author: Guoshuai Li Date: 2018-02-02 (Fri, 02 Feb 2018) Changed paths: M ovn/controller/lflow.c M tests/ovn.at Log Message: ----------- ovn-controller: Process logical flow matches before actions. Otherwise, when the match field has "is_chassis_resident", and the match is not actually resident, and the action has meter or group, the group/meter ID is assigned even though it will never be used. Signed-off-by: Guoshuai Li Signed-off-by: Ben Pfaff From noreply at github.com Fri Feb 2 22:52:23 2018 From: noreply at github.com (GitHub) Date: Fri, 02 Feb 2018 14:52:23 -0800 Subject: [ovs-git] [openvswitch/ovs] 85dd5f: datapath-windows: Add trace level logs in conntrac... Message-ID: <5a74eba73e2e5_65142ab62cc73c0838834@hookshot-fe-265448d.cp1-iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/openvswitch/ovs Commit: 85dd5f5dfefaa0ff20657560685e48fc66275ce6 https://github.com/openvswitch/ovs/commit/85dd5f5dfefaa0ff20657560685e48fc66275ce6 Author: Anand Kumar Date: 2018-02-03 (Sat, 03 Feb 2018) Changed paths: M datapath-windows/ovsext/Conntrack-icmp.c M datapath-windows/ovsext/Conntrack-tcp.c M datapath-windows/ovsext/Conntrack.c Log Message: ----------- datapath-windows: Add trace level logs in conntrack for invalid ct state. Signed-off-by: Anand Kumar Acked-by: Alin Gabriel Serdean Signed-off-by: Alin Gabriel Serdean From noreply at github.com Mon Feb 5 17:12:15 2018 From: noreply at github.com (GitHub) Date: Mon, 05 Feb 2018 09:12:15 -0800 Subject: [ovs-git] [openvswitch/ovs] b4e1bf: util: Use lookup table to optimize hexit_value(). Message-ID: <5a78906f8241a_72352b011b1edc04709e3@hookshot-fe-6b2eebc.cp1-iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/openvswitch/ovs Commit: b4e1bfd722436874beb119289a4251f68cfb9461 https://github.com/openvswitch/ovs/commit/b4e1bfd722436874beb119289a4251f68cfb9461 Author: Ben Pfaff Date: 2018-02-05 (Mon, 05 Feb 2018) Changed paths: M lib/util.c M lib/util.h Log Message: ----------- util: Use lookup table to optimize hexit_value(). Daniel Alvarez Sanchez reported a significant overall speedup in ovn-northd due to a similar patch. Reported-by: Daniel Alvarez Sanchez Reported-at: https://mail.openvswitch.org/pipermail/ovs-discuss/2018-February/046120.html Signed-off-by: Ben Pfaff Acked-by: Daniel Alvarez Reviewed-by: Yifeng Sun Signed-off-by: Ben Pfaff From noreply at github.com Mon Feb 5 17:18:52 2018 From: noreply at github.com (GitHub) Date: Mon, 05 Feb 2018 09:18:52 -0800 Subject: [ovs-git] [openvswitch/ovs] 8e8b56: Makefile.am: Use correct path separator for Window... Message-ID: <5a7891fc44c98_2fc02b19adcadc0c3607a@hookshot-fe-265448d.cp1-iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/openvswitch/ovs Commit: 8e8b56d098e73d4b84b304f54afab561614930f9 https://github.com/openvswitch/ovs/commit/8e8b56d098e73d4b84b304f54afab561614930f9 Author: Shashank Ram Date: 2018-02-05 (Mon, 05 Feb 2018) Changed paths: M Makefile.am Log Message: ----------- Makefile.am: Use correct path separator for Windows Signed-off-by: Shashank Ram Signed-off-by: Ben Pfaff From noreply at github.com Mon Feb 5 17:19:14 2018 From: noreply at github.com (GitHub) Date: Mon, 05 Feb 2018 09:19:14 -0800 Subject: [ovs-git] [openvswitch/ovs] 2b766a: Makefile.am: Use correct path separator for Window... Message-ID: <5a78921225efb_5eab2b102d403c0c79419@hookshot-fe-32b5f5b.cp1-iad.github.net.mail> Branch: refs/heads/branch-2.9 Home: https://github.com/openvswitch/ovs Commit: 2b766a03f2516b6d950c3e71b52eab4c52840fa4 https://github.com/openvswitch/ovs/commit/2b766a03f2516b6d950c3e71b52eab4c52840fa4 Author: Shashank Ram Date: 2018-02-05 (Mon, 05 Feb 2018) Changed paths: M Makefile.am Log Message: ----------- Makefile.am: Use correct path separator for Windows Signed-off-by: Shashank Ram Signed-off-by: Ben Pfaff From noreply at github.com Mon Feb 5 17:38:45 2018 From: noreply at github.com (GitHub) Date: Mon, 05 Feb 2018 09:38:45 -0800 Subject: [ovs-git] [openvswitch/ovs] e8e1a4: netdev-linux: Report netdev change events when mac... Message-ID: <5a7896a551fcf_4ab72af2bae67bfc81910@hookshot-fe-7191cb1.cp1-iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/openvswitch/ovs Commit: e8e1a4097434114b07c57d183daf617fc2998675 https://github.com/openvswitch/ovs/commit/e8e1a4097434114b07c57d183daf617fc2998675 Author: Tonghao Zhang Date: 2018-02-05 (Mon, 05 Feb 2018) Changed paths: M lib/netdev-linux.c M lib/netlink-notifier.c M lib/netlink-notifier.h M lib/rtnetlink.c M lib/rtnetlink.h Log Message: ----------- netdev-linux: Report netdev change events when mac changed. When mac addr of ports on bridge has been changed, for example, $ ip link set dev eth0 address 00:11:22:33:44:55 we should reconfigure the datapath id and mac addr of local port. But now openvswitch dont do that as expected. A simple example of how to reproduce it: $ ovs-vsctl add-br br0 $ ifconfig br0 # for example, mac is c6:c6:d7:46:b4:4b $ ip link set dev br0 address 00:11:22:33:44:55 $ ifconfig br0 # mac of br0 will be 00:11:22:33:44:55 then repeat: $ ip link set dev br0 address 00:11:22:33:44:55 $ ifconfig br0 # mac of br0 will be c6:c6:d7:46:b4:4b This patch reports the mac changed event when ports changed, then openvswitch will reconfigure the datapath id and mac addr of local port. Signed-off-by: Tonghao Zhang Signed-off-by: Ben Pfaff From noreply at github.com Mon Feb 5 17:39:08 2018 From: noreply at github.com (GitHub) Date: Mon, 05 Feb 2018 09:39:08 -0800 Subject: [ovs-git] [openvswitch/ovs] 91eb0b: netdev-linux: Report netdev change events when mac... Message-ID: <5a7896bc9b408_77322ae27b8ddc08631d0@hookshot-fe-cace476.cp1-iad.github.net.mail> Branch: refs/heads/branch-2.9 Home: https://github.com/openvswitch/ovs Commit: 91eb0b1aab2f0b4dccfccf11bfb955d2efa638be https://github.com/openvswitch/ovs/commit/91eb0b1aab2f0b4dccfccf11bfb955d2efa638be Author: Tonghao Zhang Date: 2018-02-05 (Mon, 05 Feb 2018) Changed paths: M lib/netdev-linux.c M lib/netlink-notifier.c M lib/netlink-notifier.h M lib/rtnetlink.c M lib/rtnetlink.h Log Message: ----------- netdev-linux: Report netdev change events when mac changed. When mac addr of ports on bridge has been changed, for example, $ ip link set dev eth0 address 00:11:22:33:44:55 we should reconfigure the datapath id and mac addr of local port. But now openvswitch dont do that as expected. A simple example of how to reproduce it: $ ovs-vsctl add-br br0 $ ifconfig br0 # for example, mac is c6:c6:d7:46:b4:4b $ ip link set dev br0 address 00:11:22:33:44:55 $ ifconfig br0 # mac of br0 will be 00:11:22:33:44:55 then repeat: $ ip link set dev br0 address 00:11:22:33:44:55 $ ifconfig br0 # mac of br0 will be c6:c6:d7:46:b4:4b This patch reports the mac changed event when ports changed, then openvswitch will reconfigure the datapath id and mac addr of local port. Signed-off-by: Tonghao Zhang Signed-off-by: Ben Pfaff From noreply at github.com Tue Feb 6 16:31:37 2018 From: noreply at github.com (GitHub) Date: Tue, 06 Feb 2018 08:31:37 -0800 Subject: [ovs-git] [openvswitch/ovs] db5c4c: datapath-windows: Allow compiling all targets usin... Message-ID: <5a79d86974958_5bf52ab226df7c1435331@hookshot-fe-2cc8887.cp1-iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/openvswitch/ovs Commit: db5c4c74506ae91a4bafbe129378f6117e694fca https://github.com/openvswitch/ovs/commit/db5c4c74506ae91a4bafbe129378f6117e694fca Author: Shashank Ram Date: 2018-02-06 (Tue, 06 Feb 2018) Changed paths: M datapath-windows/Package/package.VcxProj M datapath-windows/ovsext/ovsext.vcxproj Log Message: ----------- datapath-windows: Allow compiling all targets using SDK 10.0 Previously, Win8/8.1 targets would use SDK8.1. However, its recommended to use the newer SDK as newer VS versions typically drop support for older SDKs later on. This patch adds support to compile all targets (Win8/8.1/10) using the 10.0 SDK. Note that his patch does not drop support for older SDKs. Signed-off-by: Shashank Ram Acked-by: Alin Gabriel Serdean Signed-off-by: Alin Gabriel Serdean Commit: 845e688435a38670f1364e322a39d0ff3bd87604 https://github.com/openvswitch/ovs/commit/845e688435a38670f1364e322a39d0ff3bd87604 Author: Shashank Ram Date: 2018-02-06 (Tue, 06 Feb 2018) Changed paths: M Makefile.am Log Message: ----------- datapath-windows: Specify platform arch during compilation Newer compilers expect the platorm architecture to be passed. Signed-off-by: Shashank Ram Acked-by: Alin Gabriel Serdean Signed-off-by: Alin Gabriel Serdean Compare: https://github.com/openvswitch/ovs/compare/e8e1a4097434...845e688435a3 From noreply at github.com Tue Feb 6 18:27:19 2018 From: noreply at github.com (GitHub) Date: Tue, 06 Feb 2018 10:27:19 -0800 Subject: [ovs-git] [openvswitch/ovs] 489998: Remove last mentions of 'facet' from comments. Message-ID: <5a79f38710a24_796e2aea08789c1476522@hookshot-fe-31feec6.cp1-iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/openvswitch/ovs Commit: 48999827e6b6021c610cc64a43c4835c9a3b2b9d https://github.com/openvswitch/ovs/commit/48999827e6b6021c610cc64a43c4835c9a3b2b9d Author: Ben Pfaff Date: 2018-02-06 (Tue, 06 Feb 2018) Changed paths: M lib/odp-util.h M ofproto/ofproto-dpif-mirror.c Log Message: ----------- Remove last mentions of 'facet' from comments. How did these survive so long?! OVS hasn't had facets since 2013. Signed-off-by: Ben Pfaff Commit: 687bafbb8a798dc0b2f65a14669501c44c01c0ed https://github.com/openvswitch/ovs/commit/687bafbb8a798dc0b2f65a14669501c44c01c0ed Author: Ben Pfaff Date: 2018-02-06 (Tue, 06 Feb 2018) Changed paths: M lib/odp-util.h M ofproto/ofproto-dpif-upcall.c Log Message: ----------- ofproto-dpif-upcall: Slow path flows that datapath can't fully match. In the OVS architecture, when a datapath doesn't have a match for a packet, it sends the packet and the flow that it extracted from it to userspace. Userspace then examines the packet and the flow and compares them. Commonly, the flow is the same as what userspace expects, given the packet, but there are two other possibilities: - The flow lacks one or more fields that userspace expects to be there, that is, the datapath doesn't understand or parse them but userspace does. This is, for example, what would happen if current OVS userspace, which understands and extracts TCP flags, were to be paired with an older OVS kernel module, which does not. Internally OVS uses the name ODP_FIT_TOO_LITTLE for this situation. - The flow includes fields that userspace does not know about, that is, the datapath understands and parses them but userspace does not. This is, for example, what would happen if an old OVS userspace that does not understand or extract TCP flags, were to be paired with a recent OVS kernel module that does. Internally, OVS uses the name ODP_FIT_TOO_MUCH for this situation. The latter is not a big deal and OVS doesn't have to do much to cope with it. The former is more of a problem. When the datapath can't match on all the fields that OVS supports, it means that OVS can't safely install a flow at all, other than one that directs packets to the slow path. Otherwise, if OVS did install a flow, it could match a packet that does not match the flow that OVS intended to match and could cause the wrong behavior. Somehow, this nuance was lost a long time. From about 2013 until today, it seems that OVS has ignored ODP_FIT_TOO_LITTLE. Instead, it happily installs a flow regardless of whether the datapath can actually fully match it. I imagine that this is rarely a problem because most of the time the datapath and userspace are well matched, but it is still an important problem to fix. This commit fixes it, by forcing flows into the slow path when the datapath cannot match specifically enough. CC: Ethan Jackson Fixes: e79a6c833e0d ("ofproto: Handle flow installation and eviction in upcall.") Reported-by: Huanle Han Reported-at: https://mail.openvswitch.org/pipermail/ovs-dev/2018-January/343665.html Signed-off-by: Ben Pfaff Commit: c645550bb2498fb3816b6a39b22bffeb3154dca3 https://github.com/openvswitch/ovs/commit/c645550bb2498fb3816b6a39b22bffeb3154dca3 Author: Ben Pfaff Date: 2018-02-06 (Tue, 06 Feb 2018) Changed paths: M lib/odp-util.c Log Message: ----------- odp-util: Always report ODP_FIT_TOO_LITTLE for IGMP. OVS datapaths don't understand or parse IGMP fields, but OVS userspace does, so this commit updates odp_flow_key_to_flow() to report that properly to the caller. Reported-by: Huanle Han Reported-at: https://mail.openvswitch.org/pipermail/ovs-dev/2018-January/343665.html Signed-off-by: Ben Pfaff Compare: https://github.com/openvswitch/ovs/compare/845e688435a3...c645550bb249 From noreply at github.com Tue Feb 6 19:15:29 2018 From: noreply at github.com (GitHub) Date: Tue, 06 Feb 2018 11:15:29 -0800 Subject: [ovs-git] [openvswitch/ovs] 303566: jsonrpc: Add comment for jsonrpc_msg_to_json(). Message-ID: <5a79fed1ac163_7f352afbc3d49c047482b@hookshot-fe-cace476.cp1-iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/openvswitch/ovs Commit: 303566c564778a9048afff397b9cae45f3b85410 https://github.com/openvswitch/ovs/commit/303566c564778a9048afff397b9cae45f3b85410 Author: Ben Pfaff Date: 2018-02-06 (Tue, 06 Feb 2018) Changed paths: M lib/jsonrpc.c Log Message: ----------- jsonrpc: Add comment for jsonrpc_msg_to_json(). >From a glance at the prototype it wasn't obvious that it destroyed its argument. Signed-off-by: Ben Pfaff From noreply at github.com Tue Feb 6 19:17:16 2018 From: noreply at github.com (GitHub) Date: Tue, 06 Feb 2018 11:17:16 -0800 Subject: [ovs-git] [openvswitch/ovs] f15a23: json: Make it safe to pass null pointers to json_e... Message-ID: <5a79ff3c39f17_48112b0c17d7fc1469545@hookshot-fe-6e9b612.cp1-iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/openvswitch/ovs Commit: f15a2320cc0f51876e7d144d8cb2688141e6e44e https://github.com/openvswitch/ovs/commit/f15a2320cc0f51876e7d144d8cb2688141e6e44e Author: Ben Pfaff Date: 2018-02-06 (Tue, 06 Feb 2018) Changed paths: M lib/json.c Log Message: ----------- json: Make it safe to pass null pointers to json_equal(). Signed-off-by: Ben Pfaff Reviewed-by: Yifeng Sun Acked-by: Justin Pettit From noreply at github.com Tue Feb 6 19:25:38 2018 From: noreply at github.com (GitHub) Date: Tue, 06 Feb 2018 11:25:38 -0800 Subject: [ovs-git] [openvswitch/ovs] c55d0b: ovsdb-client: Add --timeout option. Message-ID: <5a7a0132d3edb_75b82af0a9ab9c0c20548@hookshot-fe-d2afb11.cp1-iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/openvswitch/ovs Commit: c55d0b7b74a772b6696d2efeeb5ecaae637822a0 https://github.com/openvswitch/ovs/commit/c55d0b7b74a772b6696d2efeeb5ecaae637822a0 Author: Ben Pfaff Date: 2018-02-06 (Tue, 06 Feb 2018) Changed paths: M NEWS M ovsdb/ovsdb-client.1.in M ovsdb/ovsdb-client.c M tests/ovs-macros.at Log Message: ----------- ovsdb-client: Add --timeout option. Signed-off-by: Ben Pfaff Reviewed-by: Yifeng Sun Acked-by: Justin Pettit From noreply at github.com Tue Feb 6 19:35:10 2018 From: noreply at github.com (GitHub) Date: Tue, 06 Feb 2018 11:35:10 -0800 Subject: [ovs-git] [openvswitch/ovs] bf2972: ovs-vsctl: Remove superfluous OVS_VSCTL_CLEANUP fr... Message-ID: <5a7a036e4a973_71fa2b12db3f3c0c52913@hookshot-fe-88eb02d.cp1-iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/openvswitch/ovs Commit: bf297226b1a7c4b47a37d538170f06a4d9bcd7f6 https://github.com/openvswitch/ovs/commit/bf297226b1a7c4b47a37d538170f06a4d9bcd7f6 Author: Ben Pfaff Date: 2018-02-06 (Tue, 06 Feb 2018) Changed paths: M tests/ovs-vsctl.at Log Message: ----------- ovs-vsctl: Remove superfluous OVS_VSCTL_CLEANUP from tests. Since on_exit was introduced a long, long time ago, it has no longer been necessary to have individual calls to OVS_VSCTL_CLEANUP sprinkled everywhere in the test code. This change makes the tests easier to read. Signed-off-by: Ben Pfaff Tested-by: Yifeng Sun Reviewed-by: Yifeng Sun Commit: ee9ccf935ea40c16070c451d0ac27dcdf9b07039 https://github.com/openvswitch/ovs/commit/ee9ccf935ea40c16070c451d0ac27dcdf9b07039 Author: Ben Pfaff Date: 2018-02-06 (Tue, 06 Feb 2018) Changed paths: M tests/ovs-vsctl.at M tests/ovs-xapi-sync.at Log Message: ----------- ovs-vsctl: Use default socket name in tests. By using the default socket name "db.sock", instead of "socket", we can avoid passing --db=unix:socket to all the ovs-vsctl invocations, which is kind of nice. Signed-off-by: Ben Pfaff Tested-by: Yifeng Sun Reviewed-by: Yifeng Sun Commit: 8e98556b56ddb46be5e3269fd918a626ed86de43 https://github.com/openvswitch/ovs/commit/8e98556b56ddb46be5e3269fd918a626ed86de43 Author: Ben Pfaff Date: 2018-02-06 (Tue, 06 Feb 2018) Changed paths: M NEWS Log Message: ----------- NEWS: Consolidate ovs-vswitchd sections and fix indentation. Signed-off-by: Ben Pfaff Tested-by: Yifeng Sun Reviewed-by: Yifeng Sun Commit: ec5ef1cf552583bfd015f3f1a69ac6556506152a https://github.com/openvswitch/ovs/commit/ec5ef1cf552583bfd015f3f1a69ac6556506152a Author: Ben Pfaff Date: 2018-02-06 (Tue, 06 Feb 2018) Changed paths: M NEWS M tests/ovs-vsctl.at M utilities/ovs-vsctl.8.in M utilities/ovs-vsctl.c Log Message: ----------- ovs-vsctl: Add commands "add-bond-iface" and "del-bond-iface". It was not too hard to build these commands using the database commands, but a few people have asked for them over the years, so here they are. Signed-off-by: Ben Pfaff Tested-by: Yifeng Sun Reviewed-by: Yifeng Sun Compare: https://github.com/openvswitch/ovs/compare/c55d0b7b74a7...ec5ef1cf5525 From noreply at github.com Tue Feb 6 23:58:06 2018 From: noreply at github.com (GitHub) Date: Tue, 06 Feb 2018 15:58:06 -0800 Subject: [ovs-git] [openvswitch/ovs] 30ef3c: ofproto-dpif-xlate: add uuid to xports Message-ID: <5a7a410ee802d_45cc2b23053bfbfc48779@hookshot-fe-6e9b612.cp1-iad.github.net.mail> Branch: refs/heads/branch-2.8 Home: https://github.com/openvswitch/ovs Commit: 30ef3cdd95209a9b3b3268cd7c8c1b5bd28dc406 https://github.com/openvswitch/ovs/commit/30ef3cdd95209a9b3b3268cd7c8c1b5bd28dc406 Author: Zoltan Balogh Date: 2018-02-06 (Tue, 06 Feb 2018) Changed paths: M ofproto/ofproto-dpif-xlate.c Log Message: ----------- ofproto-dpif-xlate: add uuid to xports This should make possible to look up xport by UUID and will be used by a later commit. Signed-off-by: Zoltan Balogh Signed-off-by: Ben Pfaff Commit: 0d87cb5b6757b81be4951c6aae20eb0c38999216 https://github.com/openvswitch/ovs/commit/0d87cb5b6757b81be4951c6aae20eb0c38999216 Author: Zoltan Balogh Date: 2018-02-06 (Tue, 06 Feb 2018) Changed paths: M ofproto/ofproto-dpif-rid.c M ofproto/ofproto-dpif-rid.h M ofproto/ofproto-dpif-xlate.c M ofproto/ofproto-dpif-xlate.h M tests/packet-type-aware.at Log Message: ----------- xlate: fix xport lookup for recirc Xlate_lookup and xlate_lookup_ofproto_() provides in_port and ofproto based on xport determined using flow, which is extracted from packet. The lookup can happen due to recirculation as well. It can happen, that packet_type has been modified during xlate before recirculation is triggered, so the lookup fails or delivers wrong xport. This can be worked around by propagating xport to ctx->xin after the very first lookup and store it in frozen state of the recirculation. So, when lookup is performed due to recirculation, the xport can be retrieved from the frozen state. The packet-type-aware unit tests are updated with a new one to verify this behavior. Signed-off-by: Zoltan Balogh CC: Jan Scheurich Fixes: beb75a40fdc2 ("userspace: Switching of L3 packets in L2 pipeline") Signed-off-by: Ben Pfaff Compare: https://github.com/openvswitch/ovs/compare/1050f2e8952f...0d87cb5b6757 From noreply at github.com Wed Feb 7 18:28:26 2018 From: noreply at github.com (GitHub) Date: Wed, 07 Feb 2018 10:28:26 -0800 Subject: [ovs-git] [openvswitch/ovs] 34533d: expr: Fix some bad naming. Message-ID: <5a7b454aaf432_27412b01cbc77c143549c@hookshot-fe-265448d.cp1-iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/openvswitch/ovs Commit: 34533d372dc1a3c9bbbcd6b8ca51c81287e996f5 https://github.com/openvswitch/ovs/commit/34533d372dc1a3c9bbbcd6b8ca51c81287e996f5 Author: Ben Pfaff Date: 2018-02-07 (Wed, 07 Feb 2018) Changed paths: M ovn/lib/expr.c Log Message: ----------- expr: Fix some bad naming. expr_is_cmp() was badly named because it didn't just check for whether its argument was an EXPR_T_CMP node. struct expr_sort's 'relop' member was badly named because it wasn't a relational operator, it was a symbol. This commit improves both names. Signed-off-by: Ben Pfaff Acked-by: Numan Siddique Commit: 582bd869af597538d76fa08627bafa510dacf492 https://github.com/openvswitch/ovs/commit/582bd869af597538d76fa08627bafa510dacf492 Author: Ben Pfaff Date: 2018-02-07 (Wed, 07 Feb 2018) Changed paths: M ovn/lib/expr.c Log Message: ----------- expr: Make expr_sort() always yield an expr that satisfies invariants. Expressions of type EXPR_T_AND are supposed to follow an invariant that they have at least 2 clauses, but expr_sort() did not always follow that; for example, applying it to (x[0] == 1 && x[1] == 1) yielded the 1-child EXPR_T_AND expression x[0..1] == 3. This commit fixes the problem. I don't know of any externally visible negative consequences for this problem, but it made the code harder to reason about. Signed-off-by: Ben Pfaff Acked-by: Numan Siddique Commit: eb202465d278ef8c0a277ebfeae5dd04f8c48242 https://github.com/openvswitch/ovs/commit/eb202465d278ef8c0a277ebfeae5dd04f8c48242 Author: Ben Pfaff Date: 2018-02-07 (Wed, 07 Feb 2018) Changed paths: M tests/test-ovn.c Log Message: ----------- expr: Add additional invariant check in test. Signed-off-by: Ben Pfaff Acked-by: Numan Siddique Compare: https://github.com/openvswitch/ovs/compare/ec5ef1cf5525...eb202465d278 From noreply at github.com Wed Feb 7 18:46:12 2018 From: noreply at github.com (GitHub) Date: Wed, 07 Feb 2018 10:46:12 -0800 Subject: [ovs-git] [openvswitch/ovs] 364294: datapath: ether: add NSH ethertype Message-ID: <5a7b4974bba0b_6df22b0f7b543c00236a4@hookshot-fe-6b2eebc.cp1-iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/openvswitch/ovs Commit: 364294983d7de98151b50c225709c7a4ec2a4aa0 https://github.com/openvswitch/ovs/commit/364294983d7de98151b50c225709c7a4ec2a4aa0 Author: Yi Yang Date: 2018-02-07 (Wed, 07 Feb 2018) Changed paths: M datapath/linux/compat/include/linux/if_ether.h Log Message: ----------- datapath: ether: add NSH ethertype Upstream commit: commit 155e6f649757c902901e599c268f8b575ddac1f8 Author: Jiri Benc Date: Mon Aug 28 21:43:21 2017 +0200 ether: add NSH ethertype The NSH draft says: An IEEE EtherType, 0x894F, has been allocated for NSH. Signed-off-by: Jiri Benc Signed-off-by: David S. Miller Signed-off-by: Yi Yang Signed-off-by: Ben Pfaff Reviewed-by: Greg Rose Commit: b80837ac4cb9b9be8763f45d42a4769107f2e80d https://github.com/openvswitch/ovs/commit/b80837ac4cb9b9be8763f45d42a4769107f2e80d Author: Yi Yang Date: 2018-02-07 (Wed, 07 Feb 2018) Changed paths: M datapath/linux/Modules.mk A datapath/linux/compat/include/net/tun_proto.h M datapath/linux/compat/include/net/vxlan.h M datapath/linux/compat/vxlan.c Log Message: ----------- datapath: vxlan: factor out VXLAN-GPE next protocol Upstream commit: commit fa20e0e32cb3dfc1760b6254b64977f2fb5bd851 Author: Jiri Benc Date: Mon Aug 28 21:43:22 2017 +0200 vxlan: factor out VXLAN-GPE next protocol The values are shared between VXLAN-GPE and NSH. Originally probably by coincidence but I notified both working groups about this last year and they seem to keep the values in sync since then. Hopefully they'll get a single IANA registry for the values, too. (I asked them for that.) Factor out the code to be shared by the NSH implementation. NSH and MPLS values are added in this patch, too. For MPLS, the drafts incorrectly assign only a single value, while we have two MPLS ethertypes. I raised the problem with both groups. For now, I assume the value is for unicast. Signed-off-by: Jiri Benc Signed-off-by: David S. Miller Signed-off-by: Yi Yang Signed-off-by: Ben Pfaff Reviewed-by: Greg Rose Commit: 730f499dd209dacb5f2869dd0abbfe3b9efaa3d5 https://github.com/openvswitch/ovs/commit/730f499dd209dacb5f2869dd0abbfe3b9efaa3d5 Author: Yi Yang Date: 2018-02-07 (Wed, 07 Feb 2018) Changed paths: M datapath/linux/Modules.mk A datapath/linux/compat/include/net/nsh.h Log Message: ----------- datapath: net: add NSH header structures and helpers Upstream commit: commit 1f0b7744c50573df464ca33d8e5275be509f852b Author: Yi Yang Date: Mon Aug 28 21:43:23 2017 +0200 net: add NSH header structures and helpers NSH (Network Service Header)[1] is a new protocol for service function chaining, it can be handled as a L3 protocol like IPv4 and IPv6, Eth + NSH + Inner packet or VxLAN-gpe + NSH + Inner packet are two typical use cases. This patch adds NSH header structures and helpers for NSH GSO support and Open vSwitch NSH support. [1] https://datatracker.ietf.org/doc/draft-ietf-sfc-nsh/ [Jiri: added nsh_hdr() helper and renamed the header struct to "struct nshhdr" to match the usual pattern. Removed packet type defines, these are now shared with VXLAN-GPE.] Signed-off-by: Yi Yang Signed-off-by: Jiri Benc Signed-off-by: David S. Miller Signed-off-by: Yi Yang Signed-off-by: Ben Pfaff Reviewed-by: Greg Rose Commit: 907c26a89d424eacc7eb150dc1d02f45029b844b https://github.com/openvswitch/ovs/commit/907c26a89d424eacc7eb150dc1d02f45029b844b Author: Yi Yang Date: 2018-02-07 (Wed, 07 Feb 2018) Changed paths: M datapath/Modules.mk M datapath/datapath.c M datapath/linux/compat/include/net/nsh.h Log Message: ----------- datapath: nsh: add GSO support Upstream commit: commit c411ed854584a71b0e86ac3019b60e4789d88086 Author: Jiri Benc Date: Mon Aug 28 21:43:24 2017 +0200 nsh: add GSO support Add a new nsh/ directory. It currently holds only GSO functions but more will come: in particular, code shared by openvswitch and tc to manipulate NSH headers. For now, assume there's no hardware support for NSH segmentation. We can always introduce netdev->nsh_features later. Signed-off-by: Jiri Benc Signed-off-by: David S. Miller Signed-off-by: Yi Yang Signed-off-by: Ben Pfaff Reviewed-by: Greg Rose Commit: 96b82f6d5f1166895fa2ec0b3ba0215e94691855 https://github.com/openvswitch/ovs/commit/96b82f6d5f1166895fa2ec0b3ba0215e94691855 Author: Yi Yang Date: 2018-02-07 (Wed, 07 Feb 2018) Changed paths: M NEWS M acinclude.m4 M datapath/actions.c M datapath/flow.c M datapath/flow.h M datapath/flow_netlink.c M datapath/flow_netlink.h M datapath/linux/compat/include/linux/netdevice.h M datapath/linux/compat/include/linux/openvswitch.h M datapath/linux/compat/include/net/nsh.h A datapath/nsh.c Log Message: ----------- datapath: enable NSH support Upstream commit: commit b2d0f5d5dc53532e6f07bc546a476a55ebdfe0f3 Author: Yi Yang Date: Tue Nov 7 21:07:02 2017 +0800 openvswitch: enable NSH support OVS master and 2.8 branch has merged NSH userspace patch series, this patch is to enable NSH support in kernel data path in order that OVS can support NSH in compat mode by porting this. Signed-off-by: Yi Yang Acked-by: Jiri Benc Acked-by: Eric Garver Acked-by: Pravin Shelar Signed-off-by: David S. Miller Signed-off-by: Yi Yang Signed-off-by: Ben Pfaff Reviewed-by: Greg Rose Compare: https://github.com/openvswitch/ovs/compare/eb202465d278...96b82f6d5f11 From noreply at github.com Thu Feb 8 16:49:33 2018 From: noreply at github.com (GitHub) Date: Thu, 08 Feb 2018 08:49:33 -0800 Subject: [ovs-git] [openvswitch/ovs] 56e432: datapath: ether: add NSH ethertype Message-ID: <5a7c7f9d5e2ba_3b52b131728bc0c424c3@hookshot-fe-d252ca1.cp1-iad.github.net.mail> Branch: refs/heads/branch-2.9 Home: https://github.com/openvswitch/ovs Commit: 56e432df3ddd16d948cc79eaac1641175010fa0d https://github.com/openvswitch/ovs/commit/56e432df3ddd16d948cc79eaac1641175010fa0d Author: Yi Yang Date: 2018-02-08 (Thu, 08 Feb 2018) Changed paths: M datapath/linux/compat/include/linux/if_ether.h Log Message: ----------- datapath: ether: add NSH ethertype Upstream commit: commit 155e6f649757c902901e599c268f8b575ddac1f8 Author: Jiri Benc Date: Mon Aug 28 21:43:21 2017 +0200 ether: add NSH ethertype The NSH draft says: An IEEE EtherType, 0x894F, has been allocated for NSH. Signed-off-by: Jiri Benc Signed-off-by: David S. Miller Signed-off-by: Yi Yang Signed-off-by: Ben Pfaff Reviewed-by: Greg Rose Commit: 2fd50461d1e7f4d4827bb9fea4db4442e1c28d91 https://github.com/openvswitch/ovs/commit/2fd50461d1e7f4d4827bb9fea4db4442e1c28d91 Author: Yi Yang Date: 2018-02-08 (Thu, 08 Feb 2018) Changed paths: M datapath/linux/Modules.mk A datapath/linux/compat/include/net/tun_proto.h M datapath/linux/compat/include/net/vxlan.h M datapath/linux/compat/vxlan.c Log Message: ----------- datapath: vxlan: factor out VXLAN-GPE next protocol Upstream commit: commit fa20e0e32cb3dfc1760b6254b64977f2fb5bd851 Author: Jiri Benc Date: Mon Aug 28 21:43:22 2017 +0200 vxlan: factor out VXLAN-GPE next protocol The values are shared between VXLAN-GPE and NSH. Originally probably by coincidence but I notified both working groups about this last year and they seem to keep the values in sync since then. Hopefully they'll get a single IANA registry for the values, too. (I asked them for that.) Factor out the code to be shared by the NSH implementation. NSH and MPLS values are added in this patch, too. For MPLS, the drafts incorrectly assign only a single value, while we have two MPLS ethertypes. I raised the problem with both groups. For now, I assume the value is for unicast. Signed-off-by: Jiri Benc Signed-off-by: David S. Miller Signed-off-by: Yi Yang Signed-off-by: Ben Pfaff Reviewed-by: Greg Rose Commit: 56350a941302c01485751a81544d3fdd0e6897c2 https://github.com/openvswitch/ovs/commit/56350a941302c01485751a81544d3fdd0e6897c2 Author: Yi Yang Date: 2018-02-08 (Thu, 08 Feb 2018) Changed paths: M datapath/linux/Modules.mk A datapath/linux/compat/include/net/nsh.h Log Message: ----------- datapath: net: add NSH header structures and helpers Upstream commit: commit 1f0b7744c50573df464ca33d8e5275be509f852b Author: Yi Yang Date: Mon Aug 28 21:43:23 2017 +0200 net: add NSH header structures and helpers NSH (Network Service Header)[1] is a new protocol for service function chaining, it can be handled as a L3 protocol like IPv4 and IPv6, Eth + NSH + Inner packet or VxLAN-gpe + NSH + Inner packet are two typical use cases. This patch adds NSH header structures and helpers for NSH GSO support and Open vSwitch NSH support. [1] https://datatracker.ietf.org/doc/draft-ietf-sfc-nsh/ [Jiri: added nsh_hdr() helper and renamed the header struct to "struct nshhdr" to match the usual pattern. Removed packet type defines, these are now shared with VXLAN-GPE.] Signed-off-by: Yi Yang Signed-off-by: Jiri Benc Signed-off-by: David S. Miller Signed-off-by: Yi Yang Signed-off-by: Ben Pfaff Reviewed-by: Greg Rose Commit: c0b6f594de86067860e1bbcd9612232ef777ce8d https://github.com/openvswitch/ovs/commit/c0b6f594de86067860e1bbcd9612232ef777ce8d Author: Yi Yang Date: 2018-02-08 (Thu, 08 Feb 2018) Changed paths: M datapath/Modules.mk M datapath/datapath.c M datapath/linux/compat/include/net/nsh.h Log Message: ----------- datapath: nsh: add GSO support Upstream commit: commit c411ed854584a71b0e86ac3019b60e4789d88086 Author: Jiri Benc Date: Mon Aug 28 21:43:24 2017 +0200 nsh: add GSO support Add a new nsh/ directory. It currently holds only GSO functions but more will come: in particular, code shared by openvswitch and tc to manipulate NSH headers. For now, assume there's no hardware support for NSH segmentation. We can always introduce netdev->nsh_features later. Signed-off-by: Jiri Benc Signed-off-by: David S. Miller Signed-off-by: Yi Yang Signed-off-by: Ben Pfaff Reviewed-by: Greg Rose Commit: ca800314e8107177b1e9aa9e64718da563b4a622 https://github.com/openvswitch/ovs/commit/ca800314e8107177b1e9aa9e64718da563b4a622 Author: Yi Yang Date: 2018-02-08 (Thu, 08 Feb 2018) Changed paths: M NEWS M acinclude.m4 M datapath/actions.c M datapath/flow.c M datapath/flow.h M datapath/flow_netlink.c M datapath/flow_netlink.h M datapath/linux/compat/include/linux/netdevice.h M datapath/linux/compat/include/linux/openvswitch.h M datapath/linux/compat/include/net/nsh.h A datapath/nsh.c Log Message: ----------- datapath: enable NSH support Upstream commit: commit b2d0f5d5dc53532e6f07bc546a476a55ebdfe0f3 Author: Yi Yang Date: Tue Nov 7 21:07:02 2017 +0800 openvswitch: enable NSH support OVS master and 2.8 branch has merged NSH userspace patch series, this patch is to enable NSH support in kernel data path in order that OVS can support NSH in compat mode by porting this. Signed-off-by: Yi Yang Acked-by: Jiri Benc Acked-by: Eric Garver Acked-by: Pravin Shelar Signed-off-by: David S. Miller Signed-off-by: Yi Yang Signed-off-by: Ben Pfaff Reviewed-by: Greg Rose Compare: https://github.com/openvswitch/ovs/compare/91eb0b1aab2f...ca800314e810 From noreply at github.com Fri Feb 9 17:34:50 2018 From: noreply at github.com (GitHub) Date: Fri, 09 Feb 2018 09:34:50 -0800 Subject: [ovs-git] [openvswitch/ovs] f8e79d: ovn: Allow DNS lookups over IPv6 Message-ID: <5a7ddbba6ff90_39192ad75ad35c146056d@hookshot-fe-da92815.cp1-iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/openvswitch/ovs Commit: f8e79d82bd7b158b27791f648a1509adc9994efe https://github.com/openvswitch/ovs/commit/f8e79d82bd7b158b27791f648a1509adc9994efe Author: Mark Michelson Date: 2018-02-09 (Fri, 09 Feb 2018) Changed paths: M ovn/controller/pinctrl.c M tests/ovn.at Log Message: ----------- ovn: Allow DNS lookups over IPv6 There was a bug in DNS request handling where the incoming packet was assumed to be IPv4. The result was that for the outgoing packet, we would attempt to write the IPv4 checksum and total length into what was actually an IPv6 header. This resulted in the source IPv6 address getting corrupted. Later, the source and destination IPv6 addresses would get swapped, resulting in the DNS response being sent to a nonsense destination. With this change, we check the ethertype of the packet to determine what l3 information to write, and where to write it. A test is also included that verifies that this works as expected. Reported-at: https://bugzilla.redhat.com/show_bug.cgi?id=1539608 Signed-off-by: Mark Michelson Signed-off-by: Ben Pfaff From noreply at github.com Fri Feb 9 17:35:00 2018 From: noreply at github.com (GitHub) Date: Fri, 09 Feb 2018 09:35:00 -0800 Subject: [ovs-git] [openvswitch/ovs] 0451eb: ovn: Allow DNS lookups over IPv6 Message-ID: <5a7ddbc42db2_5bce2aef1d0b1bfc531f9@hookshot-fe-32b5f5b.cp1-iad.github.net.mail> Branch: refs/heads/branch-2.9 Home: https://github.com/openvswitch/ovs Commit: 0451eb1ebbe67483dc375e540d6beb480bf408ef https://github.com/openvswitch/ovs/commit/0451eb1ebbe67483dc375e540d6beb480bf408ef Author: Mark Michelson Date: 2018-02-09 (Fri, 09 Feb 2018) Changed paths: M ovn/controller/pinctrl.c M tests/ovn.at Log Message: ----------- ovn: Allow DNS lookups over IPv6 There was a bug in DNS request handling where the incoming packet was assumed to be IPv4. The result was that for the outgoing packet, we would attempt to write the IPv4 checksum and total length into what was actually an IPv6 header. This resulted in the source IPv6 address getting corrupted. Later, the source and destination IPv6 addresses would get swapped, resulting in the DNS response being sent to a nonsense destination. With this change, we check the ethertype of the packet to determine what l3 information to write, and where to write it. A test is also included that verifies that this works as expected. Reported-at: https://bugzilla.redhat.com/show_bug.cgi?id=1539608 Signed-off-by: Mark Michelson Signed-off-by: Ben Pfaff From noreply at github.com Fri Feb 9 17:59:54 2018 From: noreply at github.com (GitHub) Date: Fri, 09 Feb 2018 09:59:54 -0800 Subject: [ovs-git] [openvswitch/ovs] 995933: ovn: Allow DNS lookups over IPv6 Message-ID: <5a7de19af2319_6c3d2adc1a18dc085425e@hookshot-fe-88eb02d.cp1-iad.github.net.mail> Branch: refs/heads/branch-2.8 Home: https://github.com/openvswitch/ovs Commit: 995933f224d3f682541ef060a949986620df5f05 https://github.com/openvswitch/ovs/commit/995933f224d3f682541ef060a949986620df5f05 Author: Mark Michelson Date: 2018-02-09 (Fri, 09 Feb 2018) Changed paths: M ovn/controller/pinctrl.c M tests/ovn.at Log Message: ----------- ovn: Allow DNS lookups over IPv6 There was a bug in DNS request handling where the incoming packet was assumed to be IPv4. The result was that for the outgoing packet, we would attempt to write the IPv4 checksum and total length into what was actually an IPv6 header. This resulted in the source IPv6 address getting corrupted. Later, the source and destination IPv6 addresses would get swapped, resulting in the DNS response being sent to a nonsense destination. With this change, we check the ethertype of the packet to determine what l3 information to write, and where to write it. A test is also included that verifies that this works as expected. Reported-at: https://bugzilla.redhat.com/show_bug.cgi?id=1539608 Signed-off-by: Mark Michelson Signed-off-by: Ben Pfaff From noreply at github.com Sat Feb 10 06:57:35 2018 From: noreply at github.com (GitHub) Date: Fri, 09 Feb 2018 22:57:35 -0800 Subject: [ovs-git] [openvswitch/ovs] 94c0d9: tests: Don't include a newline in ovs_fatal() call... Message-ID: <5a7e97df1df61_49862ae53334bc1c116630@hookshot-fe-6e9b612.cp1-iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/openvswitch/ovs Commit: 94c0d9f74053bb0d8c55669509ac7678cc08e9c4 https://github.com/openvswitch/ovs/commit/94c0d9f74053bb0d8c55669509ac7678cc08e9c4 Author: Justin Pettit Date: 2018-02-09 (Fri, 09 Feb 2018) Changed paths: M tests/test-rstp.c M tests/test-stp.c Log Message: ----------- tests: Don't include a newline in ovs_fatal() calls. Signed-off-by: Justin Pettit Acked-by: Ben Pfaff From noreply at github.com Mon Feb 12 08:30:51 2018 From: noreply at github.com (GitHub) Date: Mon, 12 Feb 2018 00:30:51 -0800 Subject: [ovs-git] [openvswitch/ovs] 36d352: datapath: Fix netdev_master_upper_dev_link for 4.1... Message-ID: <5a8150bbe82_4a2b2b00ca183c10128356@hookshot-fe-7191cb1.cp1-iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/openvswitch/ovs Commit: 36d3520b5fd0f23656a387f16d7091f368b95f33 https://github.com/openvswitch/ovs/commit/36d3520b5fd0f23656a387f16d7091f368b95f33 Author: Greg Rose Date: 2018-02-12 (Mon, 12 Feb 2018) Changed paths: M acinclude.m4 M datapath/linux/compat/include/linux/netdevice.h M datapath/vport-netdev.c Log Message: ----------- datapath: Fix netdev_master_upper_dev_link for 4.14 An extended netlink ack has been added for 4.14 - add compat layer changes so that it compiles for all kernels up to and including 4.14. Signed-off-by: Greg Rose Acked-by: Pravin B Shelar Commit: b66081f33c426de2553c13171621ffdbc1bfd6c0 https://github.com/openvswitch/ovs/commit/b66081f33c426de2553c13171621ffdbc1bfd6c0 Author: Greg Rose Date: 2018-02-12 (Mon, 12 Feb 2018) Changed paths: M datapath/linux/compat/ip_gre.c M datapath/linux/compat/ip_output.c Log Message: ----------- compat: Do not include headers when not compiling If the entire file is not going to be compiled because OVS is using upstream tunnel support then also don't bother pulling in the headers. Signed-off-by: Greg Rose Acked-by: Pravin B Shelar Commit: 64d8cb7295fa9480991b8fcacb574cb151bb9b2e https://github.com/openvswitch/ovs/commit/64d8cb7295fa9480991b8fcacb574cb151bb9b2e Author: Greg Rose Date: 2018-02-12 (Mon, 12 Feb 2018) Changed paths: M datapath/linux/compat/include/net/inet_frag.h Log Message: ----------- compat:inet_frag.h: Check for frag_percpu_counter_batch Fix up the compat layer to check for frag_percpu_counter_batch and if not present then use atomic_sub and atomic_add as per the backport in the 3.16.50 LTS kernel. Signed-off-by: Greg Rose Acked-by: Pravin B Shelar Commit: b81164d9e5a72fbd02a58107501ef6c7dea71db9 https://github.com/openvswitch/ovs/commit/b81164d9e5a72fbd02a58107501ef6c7dea71db9 Author: Florian Westphal Date: 2018-02-12 (Mon, 12 Feb 2018) Changed paths: M datapath/conntrack.c Log Message: ----------- datapath: conntrack: make protocol tracker pointers const Upstream commit: commit b3480fe059ac9121b5714205b4ddae14b59ef4be Author: Florian Westphal Date: Sat Aug 12 00:57:08 2017 +0200 netfilter: conntrack: make protocol tracker pointers const Doesn't change generated code, but will make it easier to eventually make the actual trackers themselvers const. Signed-off-by: Florian Westphal Signed-off-by: Pablo Neira Ayuso Cc: Florian Westphal Signed-off-by: Greg Rose Acked-by: Pravin B Shelar Commit: 969b8e6b81e2d89f0e3d2212ef9937a1ac63fe72 https://github.com/openvswitch/ovs/commit/969b8e6b81e2d89f0e3d2212ef9937a1ac63fe72 Author: Greg Rose Date: 2018-02-12 (Mon, 12 Feb 2018) Changed paths: M datapath/datapath.c M datapath/linux/compat/stt.c Log Message: ----------- datapath: Fix SKB_GSO_UDP usage Using SKB_GSO_UDP breaks the compilation on Linux 4.14. Check for the HAVE_SKB_GSO_UDP compiler #define. Signed-off-by: Greg Rose Acked-by: Pravin B Shelar Commit: a61fbfa459b808f99983fe68701f3973b366ad04 https://github.com/openvswitch/ovs/commit/a61fbfa459b808f99983fe68701f3973b366ad04 Author: Greg Rose Date: 2018-02-12 (Mon, 12 Feb 2018) Changed paths: M acinclude.m4 M datapath/linux/compat/include/linux/compiler-gcc.h Log Message: ----------- compat: Fix compiler headers Since Linux kernel upstream commit d15155824c50 ("linux/compiler.h: Split into compiler.h and compiler_types.h") this error check for the gcc compiler header is no longer valid. Remove so that openvswitch builds for linux kernels 4.14.8 and since. Signed-off-by: Greg Rose Acked-by: Pravin B Shelar Commit: 497895ca85395d686d2a694a8ef7c1739f86e28e https://github.com/openvswitch/ovs/commit/497895ca85395d686d2a694a8ef7c1739f86e28e Author: Christophe JAILLET Date: 2018-02-12 (Mon, 12 Feb 2018) Changed paths: M datapath/datapath.c Log Message: ----------- datapath: Fix an error handling path in 'ovs_nla_init_match_and_action() Upstream commit: commit 5829e62ac17a40ab08c1b905565604a4b5fa7af6 Author: Christophe JAILLET Date: Mon Sep 11 21:56:20 2017 +0200 openvswitch: Fix an error handling path in 'ovs_nla_init_match_and_action()' All other error handling paths in this function go through the 'error' label. This one should do the same. Fixes: 9cc9a5cb176c ("datapath: Avoid using stack larger than 1024.") Signed-off-by: Christophe JAILLET Acked-by: Pravin B Shelar Signed-off-by: David S. Miller Cc: Christophe JAILLET Fixes: 850c2a4d1a ("datapath: Avoid using stack larger than 1024.") Signed-off-by: Greg Rose Acked-by: Pravin B Shelar Commit: f54a7a5d5633105b9c89443defe7ae097d31a923 https://github.com/openvswitch/ovs/commit/f54a7a5d5633105b9c89443defe7ae097d31a923 Author: Gustavo A. R. Silva Date: 2018-02-12 (Mon, 12 Feb 2018) Changed paths: M datapath/datapath.c M datapath/linux/compat/stt.c Log Message: ----------- datapath: fix data type in queue_gso_packets Upstream commit: commit 2734166e89639c973c6e125ac8bcfc2d9db72b70 Author: Gustavo A. R. Silva Date: Sat Nov 25 13:14:40 2017 -0600 net: openvswitch: datapath: fix data type in queue_gso_packets gso_type is being used in binary AND operations together with SKB_GSO_UDP. The issue is that variable gso_type is of type unsigned short and SKB_GSO_UDP expands to more than 16 bits: SKB_GSO_UDP = 1 << 16 this makes any binary AND operation between gso_type and SKB_GSO_UDP to be always zero, hence making some code unreachable and likely causing undesired behavior. Fix this by changing the data type of variable gso_type to unsigned int. Addresses-Coverity-ID: 1462223 Fixes: 0c19f846d582 ("net: accept UFO datagrams from tuntap and packet") Signed-off-by: Gustavo A. R. Silva Acked-by: Willem de Bruijn Signed-off-by: David S. Miller While backporting this I found another couple of instances of the same issue so I fixed them up as well. Cc: Gustavo A. R. Silva Signed-off-by: Greg Rose Acked-by: Pravin B Shelar Commit: 55053088ff5117cb2649ae9ec10a6ffb119c230c https://github.com/openvswitch/ovs/commit/55053088ff5117cb2649ae9ec10a6ffb119c230c Author: zhangliping Date: 2018-02-12 (Mon, 12 Feb 2018) Changed paths: M datapath/flow_netlink.c Log Message: ----------- datapath: fix the incorrect flow action alloc size Upstream commit: commit 67c8d22a73128ff910e2287567132530abcf5b71 Author: zhangliping Date: Sat Nov 25 22:02:12 2017 +0800 openvswitch: fix the incorrect flow action alloc size If we want to add a datapath flow, which has more than 500 vxlan outputs' action, we will get the following error reports: openvswitch: netlink: Flow action size 32832 bytes exceeds max openvswitch: netlink: Flow action size 32832 bytes exceeds max openvswitch: netlink: Actions may not be safe on all matching packets ... ... It seems that we can simply enlarge the MAX_ACTIONS_BUFSIZE to fix it, but this is not the root cause. For example, for a vxlan output action, we need about 60 bytes for the nlattr, but after it is converted to the flow action, it only occupies 24 bytes. This means that we can still support more than 1000 vxlan output actions for a single datapath flow under the the current 32k max limitation. So even if the nla_len(attr) is larger than MAX_ACTIONS_BUFSIZE, we shouldn't report EINVAL and keep it move on, as the judgement can be done by the reserve_sfa_size. Signed-off-by: zhangliping Acked-by: Pravin B Shelar Signed-off-by: David S. Miller Cc: zhangliping Signed-off-by: Greg Rose Acked-by: Pravin B Shelar Commit: 6deeb55a3ec9357c42c21ca1582668136ed264c4 https://github.com/openvswitch/ovs/commit/6deeb55a3ec9357c42c21ca1582668136ed264c4 Author: Arnd Bergmann Date: 2018-02-12 (Mon, 12 Feb 2018) Changed paths: M acinclude.m4 M datapath/flow.c M datapath/linux/Modules.mk A datapath/linux/compat/include/linux/timekeeping.h Log Message: ----------- datapath: use ktime_get_ts64() instead of ktime_get_ts() Upstream commit: commit 311af51dcb5629f04976a8e451673f77e3301041 Author: Arnd Bergmann Date: Mon Nov 27 12:41:38 2017 +0100 openvswitch: use ktime_get_ts64() instead of ktime_get_ts() timespec is deprecated because of the y2038 overflow, so let's convert this one to ktime_get_ts64(). The code is already safe even on 32-bit architectures, since it uses monotonic times. On 64-bit architectures, nothing changes, while on 32-bit architectures this avoids one type conversion. Signed-off-by: Arnd Bergmann Signed-off-by: David S. Miller Additional compatability check for ktime_get_ts64() exists or not. If not, then just continue using ktime_get_ts(). I added a new compatability header file "timekeeping.h". Cc: Arnd Bergmann Signed-off-by: Greg Rose Acked-by: Pravin B Shelar Compare: https://github.com/openvswitch/ovs/compare/94c0d9f74053...6deeb55a3ec9 From noreply at github.com Mon Feb 12 08:31:32 2018 From: noreply at github.com (GitHub) Date: Mon, 12 Feb 2018 00:31:32 -0800 Subject: [ovs-git] [openvswitch/ovs] 86a94a: datapath: Fix netdev_master_upper_dev_link for 4.1... Message-ID: <5a8150e41dfab_71c62acebea97c04670ce@hookshot-fe-6b2eebc.cp1-iad.github.net.mail> Branch: refs/heads/branch-2.9 Home: https://github.com/openvswitch/ovs Commit: 86a94a96163ccd5d02cd3a3d6bcba2800109add4 https://github.com/openvswitch/ovs/commit/86a94a96163ccd5d02cd3a3d6bcba2800109add4 Author: Greg Rose Date: 2018-02-12 (Mon, 12 Feb 2018) Changed paths: M acinclude.m4 M datapath/linux/compat/include/linux/netdevice.h M datapath/vport-netdev.c Log Message: ----------- datapath: Fix netdev_master_upper_dev_link for 4.14 An extended netlink ack has been added for 4.14 - add compat layer changes so that it compiles for all kernels up to and including 4.14. Signed-off-by: Greg Rose Acked-by: Pravin B Shelar Commit: 47df6fb4e0ed5e230117f613b42bca75cbefdb5c https://github.com/openvswitch/ovs/commit/47df6fb4e0ed5e230117f613b42bca75cbefdb5c Author: Greg Rose Date: 2018-02-12 (Mon, 12 Feb 2018) Changed paths: M datapath/linux/compat/ip_gre.c M datapath/linux/compat/ip_output.c Log Message: ----------- compat: Do not include headers when not compiling If the entire file is not going to be compiled because OVS is using upstream tunnel support then also don't bother pulling in the headers. Signed-off-by: Greg Rose Acked-by: Pravin B Shelar Commit: 2070685328a6a8993565dd9c0797480d1607d7c0 https://github.com/openvswitch/ovs/commit/2070685328a6a8993565dd9c0797480d1607d7c0 Author: Greg Rose Date: 2018-02-12 (Mon, 12 Feb 2018) Changed paths: M datapath/linux/compat/include/net/inet_frag.h Log Message: ----------- compat:inet_frag.h: Check for frag_percpu_counter_batch Fix up the compat layer to check for frag_percpu_counter_batch and if not present then use atomic_sub and atomic_add as per the backport in the 3.16.50 LTS kernel. Signed-off-by: Greg Rose Acked-by: Pravin B Shelar Commit: 62aa7df3ce6ead05641283e7854dd81dfa674738 https://github.com/openvswitch/ovs/commit/62aa7df3ce6ead05641283e7854dd81dfa674738 Author: Florian Westphal Date: 2018-02-12 (Mon, 12 Feb 2018) Changed paths: M datapath/conntrack.c Log Message: ----------- datapath: conntrack: make protocol tracker pointers const Upstream commit: commit b3480fe059ac9121b5714205b4ddae14b59ef4be Author: Florian Westphal Date: Sat Aug 12 00:57:08 2017 +0200 netfilter: conntrack: make protocol tracker pointers const Doesn't change generated code, but will make it easier to eventually make the actual trackers themselvers const. Signed-off-by: Florian Westphal Signed-off-by: Pablo Neira Ayuso Cc: Florian Westphal Signed-off-by: Greg Rose Acked-by: Pravin B Shelar Commit: 1406b9c11805a882c6d05acad2009b2f35335f87 https://github.com/openvswitch/ovs/commit/1406b9c11805a882c6d05acad2009b2f35335f87 Author: Greg Rose Date: 2018-02-12 (Mon, 12 Feb 2018) Changed paths: M datapath/datapath.c M datapath/linux/compat/stt.c Log Message: ----------- datapath: Fix SKB_GSO_UDP usage Using SKB_GSO_UDP breaks the compilation on Linux 4.14. Check for the HAVE_SKB_GSO_UDP compiler #define. Signed-off-by: Greg Rose Acked-by: Pravin B Shelar Commit: da4908001bdc4c677fe084ad8506f986cac878f4 https://github.com/openvswitch/ovs/commit/da4908001bdc4c677fe084ad8506f986cac878f4 Author: Greg Rose Date: 2018-02-12 (Mon, 12 Feb 2018) Changed paths: M acinclude.m4 M datapath/linux/compat/include/linux/compiler-gcc.h Log Message: ----------- compat: Fix compiler headers Since Linux kernel upstream commit d15155824c50 ("linux/compiler.h: Split into compiler.h and compiler_types.h") this error check for the gcc compiler header is no longer valid. Remove so that openvswitch builds for linux kernels 4.14.8 and since. Signed-off-by: Greg Rose Acked-by: Pravin B Shelar Commit: 39f8615821d74b8af938b556bc4741519a987862 https://github.com/openvswitch/ovs/commit/39f8615821d74b8af938b556bc4741519a987862 Author: Christophe JAILLET Date: 2018-02-12 (Mon, 12 Feb 2018) Changed paths: M datapath/datapath.c Log Message: ----------- datapath: Fix an error handling path in 'ovs_nla_init_match_and_action() Upstream commit: commit 5829e62ac17a40ab08c1b905565604a4b5fa7af6 Author: Christophe JAILLET Date: Mon Sep 11 21:56:20 2017 +0200 openvswitch: Fix an error handling path in 'ovs_nla_init_match_and_action()' All other error handling paths in this function go through the 'error' label. This one should do the same. Fixes: 9cc9a5cb176c ("datapath: Avoid using stack larger than 1024.") Signed-off-by: Christophe JAILLET Acked-by: Pravin B Shelar Signed-off-by: David S. Miller Cc: Christophe JAILLET Fixes: 850c2a4d1a ("datapath: Avoid using stack larger than 1024.") Signed-off-by: Greg Rose Acked-by: Pravin B Shelar Commit: e66064f7a0df8d32b8b1d9e9219b2ab07000d54b https://github.com/openvswitch/ovs/commit/e66064f7a0df8d32b8b1d9e9219b2ab07000d54b Author: Gustavo A. R. Silva Date: 2018-02-12 (Mon, 12 Feb 2018) Changed paths: M datapath/datapath.c M datapath/linux/compat/stt.c Log Message: ----------- datapath: fix data type in queue_gso_packets Upstream commit: commit 2734166e89639c973c6e125ac8bcfc2d9db72b70 Author: Gustavo A. R. Silva Date: Sat Nov 25 13:14:40 2017 -0600 net: openvswitch: datapath: fix data type in queue_gso_packets gso_type is being used in binary AND operations together with SKB_GSO_UDP. The issue is that variable gso_type is of type unsigned short and SKB_GSO_UDP expands to more than 16 bits: SKB_GSO_UDP = 1 << 16 this makes any binary AND operation between gso_type and SKB_GSO_UDP to be always zero, hence making some code unreachable and likely causing undesired behavior. Fix this by changing the data type of variable gso_type to unsigned int. Addresses-Coverity-ID: 1462223 Fixes: 0c19f846d582 ("net: accept UFO datagrams from tuntap and packet") Signed-off-by: Gustavo A. R. Silva Acked-by: Willem de Bruijn Signed-off-by: David S. Miller While backporting this I found another couple of instances of the same issue so I fixed them up as well. Cc: Gustavo A. R. Silva Signed-off-by: Greg Rose Acked-by: Pravin B Shelar Commit: 37861ce0ee92acf04a71a59521f519cc3e06bee4 https://github.com/openvswitch/ovs/commit/37861ce0ee92acf04a71a59521f519cc3e06bee4 Author: zhangliping Date: 2018-02-12 (Mon, 12 Feb 2018) Changed paths: M datapath/flow_netlink.c Log Message: ----------- datapath: fix the incorrect flow action alloc size Upstream commit: commit 67c8d22a73128ff910e2287567132530abcf5b71 Author: zhangliping Date: Sat Nov 25 22:02:12 2017 +0800 openvswitch: fix the incorrect flow action alloc size If we want to add a datapath flow, which has more than 500 vxlan outputs' action, we will get the following error reports: openvswitch: netlink: Flow action size 32832 bytes exceeds max openvswitch: netlink: Flow action size 32832 bytes exceeds max openvswitch: netlink: Actions may not be safe on all matching packets ... ... It seems that we can simply enlarge the MAX_ACTIONS_BUFSIZE to fix it, but this is not the root cause. For example, for a vxlan output action, we need about 60 bytes for the nlattr, but after it is converted to the flow action, it only occupies 24 bytes. This means that we can still support more than 1000 vxlan output actions for a single datapath flow under the the current 32k max limitation. So even if the nla_len(attr) is larger than MAX_ACTIONS_BUFSIZE, we shouldn't report EINVAL and keep it move on, as the judgement can be done by the reserve_sfa_size. Signed-off-by: zhangliping Acked-by: Pravin B Shelar Signed-off-by: David S. Miller Cc: zhangliping Signed-off-by: Greg Rose Acked-by: Pravin B Shelar Commit: 1d7f018c278b3201070669c2c9e70ba9516841c5 https://github.com/openvswitch/ovs/commit/1d7f018c278b3201070669c2c9e70ba9516841c5 Author: Arnd Bergmann Date: 2018-02-12 (Mon, 12 Feb 2018) Changed paths: M acinclude.m4 M datapath/flow.c M datapath/linux/Modules.mk A datapath/linux/compat/include/linux/timekeeping.h Log Message: ----------- datapath: use ktime_get_ts64() instead of ktime_get_ts() Upstream commit: commit 311af51dcb5629f04976a8e451673f77e3301041 Author: Arnd Bergmann Date: Mon Nov 27 12:41:38 2017 +0100 openvswitch: use ktime_get_ts64() instead of ktime_get_ts() timespec is deprecated because of the y2038 overflow, so let's convert this one to ktime_get_ts64(). The code is already safe even on 32-bit architectures, since it uses monotonic times. On 64-bit architectures, nothing changes, while on 32-bit architectures this avoids one type conversion. Signed-off-by: Arnd Bergmann Signed-off-by: David S. Miller Additional compatability check for ktime_get_ts64() exists or not. If not, then just continue using ktime_get_ts(). I added a new compatability header file "timekeeping.h". Cc: Arnd Bergmann Signed-off-by: Greg Rose Acked-by: Pravin B Shelar Compare: https://github.com/openvswitch/ovs/compare/0451eb1ebbe6...1d7f018c278b From noreply at github.com Mon Feb 12 19:06:46 2018 From: noreply at github.com (GitHub) Date: Mon, 12 Feb 2018 11:06:46 -0800 Subject: [ovs-git] [openvswitch/ovs] 6feddc: poc: Introduce Proof of Concepts (Package building... Message-ID: <5a81e5c6da197_50042abc4afadc105381@hookshot-fe-7191cb1.cp1-iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/openvswitch/ovs Commit: 6feddcd5417d8b57a342f4378776f3b3751ea341 https://github.com/openvswitch/ovs/commit/6feddcd5417d8b57a342f4378776f3b3751ea341 Author: Ansis Atteka Date: 2018-02-12 (Mon, 12 Feb 2018) Changed paths: M .gitignore M Documentation/topics/testing.rst M Makefile.am A poc/builders/Vagrantfile A poc/playbook-centos-builder.yml A poc/playbook-ubuntu-builder.yml Log Message: ----------- poc: Introduce Proof of Concepts (Package building) This patch sets up foundations for Proof of Concepts that simply materialize documentation into Ansible instructions executed in virtualized Vagrant environment. This Proof of Concept allows to easily build: 1. *.deb packages on Ubuntu 16.04; AND 2. *.rpm packages on CentOS 7.4. It also sets up DEB and RPM repository over HTTP that can be used to pull these openvswitch packages with apt-get or yum from another host. This particular Proof of Concept is intended to address following use-cases: 1. for new OVS users to see how debian and rpm packages are built; 2. for developers to easily check for packaging build regressions; 3. for developers to easily share their sandbox builds into QE setups (opposed to manually copying binaries); 4. for developers to add other Proof of Concepts that possibly may require full end-to-end integration with other thirdparty projects (e.g. DPI, libvirt, IPsec) and need Open vSwitch packages. Tested-by: Greg Rose Reviewed-by: Greg Rose Signed-off-by: Ansis Atteka From noreply at github.com Tue Feb 13 16:36:09 2018 From: noreply at github.com (GitHub) Date: Tue, 13 Feb 2018 08:36:09 -0800 Subject: [ovs-git] [openvswitch/ovs] f50c1e: docs: Update supported DPDK versions. Message-ID: <5a8313f968b08_45bd2ae6457abc041094de@hookshot-fe-6e9b612.cp1-iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/openvswitch/ovs Commit: f50c1eb4a6879a6a5a2c45c90e18df4ba08a9d34 https://github.com/openvswitch/ovs/commit/f50c1eb4a6879a6a5a2c45c90e18df4ba08a9d34 Author: Ian Stokes Date: 2018-02-13 (Tue, 13 Feb 2018) Changed paths: M Documentation/faq/releases.rst Log Message: ----------- docs: Update supported DPDK versions. Update the OVS to DPDK release table to use the latest stable DPDK 16.11.4 for OVS 2.7. Signed-off-by: Ian Stokes Acked-by: Mark Kavanagh From noreply at github.com Tue Feb 13 16:36:37 2018 From: noreply at github.com (GitHub) Date: Tue, 13 Feb 2018 08:36:37 -0800 Subject: [ovs-git] [openvswitch/ovs] 81cbdc: netdev-dpdk: fix ingress_policer leak on error pat... Message-ID: <5a831415da7d9_73b92abcae7dfc04863e3@hookshot-fe-88eb02d.cp1-iad.github.net.mail> Branch: refs/heads/branch-2.6 Home: https://github.com/openvswitch/ovs Commit: 81cbdc56c2cab76669a86d2fc0bd6a412e9e7795 https://github.com/openvswitch/ovs/commit/81cbdc56c2cab76669a86d2fc0bd6a412e9e7795 Author: zhangliping Date: 2018-02-06 (Tue, 06 Feb 2018) Changed paths: M lib/netdev-dpdk.c Log Message: ----------- netdev-dpdk: fix ingress_policer leak on error path Fix memory leak by freeing the policer if rte_meter_srtcm_config fails. Fixes: 9509913aa722 ("netdev-dpdk.c: Add ingress-policing functionality.") Signed-off-by: zhangliping Signed-off-by: Ian Stokes Commit: 2172c6b030bfd7acebfcf31648a3162e7732b1ba https://github.com/openvswitch/ovs/commit/2172c6b030bfd7acebfcf31648a3162e7732b1ba Author: Ian Stokes Date: 2018-02-06 (Tue, 06 Feb 2018) Changed paths: M INSTALL.DPDK.md M lib/netdev-dpdk.c Log Message: ----------- netdev-dpdk: Fix requested MTU size validation. This commit replaces MTU_TO_FRAME_LEN(mtu) with MTU_TO_MAX_FRAME_LEN(mtu) in netdev_dpdk_set_mtu(), in order to determine if the total length of the L2 frame with an MTU of ?mtu? exceeds NETDEV_DPDK_MAX_PKT_LEN. When setting an MTU we first check if the requested total frame length (which includes associated L2 overhead) will exceed the maximum frame length supported in netdev_dpdk_set_mtu(). The frame length is calculated by MTU_TO_FRAME_LEN as MTU + ETHER_HEADER + ETHER_CRC. The MTU for the device will be set at a later stage in dpdk_eth_dev_init() using rte_eth_dev_set_mtu(mtu). However when using rte_eth_dev_set_mtu(mtu) the calculation used to check that the frame does not exceed the max frame length for that device varies between DPDK device drivers. For example ixgbe driver calculates the frame length for a given MTU as mtu + ETHER_HDR_LEN + ETHER_CRC_LEN i40e driver calculates it as mtu + ETHER_HDR_LEN + ETHER_CRC_LEN + I40E_VLAN_TAG_SIZE * 2 em driver calculates it as mtu + ETHER_HDR_LEN + ETHER_CRC_LEN + VLAN_TAG_SIZE Currently it is possible to set an MTU for a netdev_dpdk device that exceeds the upper limit MTU for that devices DPDK driver. This leads to a segfault. This is because the frame length comparison as is, does not take into account the addition of the vlan tag overhead expected in the drivers. The netdev_dpdk_set_mtu() call will incorrectly succeed but the subsequent dpdk_eth_dev_init() will fail before the queues have been created for the DPDK device. This coupled with assumptions regarding reconfiguration requirements for the netdev will lead to a segfault when the rxq is polled for this device. A simple way to avoid this is by using MTU_TO_MAX_FRAME_LEN(mtu) when validating a requested MTU in netdev_dpdk_set_mtu(). MTU_TO_MAX_FRAME_LEN(mtu) is equivalent to the following: mtu + ETHER_HDR_LEN + ETHER_CRC_LEN + (2 * VLAN_HEADER_LEN) By using MTU_TO_MAX_FRAME_LEN at the netdev_dpdk_set_mtu() stage, OvS now takes into account the maximum L2 overhead that a DPDK driver could allow for in its frame size calculation. This allows OVS to flag an error rather than the DPDK driver if the frame length exceeds the max DPDK frame length. OVS can fail gracefully at this point and use the default MTU of 1500 to continue to configure the port. Note: this fix is a work around, a better approach would be if DPDK devices could report the maximum MTU value that can be requested on a per device basis. This capability however is not currently available. A downside of this patch is that the MTU upper limit will be reduced by 8 bytes for DPDK devices that do not need to account for vlan tags in the frame length driver calculations e.g. ixgbe devices upper MTU limit is reduced from the OVS point of view from 9710 to 9702. CC: Mark Kavanagh Fixes: 0072e931 ("netdev-dpdk: add support for jumbo frames") Signed-off-by: Ian Stokes Co-authored-by: Mark Kavanagh Signed-off-by: Mark Kavanagh Acked-by: Flavio Leitner Compare: https://github.com/openvswitch/ovs/compare/d893a3a47501...2172c6b030bf From noreply at github.com Tue Feb 13 16:37:08 2018 From: noreply at github.com (GitHub) Date: Tue, 13 Feb 2018 08:37:08 -0800 Subject: [ovs-git] [openvswitch/ovs] bfe96b: dpdk: Use DPDK 16.11.4 stable release. Message-ID: <5a83143467b31_49062b26fde95c101488e5@hookshot-fe-7191cb1.cp1-iad.github.net.mail> Branch: refs/heads/branch-2.7 Home: https://github.com/openvswitch/ovs Commit: bfe96bb08e748f140ea6134d4af3b1f1e1cddda7 https://github.com/openvswitch/ovs/commit/bfe96bb08e748f140ea6134d4af3b1f1e1cddda7 Author: Ian Stokes Date: 2018-02-06 (Tue, 06 Feb 2018) Changed paths: M .travis/linux-build.sh M Documentation/faq/releases.rst M Documentation/intro/install/dpdk.rst M Documentation/topics/dpdk/vhost-user.rst Log Message: ----------- dpdk: Use DPDK 16.11.4 stable release. Modify docs and travis linux build script to use DPDK 16.11.4 stable branch to benefit from most recent bug fixes. There are no new features introduced in the DPDK release, only back ported bug fixes. For completeness these bug fixes have been documented under the 16.11.4 section in the link below. http://dpdk.org/doc/guides-16.11/rel_notes/release_16_11.html#id4 Signed-off-by: Ian Stokes Acked-by: Mark Kavanagh From noreply at github.com Tue Feb 13 16:43:08 2018 From: noreply at github.com (GitHub) Date: Tue, 13 Feb 2018 08:43:08 -0800 Subject: [ovs-git] [openvswitch/ovs] c261dc: docs: Update supported DPDK versions. Message-ID: <5a83159cca7ee_28d62adf3aaf9bfc57368@hookshot-fe-265448d.cp1-iad.github.net.mail> Branch: refs/heads/branch-2.9 Home: https://github.com/openvswitch/ovs Commit: c261dc722b6191156e2e44ec6f70e22fa46deb28 https://github.com/openvswitch/ovs/commit/c261dc722b6191156e2e44ec6f70e22fa46deb28 Author: Ian Stokes Date: 2018-02-13 (Tue, 13 Feb 2018) Changed paths: M Documentation/faq/releases.rst Log Message: ----------- docs: Update supported DPDK versions. Update the OVS to DPDK release table to use the latest stable DPDK 16.11.4 for OVS 2.7. Signed-off-by: Ian Stokes Acked-by: Mark Kavanagh Commit: 6f202d85f652c3b62c454246ebb4883d653fb473 https://github.com/openvswitch/ovs/commit/6f202d85f652c3b62c454246ebb4883d653fb473 Author: Ian Stokes Date: 2018-02-13 (Tue, 13 Feb 2018) Changed paths: M lib/netdev-dpdk.c Log Message: ----------- netdev-dpdk: Reintroduce shared mempools. This commit manually reverts the current per port mempool model to the previous shared mempool model for DPDK ports. OVS previously used a shared mempool model for ports with the same MTU configuration. This was replaced by a per port mempool model to address issues flagged by users such as: https://mail.openvswitch.org/pipermail/ovs-discuss/2016-September/042560.html However the per port model has a number of issues including: 1. Requires an increase in memory resource requirements to support the same number of ports as the shared port model. 2. Incorrect algorithm for mbuf provisioning for each mempool. These are considered blocking factors for current deployments of OVS when upgrading to OVS 2.9 as a user may have to redimension memory for the same deployment configuration. This may not be possible for users. For clarity, the commits whose changes are removed include the following: netdev-dpdk: Create separate memory pool for each port: d555d9b netdev-dpdk: fix management of pre-existing mempools: b6b26021d Fix mempool names to reflect socket id: f06546a netdev-dpdk: skip init for existing mempools: 837c176 netdev-dpdk: manage failure in mempool name creation: 65056fd netdev-dpdk: Reword mp_size as n_mbufs: ad9b5b9 netdev-dpdk: Rename dpdk_mp_put as dpdk_mp_free: a08a115 netdev-dpdk: Fix mp_name leak on snprintf failure: ec6edc8 netdev-dpdk: Fix dpdk_mp leak in case of EEXIST: 173ef76 netdev-dpdk: Factor out struct dpdk_mp: 24e78f9 netdev-dpdk: Remove unused MAX_NB_MBUF: bc57ed9 netdev-dpdk: Fix mempool creation with large MTU: af5b0da Due to the number of commits and period of time they were introduced over, a simple revert was not possible. All code from the commits above is removed and the shared mempool code reintroduced as it was before its replacement. Code introduced by commit netdev-dpdk: Add debug appctl to get mempool information: be48173 has been modified to work with the shared mempool model. Cc: Antonio Fischetti Cc: Ilya Maximets Cc: Kevin Traynor Cc: Jan Scheurich Signed-off-by: Ian Stokes Acked-by: Kevin Traynor Tested-by: Kevin Traynor Compare: https://github.com/openvswitch/ovs/compare/1d7f018c278b...6f202d85f652 From noreply at github.com Tue Feb 13 18:48:45 2018 From: noreply at github.com (GitHub) Date: Tue, 13 Feb 2018 10:48:45 -0800 Subject: [ovs-git] [openvswitch/ovs] 312926: ofp-util: Remove prototypes for unimplemented func... Message-ID: <5a83330d11e21_27292ad0782b7c08143846@hookshot-fe-265448d.cp1-iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/openvswitch/ovs Commit: 31292693fc3a845a5f40102fcbf500cfe3167290 https://github.com/openvswitch/ovs/commit/31292693fc3a845a5f40102fcbf500cfe3167290 Author: Ben Pfaff Date: 2018-02-13 (Tue, 13 Feb 2018) Changed paths: M include/openvswitch/ofp-util.h Log Message: ----------- ofp-util: Remove prototypes for unimplemented functions. Signed-off-by: Ben Pfaff Reviewed-by: Yifeng Sun Commit: 0d71302e36c4ad290cb3b36363b48756fb438c59 https://github.com/openvswitch/ovs/commit/0d71302e36c4ad290cb3b36363b48756fb438c59 Author: Ben Pfaff Date: 2018-02-13 (Tue, 13 Feb 2018) Changed paths: M Documentation/topics/openflow.rst M include/openvswitch/automake.mk M include/openvswitch/meta-flow.h A include/openvswitch/namemap.h M include/openvswitch/ofp-actions.h A include/openvswitch/ofp-bundle.h A include/openvswitch/ofp-connection.h A include/openvswitch/ofp-flow.h A include/openvswitch/ofp-group.h A include/openvswitch/ofp-ipfix.h A include/openvswitch/ofp-match.h A include/openvswitch/ofp-meter.h A include/openvswitch/ofp-monitor.h A include/openvswitch/ofp-packet.h M include/openvswitch/ofp-parse.h A include/openvswitch/ofp-port.h A include/openvswitch/ofp-protocol.h A include/openvswitch/ofp-queue.h A include/openvswitch/ofp-switch.h A include/openvswitch/ofp-table.h M include/openvswitch/ofp-util.h M include/openvswitch/vconn.h M lib/automake.mk M lib/bundle.c M lib/classifier.c M lib/dpctl.c M lib/dpif-netdev.c M lib/dpif-netlink.c M lib/dpif.c M lib/dpif.h M lib/learn.c M lib/learning-switch.c M lib/learning-switch.h M lib/match.c M lib/meta-flow.c M lib/multipath.c A lib/namemap.c M lib/nx-match.c M lib/ofp-actions.c A lib/ofp-bundle.c A lib/ofp-connection.c M lib/ofp-ed-props.c M lib/ofp-errors.c A lib/ofp-flow.c A lib/ofp-group.c A lib/ofp-ipfix.c A lib/ofp-match.c A lib/ofp-meter.c A lib/ofp-monitor.c A lib/ofp-packet.c M lib/ofp-parse.c A lib/ofp-port.c M lib/ofp-print.c A lib/ofp-protocol.c A lib/ofp-queue.c A lib/ofp-switch.c A lib/ofp-table.c M lib/ofp-util.c M lib/ofp-version-opt.c M lib/ofp-version-opt.h M lib/tun-metadata.c M lib/vconn.c M ofproto/bond.c M ofproto/bundles.c M ofproto/bundles.h M ofproto/connmgr.c M ofproto/connmgr.h M ofproto/fail-open.c M ofproto/ofproto-dpif-ipfix.c M ofproto/ofproto-dpif-trace.c M ofproto/ofproto-dpif.c M ofproto/ofproto-dpif.h M ofproto/ofproto-provider.h M ofproto/ofproto.c M ovn/controller/ofctrl.c M ovn/controller/pinctrl.c M ovn/utilities/ovn-sbctl.c M ovn/utilities/ovn-trace.c M tests/learn.at M tests/ofp-print.at M tests/ovs-ofctl.at M tests/test-classifier.c M tests/test-flows.c M tests/test-odp.c M tests/test-vconn.c M utilities/ovs-dpctl.c M utilities/ovs-ofctl.c M utilities/ovs-testcontroller.c M vswitchd/bridge.c Log Message: ----------- ofp-util, ofp-parse: Break up into many separate modules. ofp-util had been far too large and monolithic for a long time. This commit breaks it up into units that make some logical sense. It also moves the pieces of ofp-parse that were specific to each unit into the relevant unit. Most of this commit is just moving code around. Signed-off-by: Ben Pfaff Reviewed-by: Yifeng Sun Compare: https://github.com/openvswitch/ovs/compare/f50c1eb4a687...0d71302e36c4 From noreply at github.com Tue Feb 13 20:20:57 2018 From: noreply at github.com (GitHub) Date: Tue, 13 Feb 2018 12:20:57 -0800 Subject: [ovs-git] [openvswitch/ovs] b0e07d: Implement OF1.3 extension for OF1.4 role status fe... Message-ID: <5a8348a9d9623_5c542ac8f1cd3c0c68627@hookshot-fe-32b5f5b.cp1-iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/openvswitch/ovs Commit: b0e07d5078d9d96331c4a0db4ea931951d64c970 https://github.com/openvswitch/ovs/commit/b0e07d5078d9d96331c4a0db4ea931951d64c970 Author: Ben Pfaff Date: 2018-02-13 (Tue, 13 Feb 2018) Changed paths: M Documentation/topics/openflow.rst M NEWS M include/openvswitch/ofp-msgs.h M lib/ofp-connection.c M tests/ofp-print.at M tests/ofproto.at Log Message: ----------- Implement OF1.3 extension for OF1.4 role status feature. ONF extension pack 1 for OpenFlow 1.3 defines how to implement the OpenFlow 1.4 "role status" message in OpenFlow 1.3. This commit implements that feature. ONF-JIRA: EXT-191 Signed-off-by: Ben Pfaff Acked-by: William Tu Commit: d4b5b1bc5bf1b6940fd588247612b71225a68faa https://github.com/openvswitch/ovs/commit/d4b5b1bc5bf1b6940fd588247612b71225a68faa Author: Ben Pfaff Date: 2018-02-13 (Tue, 13 Feb 2018) Changed paths: M build-aux/extract-ofp-errors Log Message: ----------- extract-ofp-errors: Minor improvements. This removes the requirement of exactly two spaces before the error description (now one or more is fine). It also makes an error message clearer. Signed-off-by: Ben Pfaff Acked-by: William Tu Commit: e994fa42067cb47becb1bb67375313e39d0216d8 https://github.com/openvswitch/ovs/commit/e994fa42067cb47becb1bb67375313e39d0216d8 Author: Ben Pfaff Date: 2018-02-13 (Tue, 13 Feb 2018) Changed paths: M Documentation/topics/openflow.rst M include/openvswitch/ofp-errors.h Log Message: ----------- ofp-errors: Add remaining OF1.4 and OF1.5 errors. Also implements the backports of relevant errors to OF1.3 as specified in ONF extension pack 1 for OF1.3. ONF-JIRA: EXT-237 ONF-JIRA: EXT-230 ONF-JIRA: EXT-264 Signed-off-by: Ben Pfaff Acked-by: William Tu Commit: f16dc4281a97b85d9aecebd0e45821e6db025cca https://github.com/openvswitch/ovs/commit/f16dc4281a97b85d9aecebd0e45821e6db025cca Author: Ben Pfaff Date: 2018-02-13 (Tue, 13 Feb 2018) Changed paths: M Documentation/topics/openflow.rst Log Message: ----------- openflow: Update list of features. Bundles are implemented for both OF1.3 and OF1.4+, so no need to keep it in the list. Packet type aware pipeline is now implemented too. Signed-off-by: Ben Pfaff Acked-by: William Tu Compare: https://github.com/openvswitch/ovs/compare/0d71302e36c4...f16dc4281a97 From noreply at github.com Wed Feb 14 00:24:54 2018 From: noreply at github.com (GitHub) Date: Tue, 13 Feb 2018 16:24:54 -0800 Subject: [ovs-git] [openvswitch/ovs] 0ef2d6: ofp-flow: Fix return value for ofputil_decode_flow... Message-ID: <5a8381d6e4772_4d3e2b116f82fc0c107139@hookshot-fe-6e9b612.cp1-iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/openvswitch/ovs Commit: 0ef2d6ce7f482e861fab273715b6ab529a3e7965 https://github.com/openvswitch/ovs/commit/0ef2d6ce7f482e861fab273715b6ab529a3e7965 Author: Ben Pfaff Date: 2018-02-13 (Tue, 13 Feb 2018) Changed paths: M lib/ofp-flow.c Log Message: ----------- ofp-flow: Fix return value for ofputil_decode_flow_stats_reply(). This function returned errno values for some errors and OFPERR_* values for others. The callers all expected OFPERR_* values. This fixes the problem. Signed-off-by: Ben Pfaff Reviewed-by: Yifeng Sun From noreply at github.com Wed Feb 14 08:55:53 2018 From: noreply at github.com (GitHub) Date: Wed, 14 Feb 2018 00:55:53 -0800 Subject: [ovs-git] [openvswitch/ovs] b68abe: datapath: export get_dp() API Message-ID: <5a83f999d638b_59c82b074de3dbfc571fc@hookshot-fe-32b5f5b.cp1-iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/openvswitch/ovs Commit: b68abe0fd9e8c821c25a3ec3cb9a36a5d22b48b9 https://github.com/openvswitch/ovs/commit/b68abe0fd9e8c821c25a3ec3cb9a36a5d22b48b9 Author: Andy Zhou Date: 2018-02-12 (Mon, 12 Feb 2018) Changed paths: M datapath/datapath.c M datapath/datapath.h Log Message: ----------- datapath: export get_dp() API Upstream commit: commit 9602c01e57f7b868d748c2ba2aef0efa64b71ffc Author: Andy Zhou Date: Fri Nov 10 12:09:41 2017 -0800 openvswitch: export get_dp() API. Later patches will invoke get_dp() outside of datapath.c. Export it. Signed-off-by: Andy Zhou Signed-off-by: David S. Miller Cc: Andy Zhou Signed-off-by: Greg Rose Acked-by: Pravin B Shelar Commit: b147f2e9197e0cbb76fbb89513f1907d9ce68155 https://github.com/openvswitch/ovs/commit/b147f2e9197e0cbb76fbb89513f1907d9ce68155 Author: Jiri Benc Date: 2018-02-12 (Mon, 12 Feb 2018) Changed paths: M acinclude.m4 M datapath/datapath.c M datapath/datapath.h M datapath/dp_notify.c M datapath/linux/compat/include/linux/openvswitch.h Log Message: ----------- datapath: reliable interface indentification in port dumps Upstream commit: commit 9354d452034273a50a4fd703bea31e5d6b1fc20b Author: Jiri Benc Date: Thu Nov 2 17:04:37 2017 -0200 openvswitch: reliable interface indentification in port dumps This patch allows reliable identification of netdevice interfaces connected to openvswitch bridges. In particular, user space queries the netdev interfaces belonging to the ports for statistics, up/down state, etc. Datapath dump needs to provide enough information for the user space to be able to do that. Currently, only interface names are returned. This is not sufficient, as openvswitch allows its ports to be in different name spaces and the interface name is valid only in its name space. What is needed and generally used in other netlink APIs, is the pair ifindex+netnsid. The solution is addition of the ifindex+netnsid pair (or only ifindex if in the same name space) to vport get/dump operation. On request side, ideally the ifindex+netnsid pair could be used to get/set/del the corresponding vport. This is not implemented by this patch and can be added later if needed. Signed-off-by: Jiri Benc Signed-off-by: David S. Miller Added compat fixup for peernet2id. Cc: Jiri Benc Signed-off-by: Greg Rose Acked-by: Pravin B Shelar Commit: 8011eea7e1418d2c41e19c7127d727dc631848a4 https://github.com/openvswitch/ovs/commit/8011eea7e1418d2c41e19c7127d727dc631848a4 Author: Andy Zhou Date: 2018-02-12 (Mon, 12 Feb 2018) Changed paths: M datapath/linux/compat/include/linux/openvswitch.h Log Message: ----------- datapath: Add meter netlink definitions Upstream commit: commit 5794040647de4011598a6d005fdad95d24fd385b Author: Andy Zhou Date: Fri Nov 10 12:09:40 2017 -0800 openvswitch: Add meter netlink definitions Meter has its own netlink family. Define netlink messages and attributes for communicating with the user space programs. Signed-off-by: Andy Zhou Signed-off-by: David S. Miller Cc: Andy Zhou Signed-off-by: Greg Rose Acked-by: Pravin B Shelar Commit: 1cb5703965ef7b29cd0ce9cbdb32209fd8d3ee07 https://github.com/openvswitch/ovs/commit/1cb5703965ef7b29cd0ce9cbdb32209fd8d3ee07 Author: Andy Zhou Date: 2018-02-12 (Mon, 12 Feb 2018) Changed paths: M acinclude.m4 M datapath/Modules.mk M datapath/datapath.c M datapath/datapath.h M datapath/linux/compat/include/net/netlink.h A datapath/meter.c A datapath/meter.h Log Message: ----------- datapath: Add meter infrastructure Upstream commit: commit 96fbc13d7e770b542d2d1fcf700d0baadc6e8063 Author: Andy Zhou Date: Fri Nov 10 12:09:42 2017 -0800 openvswitch: Add meter infrastructure OVS kernel datapath so far does not support Openflow meter action. This is the first stab at adding kernel datapath meter support. This implementation supports only drop band type. Signed-off-by: Andy Zhou Signed-off-by: David S. Miller Added a compat layer fixup for nla_parse. Added another compat fixup for ktime_get_ns. Cc: Andy Zhou Signed-off-by: Greg Rose Acked-by: Pravin B Shelar Commit: 720c5514a219cb11f76b4233e1f28624cc6cfbd8 https://github.com/openvswitch/ovs/commit/720c5514a219cb11f76b4233e1f28624cc6cfbd8 Author: Wei Yongjun Date: 2018-02-12 (Mon, 12 Feb 2018) Changed paths: M datapath/meter.c Log Message: ----------- datapath: Fix return value check in ovs_meter_cmd_features() Upstream commit: commit 8a860c2bcc84a8e4fbcabb928cd97e4c51b17d93 Author: Wei Yongjun Date: Tue Nov 14 06:20:16 2017 +0000 openvswitch: Fix return value check in ovs_meter_cmd_features() In case of error, the function ovs_meter_cmd_reply_start() returns ERR_PTR() not NULL. The NULL test in the return value check should be replaced with IS_ERR(). Fixes: 96fbc13d7e77 ("openvswitch: Add meter infrastructure") Signed-off-by: Wei Yongjun Acked-by: Pravin B Shelar Signed-off-by: David S. Miller Cc: Wei Yongjun Signed-off-by: Greg Rose Acked-by: Pravin B Shelar Commit: ab86f680831ca239e451106a82006a9eae10394c https://github.com/openvswitch/ovs/commit/ab86f680831ca239e451106a82006a9eae10394c Author: Wei Yongjun Date: 2018-02-12 (Mon, 12 Feb 2018) Changed paths: M datapath/meter.c Log Message: ----------- datapath: Using kfree_rcu() to simplify the code Upstream commit: commit 6dc14dc40a1d1dafd8491c349b5f3e15aabc4edb Author: Wei Yongjun Date: Tue Nov 14 06:27:12 2017 +0000 openvswitch: Using kfree_rcu() to simplify the code The callback function of call_rcu() just calls a kfree(), so we can use kfree_rcu() instead of call_rcu() + callback function. Signed-off-by: Wei Yongjun Acked-by: Pravin B Shelar Signed-off-by: David S. Miller Cc: Wei Yongjun Signed-off-by: Greg Rose Acked-by: Pravin B Shelar Commit: b88ec467c6059f5cf3f0f27507f0515271067388 https://github.com/openvswitch/ovs/commit/b88ec467c6059f5cf3f0f27507f0515271067388 Author: Gustavo A. R. Silva Date: 2018-02-12 (Mon, 12 Feb 2018) Changed paths: M datapath/meter.c Log Message: ----------- datapath: meter: fix NULL pointer dereference in ovs_meter_cmd_reply_start Upstream commit: commit b74912a2fdae9aadd20da502644aa8848c861954 Author: Gustavo A. R. Silva Date: Tue Nov 14 14:26:16 2017 -0600 openvswitch: meter: fix NULL pointer dereference in ovs_meter_cmd_reply_star It seems that the intention of the code is to null check the value returned by function genlmsg_put. But the current code is null checking the address of the pointer that holds the value returned by genlmsg_put. Fix this by properly null checking the value returned by function genlmsg_put in order to avoid a pontential null pointer dereference. Addresses-Coverity-ID: 1461561 ("Dereference before null check") Addresses-Coverity-ID: 1461562 ("Dereference null return value") Fixes: 96fbc13d7e77 ("openvswitch: Add meter infrastructure") Signed-off-by: Gustavo A. R. Silva Signed-off-by: David S. Miller Cc: Gustavo A. R. Silva Signed-off-by: Greg Rose Acked-by: Pravin B Shelar Commit: 65e64d207cd98c6989dcaeed9c29a8b212c2aeba https://github.com/openvswitch/ovs/commit/65e64d207cd98c6989dcaeed9c29a8b212c2aeba Author: Gustavo A. R. Silva Date: 2018-02-12 (Mon, 12 Feb 2018) Changed paths: M datapath/meter.c Log Message: ----------- datapath: meter: Use 64-bit arithmetic instead of 32-bit Upstream commit: commit 5b7789e8fa8f353ad8f2c44de2385cb161b22d32 Author: Gustavo A. R. Silva Date: Tue Jan 30 22:55:33 2018 -0600 Add suffix LL to constant 1000 in order to give the compiler complete information about the proper arithmetic to use. Notice that this constant is used in a context that expects an expression of type long long int (64 bits, signed). The expression (band->burst_size + band->rate) * 1000 is currently being evaluated using 32-bit arithmetic. Addresses-Coverity-ID: 1461563 ("Unintentional integer overflow") Signed-off-by: Gustavo A. R. Silva Signed-off-by: David S. Miller Signed-off-by: Greg Rose Acked-by: Pravin B Shelar Commit: cc4f25be695e4d306e6274f584754d65a58b82ae https://github.com/openvswitch/ovs/commit/cc4f25be695e4d306e6274f584754d65a58b82ae Author: Pravin Shelar Date: 2018-02-12 (Mon, 12 Feb 2018) Changed paths: M Documentation/faq/releases.rst M NEWS Log Message: ----------- Documentation: Update NEWS and faq Per the Linux 4.14 kernel support. Signed-off-by: Greg Rose Acked-by: Pravin B Shelar Commit: 05522eaa8a138a71c780a4b4c2b7c59ff757dc0e https://github.com/openvswitch/ovs/commit/05522eaa8a138a71c780a4b4c2b7c59ff757dc0e Author: Greg Rose Date: 2018-02-12 (Mon, 12 Feb 2018) Changed paths: M acinclude.m4 Log Message: ----------- acinclude.m4: Enable Linux 4.14 Signed-off-by: Greg Rose Acked-by: Pravin B Shelar Commit: be7b165518f777c68833fcb0c844419c8c34af3e https://github.com/openvswitch/ovs/commit/be7b165518f777c68833fcb0c844419c8c34af3e Author: Greg Rose Date: 2018-02-12 (Mon, 12 Feb 2018) Changed paths: M .travis.yml Log Message: ----------- travis: Update kernel test list from kernel.org Also add package libelf-dev - since 4.14 it's required for making the source. Signed-off-by: Greg Rose Acked-by: Pravin B Shelar Compare: https://github.com/openvswitch/ovs/compare/0ef2d6ce7f48...be7b165518f7 From noreply at github.com Wed Feb 14 22:03:49 2018 From: noreply at github.com (GitHub) Date: Wed, 14 Feb 2018 14:03:49 -0800 Subject: [ovs-git] [openvswitch/ovs] 271e48: conntrack: Support conntrack flush by ct 5-tuple Message-ID: <5a84b2455577e_56872ac477401c10571b6@hookshot-fe-2cc8887.cp1-iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/openvswitch/ovs Commit: 271e48a0e244f12552e2699bcdc93a1d9d3b162f https://github.com/openvswitch/ovs/commit/271e48a0e244f12552e2699bcdc93a1d9d3b162f Author: Yi-Hung Wei Date: 2018-02-14 (Wed, 14 Feb 2018) Changed paths: M lib/conntrack.c M lib/conntrack.h M lib/dpif-netdev.c M tests/system-kmod-macros.at M tests/system-traffic.at M tests/system-userspace-macros.at Log Message: ----------- conntrack: Support conntrack flush by ct 5-tuple This patch adds support of flushing a conntrack entry specified by the conntrack 5-tuple in dpif-netdev. Signed-off-by: Yi-Hung Wei Signed-off-by: Ben Pfaff Acked-by: Darrell Ball From noreply at github.com Wed Feb 14 23:24:49 2018 From: noreply at github.com (GitHub) Date: Wed, 14 Feb 2018 15:24:49 -0800 Subject: [ovs-git] [openvswitch/ovs] 358fa1: OVN: rename encode_nested_neighbor_actions in enco... Message-ID: <5a84c541e7651_78432b0a8cf01c0413328e@hookshot-fe-cace476.cp1-iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/openvswitch/ovs Commit: 358fa13831d12f85df92c5c81f0775ad9c682cbd https://github.com/openvswitch/ovs/commit/358fa13831d12f85df92c5c81f0775ad9c682cbd Author: Lorenzo Bianconi Date: 2018-02-14 (Wed, 14 Feb 2018) Changed paths: M ovn/lib/actions.c Log Message: ----------- OVN: rename encode_nested_neighbor_actions in encode_nested_actions Rename encode_nested_neighbor_actions routine in encode_nested_actions in order to have a more general name for nested actions encoder. Signed-off-by: Lorenzo Bianconi Signed-off-by: Ben Pfaff From noreply at github.com Thu Feb 15 01:50:03 2018 From: noreply at github.com (GitHub) Date: Wed, 14 Feb 2018 17:50:03 -0800 Subject: [ovs-git] [openvswitch/ovs] ba19e9: ovsdb-tool: Indicate "db" and "schema" are optiona... Message-ID: <5a84e74b71d8_6edc2aef2e08bc0c13056d@hookshot-fe-da92815.cp1-iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/openvswitch/ovs Commit: ba19e98cf35956626b09ce744b1c55706ffc106a https://github.com/openvswitch/ovs/commit/ba19e98cf35956626b09ce744b1c55706ffc106a Author: Justin Pettit Date: 2018-02-14 (Wed, 14 Feb 2018) Changed paths: M ovsdb/ovsdb-tool.1.in Log Message: ----------- ovsdb-tool: Indicate "db" and "schema" are optional in man page. Signed-off-by: Justin Pettit Acked-by: Ben Pfaff From noreply at github.com Thu Feb 15 01:52:07 2018 From: noreply at github.com (GitHub) Date: Wed, 14 Feb 2018 17:52:07 -0800 Subject: [ovs-git] [openvswitch/ovs] ae54da: ovsdb-tool: Indicate "db" and "schema" are optiona... Message-ID: <5a84e7c7b433a_57e92aaddf22bc1479874@hookshot-fe-2cc8887.cp1-iad.github.net.mail> Branch: refs/heads/branch-2.9 Home: https://github.com/openvswitch/ovs Commit: ae54da5d5f926b95decc66446f78c847236adf00 https://github.com/openvswitch/ovs/commit/ae54da5d5f926b95decc66446f78c847236adf00 Author: Justin Pettit Date: 2018-02-14 (Wed, 14 Feb 2018) Changed paths: M ovsdb/ovsdb-tool.1.in Log Message: ----------- ovsdb-tool: Indicate "db" and "schema" are optional in man page. Signed-off-by: Justin Pettit Acked-by: Ben Pfaff From noreply at github.com Thu Feb 15 16:55:44 2018 From: noreply at github.com (GitHub) Date: Thu, 15 Feb 2018 08:55:44 -0800 Subject: [ovs-git] [openvswitch/ovs] 330184: ofproto-dpif-ipfix: Fix an issue in flow key part Message-ID: <5a85bb90d081b_63e52ad0031c7c141101b@hookshot-fe-31feec6.cp1-iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/openvswitch/ovs Commit: 33018441033c877aae88232b0522c54efc02a122 https://github.com/openvswitch/ovs/commit/33018441033c877aae88232b0522c54efc02a122 Author: Benli Ye Date: 2018-02-15 (Thu, 15 Feb 2018) Changed paths: M ofproto/ofproto-dpif-ipfix.c Log Message: ----------- ofproto-dpif-ipfix: Fix an issue in flow key part As struct ipfix_data_record_flow_key_iface didn't calculate its length in flow key part, it may cause problem when flow key part length is not enough. Use MAX_IF_LEN and MAX_IF_DESCR to pre-allocate memory for ipfix_data_record_flow_key_iface. Signed-off-by: Daniel Benli Ye Signed-off-by: Ben Pfaff From noreply at github.com Thu Feb 15 16:56:47 2018 From: noreply at github.com (GitHub) Date: Thu, 15 Feb 2018 08:56:47 -0800 Subject: [ovs-git] [openvswitch/ovs] 3a22c0: ofproto-dpif-ipfix: Fix an issue in flow key part Message-ID: <5a85bbcfbda97_5e6c2aeacf8abc107777f@hookshot-fe-265448d.cp1-iad.github.net.mail> Branch: refs/heads/branch-2.9 Home: https://github.com/openvswitch/ovs Commit: 3a22c066ab692a58b6e7b0e9ffdc108baf9766ef https://github.com/openvswitch/ovs/commit/3a22c066ab692a58b6e7b0e9ffdc108baf9766ef Author: Benli Ye Date: 2018-02-15 (Thu, 15 Feb 2018) Changed paths: M ofproto/ofproto-dpif-ipfix.c Log Message: ----------- ofproto-dpif-ipfix: Fix an issue in flow key part As struct ipfix_data_record_flow_key_iface didn't calculate its length in flow key part, it may cause problem when flow key part length is not enough. Use MAX_IF_LEN and MAX_IF_DESCR to pre-allocate memory for ipfix_data_record_flow_key_iface. Signed-off-by: Daniel Benli Ye Signed-off-by: Ben Pfaff From noreply at github.com Thu Feb 15 21:05:38 2018 From: noreply at github.com (GitHub) Date: Thu, 15 Feb 2018 13:05:38 -0800 Subject: [ovs-git] [openvswitch/ovs] 5b57e1: ovn-controller: Fix crash when sending GARP when o... Message-ID: <5a85f622b05e4_3eef2ab6112fdc0c112950@hookshot-fe-da92815.cp1-iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/openvswitch/ovs Commit: 5b57e12ab2a54e4dee712ef0ddd7a5bb0c206b24 https://github.com/openvswitch/ovs/commit/5b57e12ab2a54e4dee712ef0ddd7a5bb0c206b24 Author: Guoshuai Li Date: 2018-02-15 (Thu, 15 Feb 2018) Changed paths: M ovn/controller/pinctrl.c M tests/ovn.at Log Message: ----------- ovn-controller: Fix crash when sending GARP when openflow disconnection. This is call stack: Program received signal SIGABRT, Aborted. 1 0x00007ffff6a4f8e8 in __GI_abort () at abort.c:90 2 0x00000000004765d6 in ofputil_protocol_to_ofp_version (protocol=) at lib/ofp-util.c:769 3 0x000000000047c19e in ofputil_encode_packet_out (po=po at entry=0x7fffffffa0e0, protocol=) at lib/ofp-util.c:7060 4 0x0000000000410870 in send_garp (garp=0x83cfe0, current_time=current_time at entry=1200375400) at ovn/controller/pinctrl.c:1738 5 0x000000000041430f in send_garp_run (active_tunnels=, local_datapaths=0x7fffffffc0a0, chassis_index=, chassis=0x8194d0, br_int=, ctx=0x7fffffffc080) at ovn/controller/pinctrl.c:2069 Signed-off-by: Guoshuai Li Acked-by: Mark Michelson Signed-off-by: Ben Pfaff From noreply at github.com Thu Feb 15 21:05:57 2018 From: noreply at github.com (GitHub) Date: Thu, 15 Feb 2018 13:05:57 -0800 Subject: [ovs-git] [openvswitch/ovs] 377420: ovn-controller: Fix crash when sending GARP when o... Message-ID: <5a85f63574a0_4a092ad5c375bc00843e9@hookshot-fe-265448d.cp1-iad.github.net.mail> Branch: refs/heads/branch-2.9 Home: https://github.com/openvswitch/ovs Commit: 3774206996c8a20c82464fc61706a48130da04b0 https://github.com/openvswitch/ovs/commit/3774206996c8a20c82464fc61706a48130da04b0 Author: Guoshuai Li Date: 2018-02-15 (Thu, 15 Feb 2018) Changed paths: M ovn/controller/pinctrl.c M tests/ovn.at Log Message: ----------- ovn-controller: Fix crash when sending GARP when openflow disconnection. This is call stack: Program received signal SIGABRT, Aborted. 1 0x00007ffff6a4f8e8 in __GI_abort () at abort.c:90 2 0x00000000004765d6 in ofputil_protocol_to_ofp_version (protocol=) at lib/ofp-util.c:769 3 0x000000000047c19e in ofputil_encode_packet_out (po=po at entry=0x7fffffffa0e0, protocol=) at lib/ofp-util.c:7060 4 0x0000000000410870 in send_garp (garp=0x83cfe0, current_time=current_time at entry=1200375400) at ovn/controller/pinctrl.c:1738 5 0x000000000041430f in send_garp_run (active_tunnels=, local_datapaths=0x7fffffffc0a0, chassis_index=, chassis=0x8194d0, br_int=, ctx=0x7fffffffc080) at ovn/controller/pinctrl.c:2069 Signed-off-by: Guoshuai Li Acked-by: Mark Michelson Signed-off-by: Ben Pfaff From noreply at github.com Thu Feb 15 21:06:03 2018 From: noreply at github.com (GitHub) Date: Thu, 15 Feb 2018 13:06:03 -0800 Subject: [ovs-git] [openvswitch/ovs] dbc6cb: ovn-controller: Fix crash when sending GARP when o... Message-ID: <5a85f63b27e5a_5d5d2b1ecd3c9c1087981@hookshot-fe-7191cb1.cp1-iad.github.net.mail> Branch: refs/heads/branch-2.8 Home: https://github.com/openvswitch/ovs Commit: dbc6cbc08abece4c41b23a2938ba2e71455726b6 https://github.com/openvswitch/ovs/commit/dbc6cbc08abece4c41b23a2938ba2e71455726b6 Author: Guoshuai Li Date: 2018-02-15 (Thu, 15 Feb 2018) Changed paths: M ovn/controller/pinctrl.c M tests/ovn.at Log Message: ----------- ovn-controller: Fix crash when sending GARP when openflow disconnection. This is call stack: Program received signal SIGABRT, Aborted. 1 0x00007ffff6a4f8e8 in __GI_abort () at abort.c:90 2 0x00000000004765d6 in ofputil_protocol_to_ofp_version (protocol=) at lib/ofp-util.c:769 3 0x000000000047c19e in ofputil_encode_packet_out (po=po at entry=0x7fffffffa0e0, protocol=) at lib/ofp-util.c:7060 4 0x0000000000410870 in send_garp (garp=0x83cfe0, current_time=current_time at entry=1200375400) at ovn/controller/pinctrl.c:1738 5 0x000000000041430f in send_garp_run (active_tunnels=, local_datapaths=0x7fffffffc0a0, chassis_index=, chassis=0x8194d0, br_int=, ctx=0x7fffffffc080) at ovn/controller/pinctrl.c:2069 Signed-off-by: Guoshuai Li Acked-by: Mark Michelson Signed-off-by: Ben Pfaff From noreply at github.com Fri Feb 16 08:49:17 2018 From: noreply at github.com (GitHub) Date: Fri, 16 Feb 2018 00:49:17 -0800 Subject: [ovs-git] [openvswitch/ovs] c49735: datapath: do not propagate headroom updates to int... Message-ID: <5a869b0d9d39a_3ea02ab6d5823c08168319@hookshot-fe-da92815.cp1-iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/openvswitch/ovs Commit: c497350a53805f01c31586bae6600d96e1f41228 https://github.com/openvswitch/ovs/commit/c497350a53805f01c31586bae6600d96e1f41228 Author: paolo abeni Date: 2018-02-16 (Fri, 16 Feb 2018) Changed paths: M datapath/vport-internal_dev.c Log Message: ----------- datapath: do not propagate headroom updates to internal port Upstream commit: commit 183dea5818315c0a172d21ecbcd2554894bf01e3 Author: Paolo Abeni Date: Thu Nov 30 15:35:33 2017 +0100 openvswitch: do not propagate headroom updates to internal port After commit 3a927bc7cf9d ("ovs: propagate per dp max headroom to all vports") the need_headroom for the internal vport is updated accordingly to the max needed headroom in its datapath. That avoids the pskb_expand_head() costs when sending/forwarding packets towards tunnel devices, at least for some scenarios. We still require such copy when using the ovs-preferred configuration for vxlan tunnels: br_int / \ tap vxlan (remote_ip:X) br_phy \ NIC where the route towards the IP 'X' is via 'br_phy'. When forwarding traffic from the tap towards the vxlan device, we will call pskb_expand_head() in vxlan_build_skb() because br-phy->needed_headroom is equal to tun->needed_headroom. With this change we avoid updating the internal vport needed_headroom, so that in the above scenario no head copy is needed, giving 5% performance improvement in UDP throughput test. As a trade-off, packets sent from the internal port towards a tunnel device will now experience the head copy overhead. The rationale is that the latter use-case is less relevant performance-wise. Signed-off-by: paolo abeni Acked-by: Pravin B Shelar Signed-off-by: David S. Miller Cc: paolo abeni Signed-off-by: Greg Rose Acked-by: Pravin B Shelar Commit: 6db2a24d96b5b5bd0e3c68a3b721d77b003c84d6 https://github.com/openvswitch/ovs/commit/6db2a24d96b5b5bd0e3c68a3b721d77b003c84d6 Author: Eric Garver Date: 2018-02-16 (Fri, 16 Feb 2018) Changed paths: M datapath/flow.c Log Message: ----------- datapath: Fix pop_vlan action for double tagged frames Upstream commit: commit c48e74736fccf25fb32bb015426359e1c2016e3b Author: Eric Garver Date: Wed Dec 20 15:09:22 2017 -0500 openvswitch: Fix pop_vlan action for double tagged frames skb_vlan_pop() expects skb->protocol to be a valid TPID for double tagged frames. So set skb->protocol to the TPID and let skb_vlan_pop() shift the true ethertype into position for us. Fixes: 5108bbaddc37 ("openvswitch: add processing of L3 packets") Signed-off-by: Eric Garver Reviewed-by: Jiri Benc Signed-off-by: David S. Miller Cc: Eric Garver Fixes: a27c454ee0 ("datapath: add processing of L3 packets") Signed-off-by: Greg Rose Acked-by: Pravin B Shelar Commit: e7c57cc3333c9bae37876a6a62b2aed7b6e5208b https://github.com/openvswitch/ovs/commit/e7c57cc3333c9bae37876a6a62b2aed7b6e5208b Author: Julia Lawall Date: 2018-02-16 (Fri, 16 Feb 2018) Changed paths: M datapath/conntrack.c Log Message: ----------- datapath: drop unneeded newline Upstream commit: commit e0b10844d9e617a1a5ce2ddf73d38aaa0a47a2a4 Author: Julia Lawall Date: Wed Dec 27 15:51:38 2017 +0100 openvswitch: drop unneeded newline OVS_NLERR prints a newline at the end of the message string, so the message string does not need to include a newline explicitly. Done using Coccinelle. Signed-off-by: Julia Lawall Signed-off-by: David S. Miller Cc: Julia Lawall Signed-off-by: Greg Rose Acked-by: Pravin B Shelar Commit: cd8b9e742123b55560f39c8d62c94413d1b665b5 https://github.com/openvswitch/ovs/commit/cd8b9e742123b55560f39c8d62c94413d1b665b5 Author: Yang Shi Date: 2018-02-16 (Fri, 16 Feb 2018) Changed paths: M datapath/vport-internal_dev.c Log Message: ----------- datapath: remove unused hardirq.h Upstream commit: commit 419091f1cc8afce943fd12af0df26201ee20c1c0 Author: Yang Shi Date: Tue Jan 9 03:52:53 2018 +0800 net: ovs: remove unused hardirq.h Preempt counter APIs have been split out, currently, hardirq.h just includes irq_enter/exit APIs which are not used by openvswitch at all. So, remove the unused hardirq.h. Signed-off-by: Yang Shi Acked-by: Pravin B Shelar Cc: "David S. Miller" Cc: dev at openvswitch.org Signed-off-by: David S. Miller Cc: Yang Shi Signed-off-by: Greg Rose Acked-by: Pravin B Shelar Acked-by? Yang Shi Commit: 5830593ffc6be0e008d214b7cdd82fe34ad4bedf https://github.com/openvswitch/ovs/commit/5830593ffc6be0e008d214b7cdd82fe34ad4bedf Author: Christopher D?az Riveros Date: 2018-02-16 (Fri, 16 Feb 2018) Changed paths: M datapath/flow_netlink.c Log Message: ----------- datapath: Remove unneeded semicolons Upstream commit: commit 89290b831ec1a0b233fdc7aaad84acdf4ebbf6aa Author: Christopher D?az Riveros Date: Wed Jan 17 16:10:28 2018 -0500 flow_netlink: Remove unneeded semicolons Trivial fix removes unneeded semicolons after if blocks. This issue was detected by using the Coccinelle software. Signed-off-by: Christopher D?az Riveros Signed-off-by: David S. Miller Cc: Christopher D?az Riveros Signed-off-by: Greg Rose Acked-by: Pravin B Shelar Commit: c21adacdc1ba8218545633bf6f6f878e1802fa28 https://github.com/openvswitch/ovs/commit/c21adacdc1ba8218545633bf6f6f878e1802fa28 Author: Ed Swierk Date: 2018-02-16 (Fri, 16 Feb 2018) Changed paths: M datapath/conntrack.c Log Message: ----------- datapath: Remove padding from packet before L3+ conntrack processing Upstream commit: commit 9382fe71c0058465e942a633869629929102843d Author: Ed Swierk Date: Wed Jan 31 18:48:02 2018 -0800 openvswitch: Remove padding from packet before L3+ conntrack processing IPv4 and IPv6 packets may arrive with lower-layer padding that is not included in the L3 length. For example, a short IPv4 packet may have up to 6 bytes of padding following the IP payload when received on an Ethernet device with a minimum packet length of 64 bytes. Higher-layer processing functions in netfilter (e.g. nf_ip_checksum(), and help() in nf_conntrack_ftp) assume skb->len reflects the length of the L3 header and payload, rather than referring back to ip_hdr->tot_len or ipv6_hdr->payload_len, and get confused by lower-layer padding. In the normal IPv4 receive path, ip_rcv() trims the packet to ip_hdr->tot_len before invoking netfilter hooks. In the IPv6 receive path, ip6_rcv() does the same using ipv6_hdr->payload_len. Similarly in the br_netfilter receive path, br_validate_ipv4() and br_validate_ipv6() trim the packet to the L3 length before invoking netfilter hooks. Currently in the OVS conntrack receive path, ovs_ct_execute() pulls the skb to the L3 header but does not trim it to the L3 length before calling nf_conntrack_in(NF_INET_PRE_ROUTING). When nf_conntrack_proto_tcp encounters a packet with lower-layer padding, nf_ip_checksum() fails causing a "nf_ct_tcp: bad TCP checksum" log message. While extra zero bytes don't affect the checksum, the length in the IP pseudoheader does. That length is based on skb->len, and without trimming, it doesn't match the length the sender used when computing the checksum. In ovs_ct_execute(), trim the skb to the L3 length before higher-layer processing. Signed-off-by: Ed Swierk Acked-by: Pravin B Shelar Signed-off-by: David S. Miller Cc: Ed Swierk Signed-off-by: Greg Rose Acked-by: Pravin B Shelar Commit: bba78707b0af9c883681e9872e99b49eef6db4da https://github.com/openvswitch/ovs/commit/bba78707b0af9c883681e9872e99b49eef6db4da Author: Greg Rose Date: 2018-02-16 (Fri, 16 Feb 2018) Changed paths: M acinclude.m4 Log Message: ----------- acinclude: Enable building for Linux kernel 4.15 Signed-off-by: Greg Rose Acked-by: Pravin B Shelar Commit: bdd508b68b0ea89d51a8032794c4eb00f539d401 https://github.com/openvswitch/ovs/commit/bdd508b68b0ea89d51a8032794c4eb00f539d401 Author: Greg Rose Date: 2018-02-16 (Fri, 16 Feb 2018) Changed paths: M .travis.yml Log Message: ----------- travis: Update Linux kernel test list Add newly supported 4.15 release and also update the kernel test list to the LTS list at www.kernel.org. Signed-off-by: Greg Rose Acked-by: Pravin B Shelar Compare: https://github.com/openvswitch/ovs/compare/5b57e12ab2a5...bdd508b68b0e From noreply at github.com Fri Feb 16 08:49:38 2018 From: noreply at github.com (GitHub) Date: Fri, 16 Feb 2018 00:49:38 -0800 Subject: [ovs-git] [openvswitch/ovs] 893b99: datapath: do not propagate headroom updates to int... Message-ID: <5a869b2230685_3ea2aeb1d1f1c1416701@hookshot-fe-d252ca1.cp1-iad.github.net.mail> Branch: refs/heads/branch-2.9 Home: https://github.com/openvswitch/ovs Commit: 893b9906cad89662c901f2cc4f1b051410b05eec https://github.com/openvswitch/ovs/commit/893b9906cad89662c901f2cc4f1b051410b05eec Author: paolo abeni Date: 2018-02-16 (Fri, 16 Feb 2018) Changed paths: M datapath/vport-internal_dev.c Log Message: ----------- datapath: do not propagate headroom updates to internal port Upstream commit: commit 183dea5818315c0a172d21ecbcd2554894bf01e3 Author: Paolo Abeni Date: Thu Nov 30 15:35:33 2017 +0100 openvswitch: do not propagate headroom updates to internal port After commit 3a927bc7cf9d ("ovs: propagate per dp max headroom to all vports") the need_headroom for the internal vport is updated accordingly to the max needed headroom in its datapath. That avoids the pskb_expand_head() costs when sending/forwarding packets towards tunnel devices, at least for some scenarios. We still require such copy when using the ovs-preferred configuration for vxlan tunnels: br_int / \ tap vxlan (remote_ip:X) br_phy \ NIC where the route towards the IP 'X' is via 'br_phy'. When forwarding traffic from the tap towards the vxlan device, we will call pskb_expand_head() in vxlan_build_skb() because br-phy->needed_headroom is equal to tun->needed_headroom. With this change we avoid updating the internal vport needed_headroom, so that in the above scenario no head copy is needed, giving 5% performance improvement in UDP throughput test. As a trade-off, packets sent from the internal port towards a tunnel device will now experience the head copy overhead. The rationale is that the latter use-case is less relevant performance-wise. Signed-off-by: paolo abeni Acked-by: Pravin B Shelar Signed-off-by: David S. Miller Cc: paolo abeni Signed-off-by: Greg Rose Acked-by: Pravin B Shelar Commit: fcb77796c4d133c3ac37dc00b8fe8398c1c75f20 https://github.com/openvswitch/ovs/commit/fcb77796c4d133c3ac37dc00b8fe8398c1c75f20 Author: Eric Garver Date: 2018-02-16 (Fri, 16 Feb 2018) Changed paths: M datapath/flow.c Log Message: ----------- datapath: Fix pop_vlan action for double tagged frames Upstream commit: commit c48e74736fccf25fb32bb015426359e1c2016e3b Author: Eric Garver Date: Wed Dec 20 15:09:22 2017 -0500 openvswitch: Fix pop_vlan action for double tagged frames skb_vlan_pop() expects skb->protocol to be a valid TPID for double tagged frames. So set skb->protocol to the TPID and let skb_vlan_pop() shift the true ethertype into position for us. Fixes: 5108bbaddc37 ("openvswitch: add processing of L3 packets") Signed-off-by: Eric Garver Reviewed-by: Jiri Benc Signed-off-by: David S. Miller Cc: Eric Garver Fixes: a27c454ee0 ("datapath: add processing of L3 packets") Signed-off-by: Greg Rose Acked-by: Pravin B Shelar Commit: a948fa4b1ea3ec7ec86cc37ca518dee416beb538 https://github.com/openvswitch/ovs/commit/a948fa4b1ea3ec7ec86cc37ca518dee416beb538 Author: Ed Swierk Date: 2018-02-16 (Fri, 16 Feb 2018) Changed paths: M datapath/conntrack.c Log Message: ----------- datapath: Remove padding from packet before L3+ conntrack processing Upstream commit: commit 9382fe71c0058465e942a633869629929102843d Author: Ed Swierk Date: Wed Jan 31 18:48:02 2018 -0800 openvswitch: Remove padding from packet before L3+ conntrack processing IPv4 and IPv6 packets may arrive with lower-layer padding that is not included in the L3 length. For example, a short IPv4 packet may have up to 6 bytes of padding following the IP payload when received on an Ethernet device with a minimum packet length of 64 bytes. Higher-layer processing functions in netfilter (e.g. nf_ip_checksum(), and help() in nf_conntrack_ftp) assume skb->len reflects the length of the L3 header and payload, rather than referring back to ip_hdr->tot_len or ipv6_hdr->payload_len, and get confused by lower-layer padding. In the normal IPv4 receive path, ip_rcv() trims the packet to ip_hdr->tot_len before invoking netfilter hooks. In the IPv6 receive path, ip6_rcv() does the same using ipv6_hdr->payload_len. Similarly in the br_netfilter receive path, br_validate_ipv4() and br_validate_ipv6() trim the packet to the L3 length before invoking netfilter hooks. Currently in the OVS conntrack receive path, ovs_ct_execute() pulls the skb to the L3 header but does not trim it to the L3 length before calling nf_conntrack_in(NF_INET_PRE_ROUTING). When nf_conntrack_proto_tcp encounters a packet with lower-layer padding, nf_ip_checksum() fails causing a "nf_ct_tcp: bad TCP checksum" log message. While extra zero bytes don't affect the checksum, the length in the IP pseudoheader does. That length is based on skb->len, and without trimming, it doesn't match the length the sender used when computing the checksum. In ovs_ct_execute(), trim the skb to the L3 length before higher-layer processing. Signed-off-by: Ed Swierk Acked-by: Pravin B Shelar Signed-off-by: David S. Miller Cc: Ed Swierk Signed-off-by: Greg Rose Acked-by: Pravin B Shelar Compare: https://github.com/openvswitch/ovs/compare/3774206996c8...a948fa4b1ea3 From noreply at github.com Fri Feb 16 08:49:57 2018 From: noreply at github.com (GitHub) Date: Fri, 16 Feb 2018 00:49:57 -0800 Subject: [ovs-git] [openvswitch/ovs] 27521c: datapath: do not propagate headroom updates to int... Message-ID: <5a869b3514816_567c2ae82c43fc081271aa@hookshot-fe-2cc8887.cp1-iad.github.net.mail> Branch: refs/heads/branch-2.8 Home: https://github.com/openvswitch/ovs Commit: 27521ce4c7d2177a36fc676851c4aa9e04bb2872 https://github.com/openvswitch/ovs/commit/27521ce4c7d2177a36fc676851c4aa9e04bb2872 Author: paolo abeni Date: 2018-02-16 (Fri, 16 Feb 2018) Changed paths: M datapath/vport-internal_dev.c Log Message: ----------- datapath: do not propagate headroom updates to internal port Upstream commit: commit 183dea5818315c0a172d21ecbcd2554894bf01e3 Author: Paolo Abeni Date: Thu Nov 30 15:35:33 2017 +0100 openvswitch: do not propagate headroom updates to internal port After commit 3a927bc7cf9d ("ovs: propagate per dp max headroom to all vports") the need_headroom for the internal vport is updated accordingly to the max needed headroom in its datapath. That avoids the pskb_expand_head() costs when sending/forwarding packets towards tunnel devices, at least for some scenarios. We still require such copy when using the ovs-preferred configuration for vxlan tunnels: br_int / \ tap vxlan (remote_ip:X) br_phy \ NIC where the route towards the IP 'X' is via 'br_phy'. When forwarding traffic from the tap towards the vxlan device, we will call pskb_expand_head() in vxlan_build_skb() because br-phy->needed_headroom is equal to tun->needed_headroom. With this change we avoid updating the internal vport needed_headroom, so that in the above scenario no head copy is needed, giving 5% performance improvement in UDP throughput test. As a trade-off, packets sent from the internal port towards a tunnel device will now experience the head copy overhead. The rationale is that the latter use-case is less relevant performance-wise. Signed-off-by: paolo abeni Acked-by: Pravin B Shelar Signed-off-by: David S. Miller Cc: paolo abeni Signed-off-by: Greg Rose Acked-by: Pravin B Shelar Commit: 33624929f0e25c3994eb1ef15fbfa90a234b416b https://github.com/openvswitch/ovs/commit/33624929f0e25c3994eb1ef15fbfa90a234b416b Author: Eric Garver Date: 2018-02-16 (Fri, 16 Feb 2018) Changed paths: M datapath/flow.c Log Message: ----------- datapath: Fix pop_vlan action for double tagged frames Upstream commit: commit c48e74736fccf25fb32bb015426359e1c2016e3b Author: Eric Garver Date: Wed Dec 20 15:09:22 2017 -0500 openvswitch: Fix pop_vlan action for double tagged frames skb_vlan_pop() expects skb->protocol to be a valid TPID for double tagged frames. So set skb->protocol to the TPID and let skb_vlan_pop() shift the true ethertype into position for us. Fixes: 5108bbaddc37 ("openvswitch: add processing of L3 packets") Signed-off-by: Eric Garver Reviewed-by: Jiri Benc Signed-off-by: David S. Miller Cc: Eric Garver Fixes: a27c454ee0 ("datapath: add processing of L3 packets") Signed-off-by: Greg Rose Acked-by: Pravin B Shelar Commit: 17f51c6a96e79b092aa8b03b60986c0ba8b31c10 https://github.com/openvswitch/ovs/commit/17f51c6a96e79b092aa8b03b60986c0ba8b31c10 Author: Ed Swierk Date: 2018-02-16 (Fri, 16 Feb 2018) Changed paths: M datapath/conntrack.c Log Message: ----------- datapath: Remove padding from packet before L3+ conntrack processing Upstream commit: commit 9382fe71c0058465e942a633869629929102843d Author: Ed Swierk Date: Wed Jan 31 18:48:02 2018 -0800 openvswitch: Remove padding from packet before L3+ conntrack processing IPv4 and IPv6 packets may arrive with lower-layer padding that is not included in the L3 length. For example, a short IPv4 packet may have up to 6 bytes of padding following the IP payload when received on an Ethernet device with a minimum packet length of 64 bytes. Higher-layer processing functions in netfilter (e.g. nf_ip_checksum(), and help() in nf_conntrack_ftp) assume skb->len reflects the length of the L3 header and payload, rather than referring back to ip_hdr->tot_len or ipv6_hdr->payload_len, and get confused by lower-layer padding. In the normal IPv4 receive path, ip_rcv() trims the packet to ip_hdr->tot_len before invoking netfilter hooks. In the IPv6 receive path, ip6_rcv() does the same using ipv6_hdr->payload_len. Similarly in the br_netfilter receive path, br_validate_ipv4() and br_validate_ipv6() trim the packet to the L3 length before invoking netfilter hooks. Currently in the OVS conntrack receive path, ovs_ct_execute() pulls the skb to the L3 header but does not trim it to the L3 length before calling nf_conntrack_in(NF_INET_PRE_ROUTING). When nf_conntrack_proto_tcp encounters a packet with lower-layer padding, nf_ip_checksum() fails causing a "nf_ct_tcp: bad TCP checksum" log message. While extra zero bytes don't affect the checksum, the length in the IP pseudoheader does. That length is based on skb->len, and without trimming, it doesn't match the length the sender used when computing the checksum. In ovs_ct_execute(), trim the skb to the L3 length before higher-layer processing. Signed-off-by: Ed Swierk Acked-by: Pravin B Shelar Signed-off-by: David S. Miller Cc: Ed Swierk Signed-off-by: Greg Rose Acked-by: Pravin B Shelar Compare: https://github.com/openvswitch/ovs/compare/dbc6cbc08abe...17f51c6a96e7 From noreply at github.com Fri Feb 16 23:03:00 2018 From: noreply at github.com (GitHub) Date: Fri, 16 Feb 2018 15:03:00 -0800 Subject: [ovs-git] [openvswitch/ovs] 7080b4: ovs-ofctl: Make ofp-print able to read raw data fr... Message-ID: <5a876324282f9_2c622ae7d7f0bc1878615@hookshot-fe-b0febf1.cp1-iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/openvswitch/ovs Commit: 7080b4a268b814775c008dab6a2f957923820e37 https://github.com/openvswitch/ovs/commit/7080b4a268b814775c008dab6a2f957923820e37 Author: Ben Pfaff Date: 2018-02-16 (Fri, 16 Feb 2018) Changed paths: M utilities/ovs-ofctl.c Log Message: ----------- ovs-ofctl: Make ofp-print able to read raw data from a file. Occasionally someone sends me raw OpenFlow data in a file and this saves time converting it to hex. Signed-off-by: Ben Pfaff Reviewed-by: Yifeng Sun From noreply at github.com Fri Feb 16 23:04:09 2018 From: noreply at github.com (GitHub) Date: Fri, 16 Feb 2018 15:04:09 -0800 Subject: [ovs-git] [openvswitch/ovs] 8b70d8: ofp-meter: Fix use-after-free for decoding meter m... Message-ID: <5a8763695c65b_3f642ab43532dc14153161@hookshot-fe-da92815.cp1-iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/openvswitch/ovs Commit: 8b70d82461ea104858ebd7d397ec004f6974240b https://github.com/openvswitch/ovs/commit/8b70d82461ea104858ebd7d397ec004f6974240b Author: Ben Pfaff Date: 2018-02-16 (Fri, 16 Feb 2018) Changed paths: M lib/ofp-meter.c Log Message: ----------- ofp-meter: Fix use-after-free for decoding meter mods. ofputil_pull_bands() may change bands->data. Found by libfuzzer-ngram. Reported-by: Bhargava Shastry Signed-off-by: Ben Pfaff Reviewed-by: Yifeng Sun From noreply at github.com Fri Feb 16 23:05:51 2018 From: noreply at github.com (GitHub) Date: Fri, 16 Feb 2018 15:05:51 -0800 Subject: [ovs-git] [openvswitch/ovs] f4775b: ofp-meter: Fix use-after-free for decoding meter m... Message-ID: <5a8763cf646d5_746a2ac2c64d3c0438989@hookshot-fe-88eb02d.cp1-iad.github.net.mail> Branch: refs/heads/branch-2.9 Home: https://github.com/openvswitch/ovs Commit: f4775bbd4f4aabe24379953b584bc04341a95cef https://github.com/openvswitch/ovs/commit/f4775bbd4f4aabe24379953b584bc04341a95cef Author: Ben Pfaff Date: 2018-02-16 (Fri, 16 Feb 2018) Changed paths: M lib/ofp-util.c Log Message: ----------- ofp-meter: Fix use-after-free for decoding meter mods. ofputil_pull_bands() may change bands->data. Found by libfuzzer-ngram. Reported-by: Bhargava Shastry Signed-off-by: Ben Pfaff Reviewed-by: Yifeng Sun From noreply at github.com Fri Feb 16 23:06:05 2018 From: noreply at github.com (GitHub) Date: Fri, 16 Feb 2018 15:06:05 -0800 Subject: [ovs-git] [openvswitch/ovs] f45e52: ofp-meter: Fix use-after-free for decoding meter m... Message-ID: <5a8763dd70c78_2b5cb2ade9caf9c04996b8@hookshot-fe-dfcc362.cp1-iad.github.net.mail> Branch: refs/heads/branch-2.8 Home: https://github.com/openvswitch/ovs Commit: f45e528e1698d50a2885df9947cee48644eedb53 https://github.com/openvswitch/ovs/commit/f45e528e1698d50a2885df9947cee48644eedb53 Author: Ben Pfaff Date: 2018-02-16 (Fri, 16 Feb 2018) Changed paths: M lib/ofp-util.c Log Message: ----------- ofp-meter: Fix use-after-free for decoding meter mods. ofputil_pull_bands() may change bands->data. Found by libfuzzer-ngram. Reported-by: Bhargava Shastry Signed-off-by: Ben Pfaff Reviewed-by: Yifeng Sun From noreply at github.com Fri Feb 16 23:06:10 2018 From: noreply at github.com (GitHub) Date: Fri, 16 Feb 2018 15:06:10 -0800 Subject: [ovs-git] [openvswitch/ovs] 02c12c: ofp-meter: Fix use-after-free for decoding meter m... Message-ID: <5a8763e2222a1_733e2af48c89dc0c88623@hookshot-fe-d2afb11.cp1-iad.github.net.mail> Branch: refs/heads/branch-2.7 Home: https://github.com/openvswitch/ovs Commit: 02c12c27e97220e9874b11392c7850aa9ff77173 https://github.com/openvswitch/ovs/commit/02c12c27e97220e9874b11392c7850aa9ff77173 Author: Ben Pfaff Date: 2018-02-16 (Fri, 16 Feb 2018) Changed paths: M lib/ofp-util.c Log Message: ----------- ofp-meter: Fix use-after-free for decoding meter mods. ofputil_pull_bands() may change bands->data. Found by libfuzzer-ngram. Reported-by: Bhargava Shastry Signed-off-by: Ben Pfaff Reviewed-by: Yifeng Sun From noreply at github.com Fri Feb 16 23:06:14 2018 From: noreply at github.com (GitHub) Date: Fri, 16 Feb 2018 15:06:14 -0800 Subject: [ovs-git] [openvswitch/ovs] 8208b7: ofp-meter: Fix use-after-free for decoding meter m... Message-ID: <5a8763e6c4f93_75082afb743c5c041201c@hookshot-fe-d2afb11.cp1-iad.github.net.mail> Branch: refs/heads/branch-2.6 Home: https://github.com/openvswitch/ovs Commit: 8208b7a58f31a1a1c65f60550738b58fd5003ae9 https://github.com/openvswitch/ovs/commit/8208b7a58f31a1a1c65f60550738b58fd5003ae9 Author: Ben Pfaff Date: 2018-02-16 (Fri, 16 Feb 2018) Changed paths: M lib/ofp-util.c Log Message: ----------- ofp-meter: Fix use-after-free for decoding meter mods. ofputil_pull_bands() may change bands->data. Found by libfuzzer-ngram. Reported-by: Bhargava Shastry Signed-off-by: Ben Pfaff Reviewed-by: Yifeng Sun From noreply at github.com Fri Feb 16 23:06:19 2018 From: noreply at github.com (GitHub) Date: Fri, 16 Feb 2018 15:06:19 -0800 Subject: [ovs-git] [openvswitch/ovs] 75a457: ofp-meter: Fix use-after-free for decoding meter m... Message-ID: <5a8763ebc6f5_3f3d2b291f937c1812554a@hookshot-fe-da92815.cp1-iad.github.net.mail> Branch: refs/heads/branch-2.5 Home: https://github.com/openvswitch/ovs Commit: 75a4571ae02ead264bb9a5660da59195f56baee9 https://github.com/openvswitch/ovs/commit/75a4571ae02ead264bb9a5660da59195f56baee9 Author: Ben Pfaff Date: 2018-02-16 (Fri, 16 Feb 2018) Changed paths: M lib/ofp-util.c Log Message: ----------- ofp-meter: Fix use-after-free for decoding meter mods. ofputil_pull_bands() may change bands->data. Found by libfuzzer-ngram. Reported-by: Bhargava Shastry Signed-off-by: Ben Pfaff Reviewed-by: Yifeng Sun From noreply at github.com Fri Feb 16 23:06:28 2018 From: noreply at github.com (GitHub) Date: Fri, 16 Feb 2018 15:06:28 -0800 Subject: [ovs-git] [openvswitch/ovs] d46c43: ofp-meter: Fix use-after-free for decoding meter m... Message-ID: <5a8763f44317_659e2aaab4b43c08805cd@hookshot-fe-d252ca1.cp1-iad.github.net.mail> Branch: refs/heads/branch-2.4 Home: https://github.com/openvswitch/ovs Commit: d46c43b07880c2f35ca8cc80ddb68e4db8c01745 https://github.com/openvswitch/ovs/commit/d46c43b07880c2f35ca8cc80ddb68e4db8c01745 Author: Ben Pfaff Date: 2018-02-16 (Fri, 16 Feb 2018) Changed paths: M lib/ofp-util.c Log Message: ----------- ofp-meter: Fix use-after-free for decoding meter mods. ofputil_pull_bands() may change bands->data. Found by libfuzzer-ngram. Reported-by: Bhargava Shastry Signed-off-by: Ben Pfaff Reviewed-by: Yifeng Sun From noreply at github.com Fri Feb 16 23:10:09 2018 From: noreply at github.com (GitHub) Date: Fri, 16 Feb 2018 15:10:09 -0800 Subject: [ovs-git] [openvswitch/ovs] 0ea866: ovsdb-idlc: Add "cDecls" and "hDecls" IDL schema e... Message-ID: <5a8764d12e550_47ea2af96224bc0c1301b@hookshot-fe-6e9b612.cp1-iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/openvswitch/ovs Commit: 0ea866bbc0fb8cd10d2b86fa0ed6f1abd864a5b9 https://github.com/openvswitch/ovs/commit/0ea866bbc0fb8cd10d2b86fa0ed6f1abd864a5b9 Author: Ben Pfaff Date: 2018-02-16 (Fri, 16 Feb 2018) Changed paths: M ovsdb/ovsdb-idlc.1 M ovsdb/ovsdb-idlc.in M python/ovs/db/schema.py Log Message: ----------- ovsdb-idlc: Add "cDecls" and "hDecls" IDL schema extensions. An IDL schema is an OVSDB schema with some extra stuff in it: an idlPrefix and an idlHeader at the top level to indicate what ovsdb-idlc needs to generate the interface definitions. This commit adds support for two more optional IDL schema extensions that allow extra code to be written to the .c and .h file that ovsdb-idlc generates. Signed-off-by: Ben Pfaff Commit: 00386a6921329d3449a93d536f86a756dedb14b3 https://github.com/openvswitch/ovs/commit/00386a6921329d3449a93d536f86a756dedb14b3 Author: Ben Pfaff Date: 2018-02-16 (Fri, 16 Feb 2018) Changed paths: M ovsdb/ovsdb-idlc.1 M python/ovs/db/schema.py Log Message: ----------- ovsdb-idlc: Add infrastructure for IDL schema extensions. An IDL schema is an OVSDB schema with some extra stuff in it. So far, all of the extras have been at the top level. This commit makes it possible for IDL schemas to have extra information at the table and column levels as long as it is in an "extensions" member. No extensions are actually supported yet. Signed-off-by: Ben Pfaff Commit: 01928c964f572fb0551c999437557458f326be3e https://github.com/openvswitch/ovs/commit/01928c964f572fb0551c999437557458f326be3e Author: Ben Pfaff Date: 2018-02-16 (Fri, 16 Feb 2018) Changed paths: M lib/ovsdb-idl-provider.h M lib/ovsdb-idl.c M ovsdb/ovsdb-idlc.1 M ovsdb/ovsdb-idlc.in Log Message: ----------- ovsdb-idlc: Implement synthetic columns. A synthetic column is one that is not present in the actual database but instead calculated by code in the client based on columns in the row. This can be useful to avoid repeatedly calculating the same function of a row. Signed-off-by: Ben Pfaff Commit: 8bf332225d4a73f359c806ad907bcb78ad2a6087 https://github.com/openvswitch/ovs/commit/8bf332225d4a73f359c806ad907bcb78ad2a6087 Author: Ben Pfaff Date: 2018-02-16 (Fri, 16 Feb 2018) Changed paths: M ovn/lib/ovn-sb-idl.ann M ovn/lib/ovn-util.c M ovn/lib/ovn-util.h M ovn/northd/ovn-northd.c Log Message: ----------- ovn-northd: Reduce amount of flow hashing. Jakub Sitnicki demonstrated that repeatedly calculating row hashes is expensive, so this should improve ovn-northd performance. Reported-by: Jakub Sitnicki Reported-at: https://mail.openvswitch.org/pipermail/ovs-dev/2018-February/344404.html Signed-off-by: Ben Pfaff Tested-by: Jakub Sitnicki Compare: https://github.com/openvswitch/ovs/compare/8b70d82461ea...8bf332225d4a From noreply at github.com Fri Feb 16 23:31:21 2018 From: noreply at github.com (GitHub) Date: Fri, 16 Feb 2018 15:31:21 -0800 Subject: [ovs-git] [openvswitch/ovs] d3d320: odp.at: fix sed string matching typo. Message-ID: <5a8769c988c5_5f8c2b047f9b9c00125152@hookshot-fe-32b5f5b.cp1-iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/openvswitch/ovs Commit: d3d320770212132630ef942e7d2bde094f8250be https://github.com/openvswitch/ovs/commit/d3d320770212132630ef942e7d2bde094f8250be Author: William Tu Date: 2018-02-16 (Fri, 16 Feb 2018) Changed paths: M tests/odp.at Log Message: ----------- odp.at: fix sed string matching typo. Replace 'set' with 'sed'. Signed-off-by: William Tu Signed-off-by: Ben Pfaff From noreply at github.com Mon Feb 19 22:38:17 2018 From: noreply at github.com (GitHub) Date: Mon, 19 Feb 2018 14:38:17 -0800 Subject: [ovs-git] [openvswitch/ovs] ba4400: Set release date for 2.8.2. Message-ID: <5a8b51d9a6993_4ce72abb044b9bfc160296@hookshot-fe-6e9b612.cp1-iad.github.net.mail> Branch: refs/heads/branch-2.8 Home: https://github.com/openvswitch/ovs Commit: ba44001de6c2cb43ae635092628fe2c66f30e4fc https://github.com/openvswitch/ovs/commit/ba44001de6c2cb43ae635092628fe2c66f30e4fc Author: Justin Pettit Date: 2018-02-19 (Mon, 19 Feb 2018) Changed paths: M NEWS M debian/changelog Log Message: ----------- Set release date for 2.8.2. Signed-off-by: Justin Pettit Acked-by: Aaron Conole Acked-by: Flavio Leitner Commit: 470d76acd61b974c88fa7a1283bfd68513db6c4e https://github.com/openvswitch/ovs/commit/470d76acd61b974c88fa7a1283bfd68513db6c4e Author: Justin Pettit Date: 2018-02-19 (Mon, 19 Feb 2018) Changed paths: M NEWS M configure.ac M debian/changelog Log Message: ----------- Prepare for 2.8.3. Signed-off-by: Justin Pettit Acked-by: Aaron Conole Acked-by: Flavio Leitner Compare: https://github.com/openvswitch/ovs/compare/f45e528e1698...470d76acd61b From noreply at github.com Mon Feb 19 22:41:56 2018 From: noreply at github.com (GitHub) Date: Mon, 19 Feb 2018 14:41:56 -0800 Subject: [ovs-git] [openvswitch/ovs] 430d7d: Set release dates for 2.9.0. Message-ID: <5a8b52b457df3_43e42b1380877bfc125333@hookshot-fe-cace476.cp1-iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/openvswitch/ovs Commit: 430d7d1560ce3d3f3ccb9a0a323a2c383b7604ea https://github.com/openvswitch/ovs/commit/430d7d1560ce3d3f3ccb9a0a323a2c383b7604ea Author: Justin Pettit Date: 2018-02-19 (Mon, 19 Feb 2018) Changed paths: M NEWS M debian/changelog Log Message: ----------- Set release dates for 2.9.0. Signed-off-by: Justin Pettit From noreply at github.com Mon Feb 19 22:56:51 2018 From: noreply at github.com (GitHub) Date: Mon, 19 Feb 2018 14:56:51 -0800 Subject: [ovs-git] [openvswitch/ovs] bd916d: Set release dates for 2.9.0. Message-ID: <5a8b5633a5adb_255b2ae6aefe1c0c116035@hookshot-fe-265448d.cp1-iad.github.net.mail> Branch: refs/heads/branch-2.9 Home: https://github.com/openvswitch/ovs Commit: bd916d13dbb845746983a6780da772154df647ba https://github.com/openvswitch/ovs/commit/bd916d13dbb845746983a6780da772154df647ba Author: Justin Pettit Date: 2018-02-19 (Mon, 19 Feb 2018) Changed paths: M NEWS M debian/changelog Log Message: ----------- Set release dates for 2.9.0. Signed-off-by: Justin Pettit From noreply at github.com Mon Feb 19 23:05:39 2018 From: noreply at github.com (GitHub) Date: Mon, 19 Feb 2018 15:05:39 -0800 Subject: [ovs-git] [openvswitch/ovs] 92cc82: Prepare for 2.9.1. Message-ID: <5a8b5843d5d94_2b1e82ae1b667bc00571cb@hookshot-fe-dfcc362.cp1-iad.github.net.mail> Branch: refs/heads/branch-2.9 Home: https://github.com/openvswitch/ovs Commit: 92cc824471f5bdd5bb763a01b072b8ffbd80b93e https://github.com/openvswitch/ovs/commit/92cc824471f5bdd5bb763a01b072b8ffbd80b93e Author: Justin Pettit Date: 2018-02-19 (Mon, 19 Feb 2018) Changed paths: M NEWS M configure.ac M debian/changelog Log Message: ----------- Prepare for 2.9.1. Signed-off-by: Justin Pettit Acked-by: Aaron Conole From noreply at github.com Tue Feb 20 15:46:18 2018 From: noreply at github.com (GitHub) Date: Tue, 20 Feb 2018 07:46:18 -0800 Subject: [ovs-git] [openvswitch/ovs] Message-ID: <5a8c42ca9fbf3_71ae2aff60999c1c14548b@hookshot-fe-6e9b612.cp1-iad.github.net.mail> Branch: refs/tags/v2.9.0 Home: https://github.com/openvswitch/ovs From noreply at github.com Tue Feb 20 15:47:19 2018 From: noreply at github.com (GitHub) Date: Tue, 20 Feb 2018 07:47:19 -0800 Subject: [ovs-git] [openvswitch/ovs] Message-ID: <5a8c43079d817_4f3d2ab48e03fc1097536@hookshot-fe-6e9b612.cp1-iad.github.net.mail> Branch: refs/tags/v2.8.2 Home: https://github.com/openvswitch/ovs From noreply at github.com Wed Feb 21 18:42:13 2018 From: noreply at github.com (GitHub) Date: Wed, 21 Feb 2018 10:42:13 -0800 Subject: [ovs-git] [openvswitch/ovs] 93ca7e: ofp-parse: Include missing ofp-actions.h. Message-ID: <5a8dbd85b9fdb_55922ab504079c14108537@hookshot-fe-6b2eebc.cp1-iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/openvswitch/ovs Commit: 93ca7e55a208a6b59dac0e0de5cbcd7c0433dcf3 https://github.com/openvswitch/ovs/commit/93ca7e55a208a6b59dac0e0de5cbcd7c0433dcf3 Author: Ilya Maximets Date: 2018-02-21 (Wed, 21 Feb 2018) Changed paths: M lib/ofp-parse.c Log Message: ----------- ofp-parse: Include missing ofp-actions.h. This fixes MacOS build: lib/ofp-parse.c:167:16: error: use of undeclared identifier 'IPPORT_FTP' lib/ofp-parse.c:171:16: error: use of undeclared identifier 'IPPORT_TFTP' CC: Ben Pfaff Fixes: 0d71302e36c4 ("ofp-util, ofp-parse: Break up into many separate modules.") Signed-off-by: Ilya Maximets Signed-off-by: Ben Pfaff From noreply at github.com Fri Feb 23 22:08:57 2018 From: noreply at github.com (GitHub) Date: Fri, 23 Feb 2018 14:08:57 -0800 Subject: [ovs-git] [openvswitch/ovs] d7a176: ovsdb: Use items() instead of iteritems() for Pyth... Message-ID: <5a9090f9937ed_72992aef78ff7c1410395@hookshot-fe-6b2eebc.cp1-iad.github.net.mail> Branch: refs/heads/branch-2.8 Home: https://github.com/openvswitch/ovs Commit: d7a1767c61155309b332e9a0512f145fecf52b9a https://github.com/openvswitch/ovs/commit/d7a1767c61155309b332e9a0512f145fecf52b9a Author: Markos Chandras Date: 2018-02-23 (Fri, 23 Feb 2018) Changed paths: M ovsdb/ovsdb-dot.in M ovsdb/ovsdb-idlc.in Log Message: ----------- ovsdb: Use items() instead of iteritems() for Python3 Python3 removed the iteritems() iterator and replaced it with items() which should also work in Python2. This fixes the following build problem on Python3: Traceback (most recent call last): File "./ovsdb/ovsdb-idlc.in", line 1436, in func(*args[1:]) File "./ovsdb/ovsdb-idlc.in", line 314, in printCIDLHeader for columnName, column in sorted(table.columns.iteritems()): AttributeError: 'dict' object has no attribute 'iteritems' Signed-off-by: Markos Chandras Signed-off-by: Ben Pfaff Commit: 54948553b8060b720951d5bc0a6ba24cda2c9ebd https://github.com/openvswitch/ovs/commit/54948553b8060b720951d5bc0a6ba24cda2c9ebd Author: Markos Chandras Date: 2018-02-23 (Fri, 23 Feb 2018) Changed paths: M ovsdb/ovsdb-dot.in Log Message: ----------- ovsdb: ovsdb-dot.in: Use print function for Python3 The python2 print statement no longer works in python3 since the latter uses a print function. As such, replace all instances of 'print' with 'print()'. This fixes the following build problem with python3 > ovsdb/ovsdb-client.1.tmp File "./ovsdb/ovsdb-dot.in", line 34 print "\t%s -> %s [%s];" % ( ^ SyntaxError: invalid syntax Signed-off-by: Markos Chandras Signed-off-by: Ben Pfaff Commit: 825cbf73f444d625d59bf07329a23f6d3d1957d4 https://github.com/openvswitch/ovs/commit/825cbf73f444d625d59bf07329a23f6d3d1957d4 Author: Markos Chandras Date: 2018-02-23 (Fri, 23 Feb 2018) Changed paths: M ovsdb/ovsdb-dot.in Log Message: ----------- ovsdb: ovsdb-dot.in: Change exception semantics for Python3 PEP-3110 changes the semantics for capturing exceptions in Python3 from 'except E,N' to 'except E as N'. This fixes the following problem when building with python3 SyntaxError: invalid syntax File "./ovsdb/ovsdb-dot.in", line 106 except ovs.db.error.Error, e: ^ SyntaxError: invalid syntax Link: https://www.python.org/dev/peps/pep-3110/ Signed-off-by: Markos Chandras Signed-off-by: Ben Pfaff Commit: 28f53188135fd61c0c8067d56105d469e97a16a7 https://github.com/openvswitch/ovs/commit/28f53188135fd61c0c8067d56105d469e97a16a7 Author: Markos Chandras Date: 2018-02-23 (Fri, 23 Feb 2018) Changed paths: M ovsdb/ovsdb-dot.in Log Message: ----------- ovsdb: ovsdb-dot.in: Replace sys.maxint with sys.maxsize for Python3 There is no sys.maxint anymore on python3. However, sys.maxsize can be used as an integer larger than any practical list or string index. Link: https://docs.python.org/3.1/whatsnew/3.0.html#integers Signed-off-by: Markos Chandras Signed-off-by: Ben Pfaff Compare: https://github.com/openvswitch/ovs/compare/470d76acd61b...28f53188135f From noreply at github.com Fri Feb 23 22:10:24 2018 From: noreply at github.com (GitHub) Date: Fri, 23 Feb 2018 14:10:24 -0800 Subject: [ovs-git] [openvswitch/ovs] bae2b2: ip_tunnels: Fix grammar error. Message-ID: <5a9091503893b_57a72b0b53095c0c158556@hookshot-fe-2cc8887.cp1-iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/openvswitch/ovs Commit: bae2b2d9ff99976586d017f91183353f3b21e44a https://github.com/openvswitch/ovs/commit/bae2b2d9ff99976586d017f91183353f3b21e44a Author: William Tu Date: 2018-02-23 (Fri, 23 Feb 2018) Changed paths: M datapath/linux/compat/include/net/ip_tunnels.h Log Message: ----------- ip_tunnels: Fix grammar error. Trivial grammar fix. Signed-off-by: William Tu Signed-off-by: Ben Pfaff Reviewed-by: Greg Rose From noreply at github.com Fri Feb 23 22:19:41 2018 From: noreply at github.com (GitHub) Date: Fri, 23 Feb 2018 14:19:41 -0800 Subject: [ovs-git] [openvswitch/ovs] eb84cc: AUTHORS: update e-mail address of Zoltan Balogh Message-ID: <5a90937d981f_5d092abe06cd5c001078f7@hookshot-fe-5a11256.cp1-iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/openvswitch/ovs Commit: eb84ccc3e8613c35dc1c637ea1b357eb4eb7d25f https://github.com/openvswitch/ovs/commit/eb84ccc3e8613c35dc1c637ea1b357eb4eb7d25f Author: Zoltan Balogh Date: 2018-02-23 (Fri, 23 Feb 2018) Changed paths: M AUTHORS.rst Log Message: ----------- AUTHORS: update e-mail address of Zoltan Balogh Signed-off-by: Zoltan Balogh CC: Zoltan Balogh Signed-off-by: Ben Pfaff From noreply at github.com Sat Feb 24 02:20:47 2018 From: noreply at github.com (GitHub) Date: Fri, 23 Feb 2018 18:20:47 -0800 Subject: [ovs-git] [openvswitch/ovs] ee29e9: selinux: add a new target to build the policy Message-ID: <5a90cbff41a5b_2af5c2abf7f1f3c1895773@hookshot-fe-dfcc362.cp1-iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/openvswitch/ovs Commit: ee29e9feb235136f0055c124d87bd9a68bf8e71a https://github.com/openvswitch/ovs/commit/ee29e9feb235136f0055c124d87bd9a68bf8e71a Author: Aaron Conole Date: 2018-02-23 (Fri, 23 Feb 2018) Changed paths: M rhel/openvswitch-fedora.spec.in M rhel/openvswitch.spec.in M selinux/automake.mk Log Message: ----------- selinux: add a new target to build the policy The selinux policy currently builds manually, as a process that either the user or distribution maintainer undertakes. That process consists of: 1. Convert the intermediary files into their file form through 'make' statements at the top level. 2. Change to the selinux directory and issue the selinux "make -f" directive. This commit introduces a new target 'selinux-policy' which builds the openvswitch-custom policy files. Signed-off-by: Aaron Conole Acked-by: Ansis Atteka Commit: ee1c7296ece67b5b35e528620c645a9c3f2a5c16 https://github.com/openvswitch/ovs/commit/ee1c7296ece67b5b35e528620c645a9c3f2a5c16 Author: Aaron Conole Date: 2018-02-23 (Fri, 23 Feb 2018) Changed paths: M selinux/openvswitch-custom.te.in Log Message: ----------- selinux: allow dpdkvhostuserclient sockets with newer libvirt Newer libvirt and openstack versions will now label the unix socket as an `svirt_tmpfs_t` object. This means that in order to support deploying with the recommended configuration (using a dpdkvhostuserclient socket), additional permissions need to be installed as part of the selinux policy. An example of some of the AVC violations: type=AVC msg=audit(1518752799.102:978): avc: denied { write } for pid=14368 comm="ovs-vswitchd" name="vhost0" dev="dm-0" ino=94 scontext=system_u:system_r:openvswitch_t:s0 tcontext=system_u:object_r:svirt_tmp_t:s0 tclass=sock_file type=AVC msg=audit(1518816172.126:1318): avc: denied { connectto } for pid=32717 comm="ovs-vswitchd" path="/tmp/vhost0" scontext=system_u:system_r:openvswitch_t:s0 tcontext=system_u:system_r:svirt_t:s0:c106,c530 tclass=unix_stream_socket Signed-off-by: Aaron Conole Acked-by: Ansis Atteka Compare: https://github.com/openvswitch/ovs/compare/eb84ccc3e861...ee1c7296ece6 From noreply at github.com Mon Feb 26 19:36:07 2018 From: noreply at github.com (GitHub) Date: Mon, 26 Feb 2018 11:36:07 -0800 Subject: [ovs-git] [openvswitch/ovs] c381bc: ofproto: Make ofproto_port_open_type() faster. Message-ID: <5a9461a7728cd_493d2ac575e53c1469858@hookshot-fe-5a11256.cp1-iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/openvswitch/ovs Commit: c381bca52f629f3d35f00471dcd10cba1a9a3d99 https://github.com/openvswitch/ovs/commit/c381bca52f629f3d35f00471dcd10cba1a9a3d99 Author: Ben Pfaff Date: 2018-02-26 (Mon, 26 Feb 2018) Changed paths: M ofproto/in-band.c M ofproto/ofproto.c M ofproto/ofproto.h M vswitchd/bridge.c Log Message: ----------- ofproto: Make ofproto_port_open_type() faster. ofproto_port_open_type() was surprisingly slow because it called the function ofproto_class_find__(), which itself was surprisingly slow because it actually creates a set of strings and enumerates all of the available classes. This patch improves performance by eliminating the call to ofproto_class_find__() from ofproto_port_open_type(). In turn that required changing a parameter type and updating all the callers. Possibly it would be worth making ofproto_class_find__() itself faster, but it doesn't look like any of its other callers would be used in inner loops. For more background, see also https://mail.openvswitch.org/pipermail/ovs-discuss/2018-February/046140.html This patch arises as a result of testing done by Ali Ginwala and Han Zhou. Their test showed that commit 2d4beba resulted in slower performance of ovs-vswitchd than was seen in previous versions of OVS. With this patch, Ali retested and reported that performance drastically improved by ~60%. The test for 10k lports, 40 LSs and 8 LRs and 1k HVs just got completed in 3 hours 39 min vs 8+ hours for branch-2.9. Cpu utilization graph of a farm comparing Ben's ofproto patch vs branch-2.9 is available @ https://raw.githubusercontent.com/noah8713/ovn-scale-test/scale_results/results/ovs_2.9_vs_ben_ofproto.png Reported-by: Mark Michelson Acked-by: Mark Michelson Tested-by: aginwala Signed-off-by: Ben Pfaff From noreply at github.com Mon Feb 26 19:44:42 2018 From: noreply at github.com (GitHub) Date: Mon, 26 Feb 2018 11:44:42 -0800 Subject: [ovs-git] [openvswitch/ovs] 48b100: cmap: Fix bug in CMAP_FOR_EACH_WITH_HASH_PROTECTED... Message-ID: <5a9463aac8466_7e082ab4e07b9c143672a@hookshot-fe-da92815.cp1-iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/openvswitch/ovs Commit: 48b1008c0b97518ee3c409969bab8588cf4b090e https://github.com/openvswitch/ovs/commit/48b1008c0b97518ee3c409969bab8588cf4b090e Author: zhangliping Date: 2018-02-26 (Mon, 26 Feb 2018) Changed paths: M lib/cmap.h Log Message: ----------- cmap: Fix bug in CMAP_FOR_EACH_WITH_HASH_PROTECTED. cmap_find_locked() should be cmap_find_protected(). This does not fix a user-visible bug because this macro did not have any users. Signed-off-by: zhangliping Signed-off-by: Ben Pfaff Acked-by: Mark Michelson From noreply at github.com Mon Feb 26 19:52:52 2018 From: noreply at github.com (GitHub) Date: Mon, 26 Feb 2018 11:52:52 -0800 Subject: [ovs-git] [openvswitch/ovs] 9fee0a: vlog: fix the incorrect zero padding in format_log... Message-ID: <5a94659478a4f_1cfe2b215e5c5c10602cc@hookshot-fe-7191cb1.cp1-iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/openvswitch/ovs Commit: 9fee0a6b40ad52ca141bf0e015351549f6928e09 https://github.com/openvswitch/ovs/commit/9fee0a6b40ad52ca141bf0e015351549f6928e09 Author: zhangliping Date: 2018-02-26 (Mon, 26 Feb 2018) Changed paths: M lib/vlog.c Log Message: ----------- vlog: fix the incorrect zero padding in format_log_message If the format specifier does not have the 0 flag, we should pad with blanks instead of zeroes. Signed-off-by: zhangliping Signed-off-by: Ben Pfaff From noreply at github.com Mon Feb 26 19:53:13 2018 From: noreply at github.com (GitHub) Date: Mon, 26 Feb 2018 11:53:13 -0800 Subject: [ovs-git] [openvswitch/ovs] c9bc8c: vlog: fix the incorrect zero padding in format_log... Message-ID: <5a9465a9b7b1c_4c4a2ae97c39fc0c1635c@hookshot-fe-88eb02d.cp1-iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/openvswitch/ovs Commit: c9bc8c110eda65a36a958bc7ad7111b0f846f3c1 https://github.com/openvswitch/ovs/commit/c9bc8c110eda65a36a958bc7ad7111b0f846f3c1 Author: zhangliping Date: 2018-02-26 (Mon, 26 Feb 2018) Changed paths: M lib/vlog.c Log Message: ----------- vlog: fix the incorrect zero padding in format_log_message If the format specifier does not have the 0 flag, we should pad with blanks instead of zeroes. Signed-off-by: zhangliping Signed-off-by: Ben Pfaff Acked-by: Mark Michelson Tested-by: Mark Michelson From noreply at github.com Mon Feb 26 19:56:19 2018 From: noreply at github.com (GitHub) Date: Mon, 26 Feb 2018 11:56:19 -0800 Subject: [ovs-git] [openvswitch/ovs] 6542e8: Set release date for 2.7.4. Message-ID: <5a9466636708a_601a2af7812f9c186115c@hookshot-fe-b0febf1.cp1-iad.github.net.mail> Branch: refs/heads/branch-2.7 Home: https://github.com/openvswitch/ovs Commit: 6542e8176012548c69585c4f79f6867a40551650 https://github.com/openvswitch/ovs/commit/6542e8176012548c69585c4f79f6867a40551650 Author: Justin Pettit Date: 2018-02-26 (Mon, 26 Feb 2018) Changed paths: M NEWS M debian/changelog Log Message: ----------- Set release date for 2.7.4. Signed-off-by: Justin Pettit Acked-by: Ben Pfaff Commit: 7138bbbb158b678978318c87e6eeaadd8fc1d816 https://github.com/openvswitch/ovs/commit/7138bbbb158b678978318c87e6eeaadd8fc1d816 Author: Justin Pettit Date: 2018-02-26 (Mon, 26 Feb 2018) Changed paths: M NEWS M configure.ac M debian/changelog Log Message: ----------- Prepare for 2.7.5. Signed-off-by: Justin Pettit Acked-by: Ben Pfaff Compare: https://github.com/openvswitch/ovs/compare/02c12c27e972...7138bbbb158b From noreply at github.com Mon Feb 26 20:00:54 2018 From: noreply at github.com (GitHub) Date: Mon, 26 Feb 2018 12:00:54 -0800 Subject: [ovs-git] [openvswitch/ovs] c635f6: ofproto-dpif-upcall: Fix using uninitialized fitne... Message-ID: <5a94677657c04_192e2abc5abb7c04997f9@hookshot-fe-32b5f5b.cp1-iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/openvswitch/ovs Commit: c635f687fd5922c27553924afe4878608ecf7440 https://github.com/openvswitch/ovs/commit/c635f687fd5922c27553924afe4878608ecf7440 Author: Ilya Maximets Date: 2018-02-26 (Mon, 26 Feb 2018) Changed paths: M ofproto/ofproto-dpif-upcall.c Log Message: ----------- ofproto-dpif-upcall: Fix using uninitialized fitness. 'upcall_xlate()' makes a decision to compose slow path actions by checking the 'upcall->fitness', which is not initialized in case of calling from the 'upcall_cb()'. 'upcall_cb()' receives the real flow, so the fitness should be initialized as perfect. Fixes following tests on travis: ofproto-dpif.at: ofproto-dpif megaflow - disabled - pmd ofproto-dpif.at: ofproto-dpif - conntrack - output action CC: Ben Pfaff Fixes: 687bafbb8a79 ("ofproto-dpif-upcall: Slow path flows that datapath can't fully match.") Signed-off-by: Ilya Maximets Signed-off-by: Ben Pfaff From noreply at github.com Mon Feb 26 20:06:41 2018 From: noreply at github.com (GitHub) Date: Mon, 26 Feb 2018 12:06:41 -0800 Subject: [ovs-git] [openvswitch/ovs] Message-ID: <5a9468d16b9cb_51b02adf6c1d1c14238da@hookshot-fe-6e9b612.cp1-iad.github.net.mail> Branch: refs/tags/v2.7.4 Home: https://github.com/openvswitch/ovs From noreply at github.com Mon Feb 26 20:14:10 2018 From: noreply at github.com (GitHub) Date: Mon, 26 Feb 2018 12:14:10 -0800 Subject: [ovs-git] [openvswitch/ovs] 2696bc: ovn-northd: Consistently use Datapath_Binding UUID... Message-ID: <5a946a92c0a82_189a2ac918cd7c04761cf@hookshot-fe-32b5f5b.cp1-iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/openvswitch/ovs Commit: 2696bcb1205837b50cdf4f5402926efa8753f7f6 https://github.com/openvswitch/ovs/commit/2696bcb1205837b50cdf4f5402926efa8753f7f6 Author: Ben Pfaff Date: 2018-02-26 (Mon, 26 Feb 2018) Changed paths: M ovn/northd/ovn-northd.c Log Message: ----------- ovn-northd: Consistently use Datapath_Binding UUID for hashing flows. In one place, ovn-northd was hashing Logical_Switch or Logical_Router UUIDs for ovn_lflow, and in another place it was hashing Datapath_Binding UUIDs. This caused problems. This commit changes ovn-northd to always hash the Datapath_Binding UUID. Jacob Sitnicki reported the following performance improvement for a similar fix: Children Self Command Shared Object Symbol before: 76.19% 0.01% ovn-northd ovn-northd [.] ovnnb_db_run 11.04% 0.43% ovn-northd ovn-northd [.] ovn_lflow_find after: 75.16% 0.05% ovn-northd ovn-northd [.] ovnnb_db_run 2.49% 0.17% ovn-northd ovn-northd [.] ovn_lflow_find Fixes: 8bf332225d4a ("ovn-northd: Reduce amount of flow hashing.") Reported-by: Jakub Sitnicki Signed-off-by: Ben Pfaff From noreply at github.com Mon Feb 26 22:23:46 2018 From: noreply at github.com (GitHub) Date: Mon, 26 Feb 2018 14:23:46 -0800 Subject: [ovs-git] [openvswitch/ovs] 8519ea: Refer to database manpages in *ctl manpages Message-ID: <5a9488f241786_18772aed314d5c0816797@hookshot-fe-32b5f5b.cp1-iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/openvswitch/ovs Commit: 8519ea87d7b84166a02d8f3f25c91a2ff7d5fe57 https://github.com/openvswitch/ovs/commit/8519ea87d7b84166a02d8f3f25c91a2ff7d5fe57 Author: Mark Michelson Date: 2018-02-26 (Mon, 26 Feb 2018) Changed paths: M lib/db-ctl-base.c M lib/db-ctl-base.h M ovn/lib/ovn-util.h M ovn/utilities/ovn-nbctl.8.xml M ovn/utilities/ovn-nbctl.c M ovn/utilities/ovn-sbctl.8.in M ovn/utilities/ovn-sbctl.c M utilities/ovs-vsctl.8.in M utilities/ovs-vsctl.c M vtep/vtep-ctl.c Log Message: ----------- Refer to database manpages in *ctl manpages The ovn-nbctl, ovn-sbctl, and ovs-vsctl manpages are inconsistent in their "Database Commands" section when it comes to referring to what database tables exist. This commit amends this by making each *ctl manpage reference the corresponding database manpage instead. To aid in having a more handy list, the --help text of ovn-nbctl, ovn-sbctl, and ovs-vsctl have been modified to list the available tables. This is also referenced in the manpages for those applications. Signed-off-by: Mark Michelson Signed-off-by: Ben Pfaff From noreply at github.com Mon Feb 26 22:37:25 2018 From: noreply at github.com (GitHub) Date: Mon, 26 Feb 2018 14:37:25 -0800 Subject: [ovs-git] [openvswitch/ovs] aac61d: tests: Make packet-type-aware.at hash independent Message-ID: <5a948c25b1c51_1b51e2acdd68adbfc13589@hookshot-fe-dfcc362.cp1-iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/openvswitch/ovs Commit: aac61d07e3e6307bd193729f4e76831b1c4fcbd2 https://github.com/openvswitch/ovs/commit/aac61d07e3e6307bd193729f4e76831b1c4fcbd2 Author: Balazs Nemeth Date: 2018-02-26 (Mon, 26 Feb 2018) Changed paths: M tests/packet-type-aware.at Log Message: ----------- tests: Make packet-type-aware.at hash independent When compiling with -msse4.2 a test case of packet-type-aware.at will fail due to the CRC32 based hash function is different from mhash. Fix this issue with parsing the port statistics one-by-one. Signed-off-by: Balazs Nemeth CC: Jan Scheurich CC: Zoltan Balogh Fixes: 00135b869d7c ("xlate: fix xport lookup for recirc") Signed-off-by: Ben Pfaff From noreply at github.com Mon Feb 26 22:37:44 2018 From: noreply at github.com (GitHub) Date: Mon, 26 Feb 2018 14:37:44 -0800 Subject: [ovs-git] [openvswitch/ovs] 346c2a: tests: Make packet-type-aware.at hash independent Message-ID: <5a948c38b6a9c_6fb42b0fc6789c085071d@hookshot-fe-d252ca1.cp1-iad.github.net.mail> Branch: refs/heads/branch-2.9 Home: https://github.com/openvswitch/ovs Commit: 346c2a8bbf1d2c6092691a183006dec70419ded6 https://github.com/openvswitch/ovs/commit/346c2a8bbf1d2c6092691a183006dec70419ded6 Author: Balazs Nemeth Date: 2018-02-26 (Mon, 26 Feb 2018) Changed paths: M tests/packet-type-aware.at Log Message: ----------- tests: Make packet-type-aware.at hash independent When compiling with -msse4.2 a test case of packet-type-aware.at will fail due to the CRC32 based hash function is different from mhash. Fix this issue with parsing the port statistics one-by-one. Signed-off-by: Balazs Nemeth CC: Jan Scheurich CC: Zoltan Balogh Fixes: 00135b869d7c ("xlate: fix xport lookup for recirc") Signed-off-by: Ben Pfaff From noreply at github.com Mon Feb 26 22:37:49 2018 From: noreply at github.com (GitHub) Date: Mon, 26 Feb 2018 14:37:49 -0800 Subject: [ovs-git] [openvswitch/ovs] e1b154: tests: Make packet-type-aware.at hash independent Message-ID: <5a948c3d40058_61092aeaf696fc105465@hookshot-fe-31feec6.cp1-iad.github.net.mail> Branch: refs/heads/branch-2.8 Home: https://github.com/openvswitch/ovs Commit: e1b1540391be1fdc8e1747f9bd78350a429c0a3f https://github.com/openvswitch/ovs/commit/e1b1540391be1fdc8e1747f9bd78350a429c0a3f Author: Balazs Nemeth Date: 2018-02-26 (Mon, 26 Feb 2018) Changed paths: M tests/packet-type-aware.at Log Message: ----------- tests: Make packet-type-aware.at hash independent When compiling with -msse4.2 a test case of packet-type-aware.at will fail due to the CRC32 based hash function is different from mhash. Fix this issue with parsing the port statistics one-by-one. Signed-off-by: Balazs Nemeth CC: Jan Scheurich CC: Zoltan Balogh Fixes: 00135b869d7c ("xlate: fix xport lookup for recirc") Signed-off-by: Ben Pfaff From noreply at github.com Mon Feb 26 22:40:40 2018 From: noreply at github.com (GitHub) Date: Mon, 26 Feb 2018 14:40:40 -0800 Subject: [ovs-git] [openvswitch/ovs] f127bb: tunnel: Fix deletion of datapath tunnel ports in c... Message-ID: <5a948ce8c2d66_5cc62b12acccbc14413b6@hookshot-fe-b0febf1.cp1-iad.github.net.mail> Branch: refs/heads/branch-2.8 Home: https://github.com/openvswitch/ovs Commit: f127bb385f57823c8d8117448c2bae4d4669a46f https://github.com/openvswitch/ovs/commit/f127bb385f57823c8d8117448c2bae4d4669a46f Author: Balazs Nemeth Date: 2018-02-26 (Mon, 26 Feb 2018) Changed paths: M lib/tnl-ports.c M lib/tnl-ports.h M ofproto/ofproto-dpif.c M ofproto/tunnel.c M ofproto/tunnel.h M tests/tunnel-push-pop-ipv6.at M tests/tunnel-push-pop.at Log Message: ----------- tunnel: Fix deletion of datapath tunnel ports in case of reconfiguration There is an issue in OVS with tunnel deletion during the reconfiguration of OF tunnels. If the dst_port value is changed, the old tunnel map entry will not be deleted, because the tp_port argument of tnl_port_map_delete() has the new dst_port setting, hence the tunnel cannot be found in the list of tnl_port structures. The patch corrects this mechanism by adding a new argument, 'old_odp_port' to tnl_port_reconfigure(). This value is used to identify the datapath tunnel port which is being reconfigured. In connection with this fix, to unify the tunnel port map handling, odp_port value is used to search the proper port to insert and delete tunnel map entries as well. This variable can be used instead of tp_port, as it is unique for all datapath tunnel ports, and there is no need to reach dst_port from netdev_tunnel_config structure. This patch also adds a printout to check the reference counter of a tnl_port structure in tnl-port.c. Extending OVS unit test cases to have ref_cnt values in the expected dump. Adding new test cases to check if packet receiving is still working in the case of OF tunnel port deletion. Adding new test cases to check the reference counter in case of OF tunnel deletion or reconfiguration. Signed-off-by: Balazs Nemeth Signed-off-by: Jan Scheurich Co-authored-by: Jan Scheurich Signed-off-by: Ben Pfaff From noreply at github.com Tue Feb 27 18:17:20 2018 From: noreply at github.com (GitHub) Date: Tue, 27 Feb 2018 10:17:20 -0800 Subject: [ovs-git] [openvswitch/ovs] 879b2d: selinux: include the svirt_t type Message-ID: <5a95a0b0bee16_4bf32afe374b1c10165c@hookshot-fe-88eb02d.cp1-iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/openvswitch/ovs Commit: 879b2d342fd517bfcb6b0400c6fdab8331934279 https://github.com/openvswitch/ovs/commit/879b2d342fd517bfcb6b0400c6fdab8331934279 Author: Aaron Conole Date: 2018-02-27 (Tue, 27 Feb 2018) Changed paths: M selinux/openvswitch-custom.te.in Log Message: ----------- selinux: include the svirt_t type The dpdk policy adds support for interacting with libvirt, but failed to include the appropriate svirt_t type. This results in an error like: openvswitch-custom.te:53:ERROR 'unknown type svirt_t' at token ';' on line 1060: Reported-by: Guoshuai Li Signed-off-by: Aaron Conole Acked-by: Ansis Atteka From noreply at github.com Tue Feb 27 19:29:10 2018 From: noreply at github.com (GitHub) Date: Tue, 27 Feb 2018 11:29:10 -0800 Subject: [ovs-git] [openvswitch/ovs] 6a6ee1: datapath-windows: fix hash creation on ct mark Message-ID: <5a95b18639e7a_486a2af14b3ebc0c90270@hookshot-fe-88eb02d.cp1-iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/openvswitch/ovs Commit: 6a6ee1e9a56ec8409f9c7bfdcfd131584ead8cd7 https://github.com/openvswitch/ovs/commit/6a6ee1e9a56ec8409f9c7bfdcfd131584ead8cd7 Author: Alin Gabriel Serdean Date: 2018-02-27 (Tue, 27 Feb 2018) Changed paths: M datapath-windows/ovsext/Flow.c Log Message: ----------- datapath-windows: fix hash creation on ct mark Use key->ct.mark instead of key->ct.zone when generating the hash over the mark. Signed-off-by: Alin Gabriel Serdean Acked-by: Ben Pfaff Acked-by: Anand Kumar From noreply at github.com Tue Feb 27 19:30:57 2018 From: noreply at github.com (GitHub) Date: Tue, 27 Feb 2018 11:30:57 -0800 Subject: [ovs-git] [openvswitch/ovs] eb49d3: datapath-windows: fix hash creation on ct mark Message-ID: <5a95b1f1c20d4_f482b2648d75c1426442@hookshot-fe-265448d.cp1-iad.github.net.mail> Branch: refs/heads/branch-2.9 Home: https://github.com/openvswitch/ovs Commit: eb49d391d6e7d94fbbd46cb85b62214e38d72f00 https://github.com/openvswitch/ovs/commit/eb49d391d6e7d94fbbd46cb85b62214e38d72f00 Author: Alin Gabriel Serdean Date: 2018-02-27 (Tue, 27 Feb 2018) Changed paths: M datapath-windows/ovsext/Flow.c Log Message: ----------- datapath-windows: fix hash creation on ct mark Use key->ct.mark instead of key->ct.zone when generating the hash over the mark. Signed-off-by: Alin Gabriel Serdean Acked-by: Ben Pfaff Acked-by: Anand Kumar From noreply at github.com Tue Feb 27 19:32:03 2018 From: noreply at github.com (GitHub) Date: Tue, 27 Feb 2018 11:32:03 -0800 Subject: [ovs-git] [openvswitch/ovs] 4c412d: datapath-windows: fix hash creation on ct mark Message-ID: <5a95b2338e9b0_2862afb046d7c1447191@hookshot-fe-d2afb11.cp1-iad.github.net.mail> Branch: refs/heads/branch-2.8 Home: https://github.com/openvswitch/ovs Commit: 4c412d44755ac7dab4e003f31494868af9f5fec0 https://github.com/openvswitch/ovs/commit/4c412d44755ac7dab4e003f31494868af9f5fec0 Author: Alin Gabriel Serdean Date: 2018-02-27 (Tue, 27 Feb 2018) Changed paths: M datapath-windows/ovsext/Flow.c Log Message: ----------- datapath-windows: fix hash creation on ct mark Use key->ct.mark instead of key->ct.zone when generating the hash over the mark. Signed-off-by: Alin Gabriel Serdean Acked-by: Ben Pfaff Acked-by: Anand Kumar From noreply at github.com Tue Feb 27 19:33:12 2018 From: noreply at github.com (GitHub) Date: Tue, 27 Feb 2018 11:33:12 -0800 Subject: [ovs-git] [openvswitch/ovs] d041ec: datapath-windows: fix hash creation on ct mark Message-ID: <5a95b278f89_222b2b0591207bfc25987@hookshot-fe-7191cb1.cp1-iad.github.net.mail> Branch: refs/heads/branch-2.7 Home: https://github.com/openvswitch/ovs Commit: d041ec2ecc5d03481ce0f503f58f25b4a3179f32 https://github.com/openvswitch/ovs/commit/d041ec2ecc5d03481ce0f503f58f25b4a3179f32 Author: Alin Gabriel Serdean Date: 2018-02-27 (Tue, 27 Feb 2018) Changed paths: M datapath-windows/ovsext/Flow.c Log Message: ----------- datapath-windows: fix hash creation on ct mark Use key->ct.mark instead of key->ct.zone when generating the hash over the mark. Signed-off-by: Alin Gabriel Serdean Acked-by: Ben Pfaff Acked-by: Anand Kumar From noreply at github.com Tue Feb 27 19:33:31 2018 From: noreply at github.com (GitHub) Date: Tue, 27 Feb 2018 11:33:31 -0800 Subject: [ovs-git] [openvswitch/ovs] addbb2: datapath-windows: fix hash creation on ct mark Message-ID: <5a95b28b51eec_7a712ab42e075c0850151@hookshot-fe-da92815.cp1-iad.github.net.mail> Branch: refs/heads/branch-2.6 Home: https://github.com/openvswitch/ovs Commit: addbb27510923adc5d9fa3c729b4824d41b5ba86 https://github.com/openvswitch/ovs/commit/addbb27510923adc5d9fa3c729b4824d41b5ba86 Author: Alin Gabriel Serdean Date: 2018-02-27 (Tue, 27 Feb 2018) Changed paths: M datapath-windows/ovsext/Flow.c Log Message: ----------- datapath-windows: fix hash creation on ct mark Use key->ct.mark instead of key->ct.zone when generating the hash over the mark. Signed-off-by: Alin Gabriel Serdean Acked-by: Ben Pfaff Acked-by: Anand Kumar From noreply at github.com Wed Feb 28 03:51:00 2018 From: noreply at github.com (GitHub) Date: Tue, 27 Feb 2018 19:51:00 -0800 Subject: [ovs-git] [openvswitch/ovs] b3e647: compat: Fix RHEL 7 compile Message-ID: <5a9627242a64b_76b42b11263a5c0c6546c@hookshot-fe-d252ca1.cp1-iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/openvswitch/ovs Commit: b3e647cae4489769979e66ff1b6efa890eefb9b2 https://github.com/openvswitch/ovs/commit/b3e647cae4489769979e66ff1b6efa890eefb9b2 Author: Greg Rose Date: 2018-02-27 (Tue, 27 Feb 2018) Changed paths: M acinclude.m4 M datapath/linux/compat/include/net/inet_frag.h Log Message: ----------- compat: Fix RHEL 7 compile frag_percpu_counter_batch is a variable, not a define, so checking if it is defined is an error and causes warning messages during compile on RHEL 7 (or other 3.10 based) builds. Use a compat #define from acinclude.m4 instead. Fixes: 64d8cb7295 ("compat:inet_frag.h: Check for frag_percpu_counter_batch") Signed-off-by: Greg Rose Acked-by: Pravin B Shelar Commit: be317f8a107814e606788683efa350b0c3f7befb https://github.com/openvswitch/ovs/commit/be317f8a107814e606788683efa350b0c3f7befb Author: Greg Rose Date: 2018-02-27 (Tue, 27 Feb 2018) Changed paths: M datapath/linux/compat/include/linux/netdevice.h Log Message: ----------- compat: Fix RHEL 7 build warnings A prior commit to fix up netdev_master_upper_dev_link for recent kernels caused a compile warning on RHEL 7 builds. Fixes: 36d3520b5f ("datapath: Fix netdev_master_upper_dev_link for 4.14") Signed-off-by: Greg Rose Acked-by: Pravin B Shelar Compare: https://github.com/openvswitch/ovs/compare/6a6ee1e9a56e...be317f8a1078 From noreply at github.com Wed Feb 28 03:56:26 2018 From: noreply at github.com (GitHub) Date: Tue, 27 Feb 2018 19:56:26 -0800 Subject: [ovs-git] [openvswitch/ovs] 49fd2c: datapath: compat: Fix RHEL 7 compile Message-ID: <5a96286a5ad4d_59472aff22e97c0c10507@hookshot-fe-6b2eebc.cp1-iad.github.net.mail> Branch: refs/heads/branch-2.9 Home: https://github.com/openvswitch/ovs Commit: 49fd2c78703aa7a5e768ba6e1fa631d50611bec1 https://github.com/openvswitch/ovs/commit/49fd2c78703aa7a5e768ba6e1fa631d50611bec1 Author: Greg Rose Date: 2018-02-27 (Tue, 27 Feb 2018) Changed paths: M acinclude.m4 M datapath/linux/compat/include/net/inet_frag.h Log Message: ----------- datapath: compat: Fix RHEL 7 compile frag_percpu_counter_batch is a variable, not a define, so checking if it is defined is an error and causes warning messages during compile on RHEL 7 (or other 3.10 based) builds. Use a compat #define from acinclude.m4 instead. Fixes: 2070685328a6a ("compat:inet_frag.h: Check for frag_percpu_counter_batch") Signed-off-by: Greg Rose Acked-by: Pravin B Shelar Commit: 5f0ad23e5cbc32ad9b29fecb098b8ee09c89dd36 https://github.com/openvswitch/ovs/commit/5f0ad23e5cbc32ad9b29fecb098b8ee09c89dd36 Author: Greg Rose Date: 2018-02-27 (Tue, 27 Feb 2018) Changed paths: M datapath/linux/compat/include/linux/netdevice.h Log Message: ----------- compat: Fix RHEL 7 build warnings A prior commit to fix up netdev_master_upper_dev_link for recent kernels caused a compile warning on RHEL 7 builds. Fixes: 86a94a96163c ("datapath: Fix netdev_master_upper_dev_link for 4.14") Signed-off-by: Greg Rose Acked-by: Pravin B Shelar Compare: https://github.com/openvswitch/ovs/compare/eb49d391d6e7...5f0ad23e5cbc From noreply at github.com Wed Feb 28 20:44:45 2018 From: noreply at github.com (GitHub) Date: Wed, 28 Feb 2018 12:44:45 -0800 Subject: [ovs-git] [openvswitch/ovs] dac7a4: ovn-sbctl: Remove incorrect manpage options. Message-ID: <5a9714bd1a97_4f122b1ca8df3c089509a@hookshot-fe-6b2eebc.cp1-iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/openvswitch/ovs Commit: dac7a423fa1d9f5a2581b911794a4b71e9cb974c https://github.com/openvswitch/ovs/commit/dac7a423fa1d9f5a2581b911794a4b71e9cb974c Author: Dan Williams Date: 2018-02-28 (Wed, 28 Feb 2018) Changed paths: M AUTHORS.rst M manpages.mk M ovn/utilities/ovn-sbctl.8.in Log Message: ----------- ovn-sbctl: Remove incorrect manpage options. These options are not implemented by ovn-sbctl. Signed-off-by: Dan Williams Signed-off-by: Ben Pfaff From noreply at github.com Wed Feb 28 20:48:24 2018 From: noreply at github.com (GitHub) Date: Wed, 28 Feb 2018 12:48:24 -0800 Subject: [ovs-git] [openvswitch/ovs] 4c0ca6: Fix type-setting in ovsdb-idlc man page. Message-ID: <5a9715985c369_49592aed3bab3c10832f1@hookshot-fe-88eb02d.cp1-iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/openvswitch/ovs Commit: 4c0ca6b7a03f965a97d71741bf30615b5613949c https://github.com/openvswitch/ovs/commit/4c0ca6b7a03f965a97d71741bf30615b5613949c Author: Jakub Sitnicki Date: 2018-02-28 (Wed, 28 Feb 2018) Changed paths: M ovsdb/ovsdb-idlc.1 Log Message: ----------- Fix type-setting in ovsdb-idlc man page. - Remove extra escape sequences for switching to bold font. - Add missing escape sequences for switching back to normal font. Reported-at: https://mail.openvswitch.org/pipermail/ovs-dev/2018-February/344591.html Signed-off-by: Jakub Sitnicki Signed-off-by: Ben Pfaff From noreply at github.com Wed Feb 28 20:49:04 2018 From: noreply at github.com (GitHub) Date: Wed, 28 Feb 2018 12:49:04 -0800 Subject: [ovs-git] [openvswitch/ovs] 9ffcd3: AUTHORS: update email address for Mark Kavanagh Message-ID: <5a9715c04af1d_1bf02b24cb369c081112ad@hookshot-fe-32b5f5b.cp1-iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/openvswitch/ovs Commit: 9ffcd35dca2afef4e7a4a2b65efd6f66e3304b0f https://github.com/openvswitch/ovs/commit/9ffcd35dca2afef4e7a4a2b65efd6f66e3304b0f Author: Mark Kavanagh Date: 2018-02-28 (Wed, 28 Feb 2018) Changed paths: M AUTHORS.rst Log Message: ----------- AUTHORS: update email address for Mark Kavanagh Signed-off-by: Mark Kavanagh Signed-off-by: Ben Pfaff From noreply at github.com Wed Feb 28 21:01:19 2018 From: noreply at github.com (GitHub) Date: Wed, 28 Feb 2018 13:01:19 -0800 Subject: [ovs-git] [openvswitch/ovs] 417784: cmap: Fix example provided for CMAP_FOR_EACH. Message-ID: <5a97189fb3398_416a2ab423effc0c241a1@hookshot-fe-5a11256.cp1-iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/openvswitch/ovs Commit: 417784dc7e9ceda3b53d464e9567d60a1ec0c456 https://github.com/openvswitch/ovs/commit/417784dc7e9ceda3b53d464e9567d60a1ec0c456 Author: Justin Pettit Date: 2018-02-28 (Wed, 28 Feb 2018) Changed paths: M lib/cmap.h Log Message: ----------- cmap: Fix example provided for CMAP_FOR_EACH. Signed-off-by: Justin Pettit Acked-by: Ben Pfaff From noreply at github.com Wed Feb 28 21:09:15 2018 From: noreply at github.com (GitHub) Date: Wed, 28 Feb 2018 13:09:15 -0800 Subject: [ovs-git] [openvswitch/ovs] eab138: python: avoid useless JSON conversion to enhance p... Message-ID: <5a971a7b5e6bd_7d5b2ad92de01c0445286@hookshot-fe-da92815.cp1-iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/openvswitch/ovs Commit: eab138764e3aaa9f98a725a4636dd30e2a41a896 https://github.com/openvswitch/ovs/commit/eab138764e3aaa9f98a725a4636dd30e2a41a896 Author: Daniel Alvarez Date: 2018-02-28 (Wed, 28 Feb 2018) Changed paths: M python/ovs/db/idl.py Log Message: ----------- python: avoid useless JSON conversion to enhance performance This patch removes a useless conversion to/from JSON in the processing of any 'modify' operations inside the process_update2 method in Python IDL implementation. Previous code will make resources creation take longer as the number of elements in the row grows because of that JSON conversion. This patch eliminates it and now the time remains consant regardless of the database contents improving performance and scaling. Reported-by: Daniel Alvarez Reported-at: https://mail.openvswitch.org/pipermail/ovs-discuss/2018-February/046263.html Signed-off-by: Daniel Alvarez Acked-by: Terry Wilson Tested-By: Terry Wilson Acked-by: Han Zhou Signed-off-by: Ben Pfaff From noreply at github.com Wed Feb 28 21:12:55 2018 From: noreply at github.com (GitHub) Date: Wed, 28 Feb 2018 13:12:55 -0800 Subject: [ovs-git] [openvswitch/ovs] ef4da7: selinux: drop autogenerated files Message-ID: <5a971b5746bb8_502b2b097a0fbc081081ad@hookshot-fe-6b2eebc.cp1-iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/openvswitch/ovs Commit: ef4da7cd9279ccb79f69196ec95de83037be100f https://github.com/openvswitch/ovs/commit/ef4da7cd9279ccb79f69196ec95de83037be100f Author: Aaron Conole Date: 2018-02-28 (Wed, 28 Feb 2018) Changed paths: M selinux/automake.mk Log Message: ----------- selinux: drop autogenerated files When running a make clean, it is desirable for the autogenerated files to be removed. Signed-off-by: Aaron Conole Signed-off-by: Ben Pfaff Commit: 6330f30086f59c336bf82b30823532e5db8929d3 https://github.com/openvswitch/ovs/commit/6330f30086f59c336bf82b30823532e5db8929d3 Author: Aaron Conole Date: 2018-02-28 (Wed, 28 Feb 2018) Changed paths: M .travis.yml M .travis/linux-build.sh Log Message: ----------- travis: build the selinux policy under linux When performing a linux build, create the selinux policy. This ensures that the selinux policy files are at least 'compile' tested when changes occur. Signed-off-by: Aaron Conole Signed-off-by: Ben Pfaff Compare: https://github.com/openvswitch/ovs/compare/eab138764e3a...6330f30086f5 From noreply at github.com Wed Feb 28 21:28:58 2018 From: noreply at github.com (GitHub) Date: Wed, 28 Feb 2018 13:28:58 -0800 Subject: [ovs-git] [openvswitch/ovs] 1139c7: ofproto: fix comment about ofproto-dpif Message-ID: <5a971f1a465e8_79102ac0535e3c044377e@hookshot-fe-da92815.cp1-iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/openvswitch/ovs Commit: 1139c77dffe6217a118ec2bd9009cbee06e588fb https://github.com/openvswitch/ovs/commit/1139c77dffe6217a118ec2bd9009cbee06e588fb Author: William Tu Date: 2018-02-28 (Wed, 28 Feb 2018) Changed paths: M ofproto/ofproto-dpif.h Log Message: ----------- ofproto: fix comment about ofproto-dpif "dpif-netlink" is the dpif to communicate with kernel. So replace "dpif-linux" with "dpif-netlink". Signed-off-by: William Tu Signed-off-by: Ben Pfaff From noreply at github.com Wed Feb 28 23:03:55 2018 From: noreply at github.com (GitHub) Date: Wed, 28 Feb 2018 15:03:55 -0800 Subject: [ovs-git] [openvswitch/ovs] 7ed58d: Don't shadow global VLOG "rl" definition. Message-ID: <5a97355b6d787_1a622abb08555c108719d@hookshot-fe-cace476.cp1-iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/openvswitch/ovs Commit: 7ed58d4a0daeffec52d603ad034a85d0d3011c8d https://github.com/openvswitch/ovs/commit/7ed58d4a0daeffec52d603ad034a85d0d3011c8d Author: Justin Pettit Date: 2018-02-28 (Wed, 28 Feb 2018) Changed paths: M lib/netdev-linux.c M lib/ofp-actions.c M lib/ofp-port.c M ofproto/connmgr.c M ofproto/ofproto-dpif-upcall.c M ofproto/ofproto-dpif.c M ofproto/ofproto.c Log Message: ----------- Don't shadow global VLOG "rl" definition. Signed-off-by: Justin Pettit Acked-by: Ben Pfaff Commit: ccf690ac3749fcd46a8c7ab5c739318572ab4200 https://github.com/openvswitch/ovs/commit/ccf690ac3749fcd46a8c7ab5c739318572ab4200 Author: Justin Pettit Date: 2018-02-28 (Wed, 28 Feb 2018) Changed paths: M lib/cmap.h Log Message: ----------- cmap: Allow CMAP_FOR_EACH to be nested without shadowing variables. Signed-off-by: Justin Pettit Acked-by: Ben Pfaff Commit: e883448e3f90e75aedf20e969b61334357fcf7b3 https://github.com/openvswitch/ovs/commit/e883448e3f90e75aedf20e969b61334357fcf7b3 Author: Justin Pettit Date: 2018-02-28 (Wed, 28 Feb 2018) Changed paths: M lib/conntrack.c M lib/dp-packet.h M lib/dpif-netdev.c M lib/netdev-dpdk.c M lib/netdev-dummy.c M lib/netdev-linux.c M lib/netdev.c M lib/odp-execute.c M tests/test-conntrack.c Log Message: ----------- dp-packet: Add index to DP_PACKET_BATCH_FOR_EACH to prevent shadowing. Signed-off-by: Justin Pettit Acked-by: Ben Pfaff Commit: 97bf8f478d1956ee28b40a564b35cfb065782e0c https://github.com/openvswitch/ovs/commit/97bf8f478d1956ee28b40a564b35cfb065782e0c Author: Justin Pettit Date: 2018-02-28 (Wed, 28 Feb 2018) Changed paths: M lib/dpif-netdev.c M lib/nx-match.c Log Message: ----------- Don't shadow iterator values. Signed-off-by: Justin Pettit Acked-by: Ben Pfaff Commit: bcfed2313689f95cc07e07b7fa8aef779add9460 https://github.com/openvswitch/ovs/commit/bcfed2313689f95cc07e07b7fa8aef779add9460 Author: Justin Pettit Date: 2018-02-28 (Wed, 28 Feb 2018) Changed paths: M lib/db-ctl-base.c M lib/db-ctl-base.h Log Message: ----------- db-ctl-base: Don't shadow 'invalidate_cache' callback. Signed-off-by: Justin Pettit Acked-by: Ben Pfaff Commit: 84b99a04900a745f7addef616eb188a2dccf3233 https://github.com/openvswitch/ovs/commit/84b99a04900a745f7addef616eb188a2dccf3233 Author: Justin Pettit Date: 2018-02-28 (Wed, 28 Feb 2018) Changed paths: M lib/ovs-numa.c M lib/ovs-numa.h Log Message: ----------- ovs-numa: Prevent shadowing 'dummy_config'. Signed-off-by: Justin Pettit Acked-by: Ben Pfaff Commit: 396d492cfa8dcc6bb9b636a042d419b798e49264 https://github.com/openvswitch/ovs/commit/396d492cfa8dcc6bb9b636a042d419b798e49264 Author: Justin Pettit Date: 2018-02-28 (Wed, 28 Feb 2018) Changed paths: M lib/daemon-unix.c M lib/route-table.c M lib/stream-ssl.c M ofproto/ofproto-dpif-upcall.c M ofproto/ofproto-dpif.c M ovn/controller/ofctrl.c M ovn/controller/pinctrl.c M ovn/northd/ovn-northd.c M tests/test-classifier.c M tests/test-conntrack.c M utilities/ovs-ofctl.c Log Message: ----------- Don't shadow variables. Rename the remaining variables that were shadowing another definition. Signed-off-by: Justin Pettit Acked-by: Ben Pfaff Commit: bc7284f56198636c2bace98bc3bc269da67a5fd1 https://github.com/openvswitch/ovs/commit/bc7284f56198636c2bace98bc3bc269da67a5fd1 Author: Justin Pettit Date: 2018-02-28 (Wed, 28 Feb 2018) Changed paths: M configure.ac Log Message: ----------- Add -Wshadow for compilers that support it. Signed-off-by: Justin Pettit Acked-by: Ben Pfaff Compare: https://github.com/openvswitch/ovs/compare/1139c77dffe6...bc7284f56198