[ovs-git] [openvswitch/ovs] 98f2d3: debian: Do not modify pre-existing defaults file

GitHub noreply at github.com
Thu Feb 1 21:47:23 UTC 2018

  Branch: refs/heads/master
  Home:   https://github.com/openvswitch/ovs
  Commit: 98f2d36d2394bfa6f9717fc5c91db2921092464f
  Author: Frode Nordahl <frode.nordahl at gmail.com>
  Date:   2018-02-01 (Thu, 01 Feb 2018)

  Changed paths:
    M debian/openvswitch-switch.postinst

  Log Message:
  debian: Do not modify pre-existing defaults file

Currently, on installation or upgrade the openvswitch-switch deb package
will in some circumstances modify a pre-existing
/etc/default/openvswitch-switch configuration file.

This does not play well with modeling and configuration management tools
and may lead to unnecessary restarts of the openvswitch-switch service
after the initial restart done as part of the package upgrade. As
restarting the openvswitch-switch affects the datapath this is
something we should try to avoid.

I also believe the current behaviour to be in conflict with best practices
set out in the config files section of the
[Debian Policy](https://www.debian.org/doc/debian-policy/#s-config-files).

This commit addresses this by removing the part of the postinst script
that attempts to append missing documentation parts of the template
and leaves the installed defaults file alone when it exists.

Fixes: 0aaa379d99f4 ("Debian packaging: Add several new settings to /etc/default/openflow-switch.")
Signed-off-by: Frode Nordahl <frode.nordahl at gmail.com>
Reported-at: https://github.com/openvswitch/ovs-issues/issues/137
Signed-off-by: Ben Pfaff <blp at ovn.org>

More information about the git mailing list