[ovs-git] [openvswitch/ovs] c635f6: ofproto-dpif-upcall: Fix using uninitialized fitne...

GitHub noreply at github.com
Mon Feb 26 20:00:54 UTC 2018

  Branch: refs/heads/master
  Home:   https://github.com/openvswitch/ovs
  Commit: c635f687fd5922c27553924afe4878608ecf7440
  Author: Ilya Maximets <i.maximets at samsung.com>
  Date:   2018-02-26 (Mon, 26 Feb 2018)

  Changed paths:
    M ofproto/ofproto-dpif-upcall.c

  Log Message:
  ofproto-dpif-upcall: Fix using uninitialized fitness.

'upcall_xlate()' makes a decision to compose slow path actions
by checking the 'upcall->fitness', which is not initialized in
case of calling from the 'upcall_cb()'.

'upcall_cb()' receives the real flow, so the fitness should be
initialized as perfect.

Fixes following tests on travis:

    ofproto-dpif.at: ofproto-dpif megaflow - disabled - pmd
    ofproto-dpif.at: ofproto-dpif - conntrack - output action

CC: Ben Pfaff <blp at ovn.org>
Fixes: 687bafbb8a79 ("ofproto-dpif-upcall: Slow path flows that
                datapath can't fully match.")
Signed-off-by: Ilya Maximets <i.maximets at samsung.com>
Signed-off-by: Ben Pfaff <blp at ovn.org>

More information about the git mailing list