[ovs-git] [openvswitch/ovs] 2696bc: ovn-northd: Consistently use Datapath_Binding UUID...

GitHub noreply at github.com
Mon Feb 26 20:14:10 UTC 2018


  Branch: refs/heads/master
  Home:   https://github.com/openvswitch/ovs
  Commit: 2696bcb1205837b50cdf4f5402926efa8753f7f6
      https://github.com/openvswitch/ovs/commit/2696bcb1205837b50cdf4f5402926efa8753f7f6
  Author: Ben Pfaff <blp at ovn.org>
  Date:   2018-02-26 (Mon, 26 Feb 2018)

  Changed paths:
    M ovn/northd/ovn-northd.c

  Log Message:
  -----------
  ovn-northd: Consistently use Datapath_Binding UUID for hashing flows.

In one place, ovn-northd was hashing Logical_Switch or Logical_Router UUIDs
for ovn_lflow, and in another place it was hashing Datapath_Binding UUIDs.
This caused problems.  This commit changes ovn-northd to always hash the
Datapath_Binding UUID.

Jacob Sitnicki reported the following performance improvement for a similar
fix:

  Children      Self  Command     Shared Object        Symbol
before:
    76.19%     0.01%  ovn-northd  ovn-northd           [.] ovnnb_db_run
    11.04%     0.43%  ovn-northd  ovn-northd           [.] ovn_lflow_find
after:
    75.16%     0.05%  ovn-northd  ovn-northd           [.] ovnnb_db_run
     2.49%     0.17%  ovn-northd  ovn-northd           [.] ovn_lflow_find

Fixes: 8bf332225d4a ("ovn-northd: Reduce amount of flow hashing.")
Reported-by: Jakub Sitnicki <jkbs at redhat.com>
Signed-off-by: Ben Pfaff <blp at ovn.org>




More information about the git mailing list